chore: update logic module audit scope (#20556)

Update logic module audit scope

Author: ledwards2225

…ts/audit/audit_scopes/logic_scope_doc.md …/audit/audit_scopes/logic_audit_scope.mdbarretenberg/cpp/scripts/audit/audit_scopes/logic_scope_doc.md renamed to barretenberg/cpp/scripts/audit/audit_scopes/logic_audit_scope.md barretenberg/cpp/scripts/audit/audit_scopes/logic_scope_doc.md renamed to barretenberg/cpp/scripts/audit/audit_scopes/logic_audit_scope.md

@@ -2,20 +2,29 @@
 
 Repository: https://github.com/AztecProtocol/aztec-packages
 
-Commit hash: TBD
+Commit hash: e4712cda8def49d75fbba2d361625fc5e21945f5
 
 ## Files to Audit
 
 Note: Paths relative to `aztec-packages/barretenberg/cpp/src/barretenberg`
 
+### stdlib (core logic implementation)
+
 1. `stdlib/primitives/logic/logic.hpp`
 2. `stdlib/primitives/logic/logic.cpp`
 3. `stdlib_circuit_builders/plookup_tables/uint.hpp` (lookup tables)
 
+### dsl (ACIR interface)
+
+4. `dsl/acir_format/logic_constraint.hpp` — ACIR struct and gate function declarations
+5. `dsl/acir_format/logic_constraint.cpp` — Converts ACIR logic constraints into stdlib circuit gates
+
 ## Summary of Module
 
 The `logic` module provides circuit-friendly implementations of bitwise logical operations (XOR and AND) over variable-length unsigned integers using plookup tables.
 
+### stdlib layer
+
 Main function: `create_logic_constraint(a, b, num_bits, is_xor_gate)`
 
 - Computes `a XOR b` or `a AND b` for inputs up to `num_bits` in length
@@ -31,10 +40,19 @@ The implementation:
 - If both inputs are constants, the operation is computed natively without circuit constraints
 - If one input is constant, it is converted to a witness before processing
 
+### dsl layer
+
+The DSL layer bridges ACIR opcodes (`BlackBoxFuncCall::AND`, `BlackBoxFuncCall::XOR`) to the stdlib logic implementation:
+
+- `acir_to_constraint_buf.cpp` deserializes ACIR AND/XOR black box calls into `LogicConstraint` structs (deserialization file itself is out of scope)
+- `create_logic_gate` converts `WitnessOrConstant` inputs to `field_ct` via `to_field_ct`, calls `stdlib::logic::create_logic_constraint`, and asserts the computed result equals the ACIR-provided result witness
+
 ## Test Files
 
 1. `stdlib/primitives/logic/logic.test.cpp`
+2. `dsl/acir_format/logic_constraint.test.cpp`
 
 ## Dependencies
 
 - Plookup read: `stdlib/primitives/plookup/plookup.hpp`
+- ACIR format core: `dsl/acir_format/acir_format.hpp` (constraint application loop)

barretenberg/cpp/src/barretenberg/dsl/acir_format/logic_constraint.cpp

@@ -1,5 +1,5 @@
 // === AUDIT STATUS ===
-// internal:    { status: Planned, auditors: [], commit: }
+// internal:    { status: Complete, auditors: [Suyash], commit: e4712cda8def49d75fbba2d361625fc5e21945f5 }
 // external_1:  { status: not started, auditors: [], commit: }
 // external_2:  { status: not started, auditors: [], commit: }
 // =====================

barretenberg/cpp/src/barretenberg/dsl/acir_format/logic_constraint.hpp

@@ -1,5 +1,5 @@
 // === AUDIT STATUS ===
-// internal:    { status: Planned, auditors: [], commit: }
+// internal:    { status: Complete, auditors: [Suyash], commit: e4712cda8def49d75fbba2d361625fc5e21945f5 }
 // external_1:  { status: not started, auditors: [], commit: }
 // external_2:  { status: not started, auditors: [], commit: }
 // =====================

barretenberg/cpp/src/barretenberg/stdlib/primitives/logic/logic.cpp

@@ -1,5 +1,5 @@
 // === AUDIT STATUS ===
-// internal:    { status: Planned, auditors: [], commit: }
+// internal:    { status: Complete, auditors: [Suyash], commit: e4712cda8def49d75fbba2d361625fc5e21945f5 }
 // external_1:  { status: not started, auditors: [], commit: }
 // external_2:  { status: not started, auditors: [], commit: }
 // =====================

barretenberg/cpp/src/barretenberg/stdlib/primitives/logic/logic.hpp

@@ -1,5 +1,5 @@
 // === AUDIT STATUS ===
-// internal:    { status: Planned, auditors: [], commit: }
+// internal:    { status: Complete, auditors: [Suyash], commit: e4712cda8def49d75fbba2d361625fc5e21945f5 }
 // external_1:  { status: not started, auditors: [], commit: }
 // external_2:  { status: not started, auditors: [], commit: }
 // =====================

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/plookup_tables/uint.hpp

@@ -1,5 +1,5 @@
 // === AUDIT STATUS ===
-// internal:    { status: Planned, auditors: [], commit: }
+// internal:    { status: Complete, auditors: [Suyash], commit: e4712cda8def49d75fbba2d361625fc5e21945f5 }
 // external_1:  { status: not started, auditors: [], commit: }
 // external_2:  { status: not started, auditors: [], commit: }
 // =====================