feat(avm)!: enable optimized poseidon2 rels (#16467)

Updates bb-pilcom to change the generated files.

Now the choice of whether to use `generated/poseidon2_perm` or
`optimized/poseidon2_perm` can be made via `bb-pilcom` through the use
of `feature-flags` (see `README.md`).

I could not convince CMake to ignore building `generated/poseidon2_perm`
file even if it wasn't included in any other files, so the solution for
now was also to **not** generate the `poseidon2_perm` file when using
the optimized one.

This does mean that the generated folder should be deleted if switching
between from generated to optimized to minimise wasted compiling time
(this is already supported by the `-y` flag in the cli)

Author: IlyasRidhuan

barretenberg/cpp/src/barretenberg/vm2/constraining/relations/poseidon2.test.cpp

@@ -9,7 +9,7 @@
 #include "barretenberg/vm2/constraining/testing/check_relation.hpp"
 #include "barretenberg/vm2/generated/relations/lookups_poseidon2_hash.hpp"
 #include "barretenberg/vm2/generated/relations/poseidon2_hash.hpp"
-#include "barretenberg/vm2/generated/relations/poseidon2_perm.hpp"
+#include "barretenberg/vm2/optimized/relations/poseidon2_perm.hpp"
 #include "barretenberg/vm2/simulation/events/event_emitter.hpp"
 #include "barretenberg/vm2/simulation/lib/execution_id_manager.hpp"
 #include "barretenberg/vm2/simulation/range_check.hpp"
@@ -38,7 +38,7 @@ using tracegen::TestTraceContainer;
 using FF = AvmFlavorSettings::FF;
 using C = Column;
 using poseidon2_hash = bb::avm2::poseidon2_hash<FF>;
-using poseidon2_perm = bb::avm2::poseidon2_perm<FF>;
+using poseidon2_perm = bb::avm2::optimized_poseidon2_perm<FF>;
 using poseidon2_mem = bb::avm2::poseidon2_mem<FF>;
 
 using simulation::EventEmitter;

barretenberg/cpp/src/barretenberg/vm2/generated/flavor_variables.hpp

@@ -46,7 +46,6 @@
 #include "relations/nullifier_exists.hpp"
 #include "relations/poseidon2_hash.hpp"
 #include "relations/poseidon2_mem.hpp"
-#include "relations/poseidon2_perm.hpp"
 #include "relations/public_data_check.hpp"
 #include "relations/public_data_squash.hpp"
 #include "relations/range_check.hpp"
@@ -65,6 +64,9 @@
 #include "relations/update_check.hpp"
 #include "relations/written_public_data_slots_tree_check.hpp"
 
+// Optimized Relations
+#include "barretenberg/vm2/optimized/relations/poseidon2_perm.hpp"
+
 // Lookup and permutation relations
 #include "relations/lookups_address_derivation.hpp"
 #include "relations/lookups_addressing.hpp"
@@ -137,6 +139,9 @@ struct AvmFlavorVariables {
     // Need to be templated for recursive verifier
     template <typename FF_>
     using MainRelations_ = flat_tuple::tuple<
+
+        // Optimized Relations
+        avm2::optimized_poseidon2_perm<FF_>,
         // Relations
         avm2::address_derivation<FF_>,
         avm2::addressing<FF_>,
@@ -180,7 +185,6 @@ struct AvmFlavorVariables {
         avm2::nullifier_exists<FF_>,
         avm2::poseidon2_hash<FF_>,
         avm2::poseidon2_mem<FF_>,
-        avm2::poseidon2_perm<FF_>,
         avm2::public_data_check<FF_>,
         avm2::public_data_squash<FF_>,
         avm2::range_check<FF_>,