chore(docs): re-structuring how-to-guides (#16758)

- Moving the token contract tutorial to its place (removing the old one
which was already a draft) and renaming the file correctly
- Making all the how-to-guides generic. Snippets are not using
#include_code anymore but are generic, i.e. use
another_contract::another_function to explain how to call another
function from another contract. This helps the distinction between
how-tos and tutorials, plus makes them more maintainable assuming no big
changes to the syntax.
- Adding some structure to the how to guides so it's easier to just add
new ones :)
- Fixing broken links
- Making the guides work with the new Wallet interface

Author: AztecBot

cspell.json

@@ -253,6 +253,7 @@
     "prestat",
     "prevrandao",
     "println",
+    "privateland",
     "productionify",
     "protobuf",
     "protogalaxy",
@@ -263,6 +264,7 @@
     "proxify",
     "pseudocode",
     "pubkey",
+    "publicland",
     "pxes",
     "quickstart",
     "Quickstarts",

docs/docs-words.txt

@@ -349,3 +349,5 @@ Zcash
 Zybil
 nothin
 whoooaa
+flamegraphs
+mycontract

docs/docs/aztec/concepts/accounts/keys.md

@@ -106,7 +106,7 @@ When it comes to storing the signing key in a private note, there are several de
 
 #### Using Delayed Public Mutable state
 
-By [Delayed Public Mutable](../../../developers/guides/smart_contracts/storage_types.md#delayed-public-mutable) we mean privately readable publicly mutable state.
+By [Delayed Public Mutable](../../../developers/guides/smart_contracts/how_to_define_storage.md#delayed-public-mutable) we mean privately readable publicly mutable state.
 
 To make public state accessible privately, there is a delay window in public state updates. One needs this window to be able to generate proofs client-side. This approach would not generate additional nullifiers and commitments for each transaction while allowing the user to rotate their key. However, this causes every transaction to now have a time-to-live determined by the frequency of the delayed mutable state, as well as imposing restrictions on how fast keys can be rotated due to minimum delays.
 

docs/docs/aztec/concepts/advanced/authwit.md

@@ -141,4 +141,4 @@ We don't need to limit ourselves to the `transfer` function, we can use the same
 
 ### Next Steps
 
-Check out the [developer documentation](../../../developers/guides/smart_contracts/authwit.md) to see how to implement this in your own contracts.
+Check out the [developer documentation](../../../developers/guides/smart_contracts/how_to_use_authwit.md) to see how to implement this in your own contracts.

docs/docs/aztec/concepts/call_types.md

@@ -149,7 +149,7 @@ aztec = { git = "https://github.com/AztecProtocol/aztec-packages/", tag = "#incl
 
 Even with the router contract achieving good privacy is hard.
 For example, if the value being checked against is unique and stored in the contract's public storage, it's then simple to find private transactions that are using that value in the enqueued public reads, and therefore link them to this contract.
-For this reason it is encouraged to try to avoid public function calls and instead privately read [Shared State](../../developers/guides/smart_contracts/storage_types.md#delayed-public-mutable) when possible.
+For this reason it is encouraged to try to avoid public function calls and instead privately read [Shared State](../../developers/guides/smart_contracts/how_to_define_storage.md#delayed-public-mutable) when possible.
 
 ### Public Execution
 

docs/docs/aztec/smart_contracts/contract_creation.md

@@ -61,7 +61,7 @@ Aztec makes an important distinction between initialization and public deploymen
 
 ### Initialization
 
-Contract constructors are not enshrined in the protocol, but handled at the application circuit level. Constructors are methods used for initializing a contract, either private or public, and contract classes may declare more than a single constructor. They can be declared by the `#[initializer]` macro. You can read more about how to use them on the [Defining Initializer Functions](../../developers/guides/smart_contracts/define_functions.md#initializer-functions) page.
+Contract constructors are not enshrined in the protocol, but handled at the application circuit level. Constructors are methods used for initializing a contract, either private or public, and contract classes may declare more than a single constructor. They can be declared by the `#[initializer]` macro. You can read more about how to use them on the [Defining Initializer Functions](../../developers/guides/smart_contracts/how_to_define_functions.md#initializer-functions) page.
 
 A contract must ensure:
 

docs/docs/aztec/smart_contracts/functions/index.md

@@ -22,7 +22,7 @@ There are also special oracle functions, which can get data from outside of the
 ## Learn more about functions
 
 - [How function visibility works in Aztec](./visibility.md)
-- How to write an [initializer function](../../../developers/guides/smart_contracts/define_functions.md#initializer-functions)
+- How to write an [initializer function](../../../developers/guides/smart_contracts/how_to_define_functions.md#initializer-functions)
 - [Oracles](../oracles/index.md) and how Aztec smart contracts might use them
 - [How functions work under the hood](./attributes.md)
 

docs/docs/aztec/writing_efficient_contracts.md

@@ -51,7 +51,7 @@ When private functions are called, the overhead of a "kernel circuit" is added e
 
 #### Profiling using FlameGraph
 
-Measuring the gate count across a private function can be seen at the end of the counter tutorial [here](../developers/tutorials/contract_tutorials/counter_contract#investigate-the-increment-function). Full profiling and flamegraph commands explained [here](../developers/guides/smart_contracts/advanced/profiling_transactions).
+Measuring the gate count across a private function can be seen at the end of the counter tutorial [here](../developers/tutorials/contract_tutorials/counter_contract#investigate-the-increment-function). Full profiling and flamegraph commands explained [here](../developers/guides/smart_contracts/advanced/how_to_profile_transactions).
 
 ### L2 Data costs