chore: handover to governance (#16630)

Adds a test to se if we are correctly updating the ownerships and
handings things over to governance.

Updated part of the deployment setup to properly hand over things. Fixed
an issue with return values as we did not actually return the coinissuer
but just whoever owned the fee asset - which were not the same because
it was not handed over.

Author: LHerskind

aztec-up/test/bridge_and_claim.sh

@@ -42,7 +42,7 @@ aztec-wallet \
   --register-only
 
 aztec-wallet \
-  bridge-fee-juice 1000000000000000000 accounts:main \
+  bridge-fee-juice 1000000000000000000000 accounts:main \
   --mint \
   --no-wait
 

docs/docs/developers/guides/js_apps/how_to_pay_fees.md

@@ -100,7 +100,7 @@ import { L1FeeJuicePortalManager } from "@aztec/aztec.js";
 **CLI:**
 
 ```bash
-aztec-wallet bridge-fee-juice 1000000000000000000 myAccount --mint --no-wait
+aztec-wallet bridge-fee-juice 1000000000000000000000 myAccount --mint --no-wait
 ```
 
 ### Testnet
@@ -114,7 +114,7 @@ cast call $FEE_ASSET_HANDLER_CONTRACT "mint(address)" $MY_L1_ADDRESS --rpc-url <
 Then bridge with CLI:
 
 ```bash
-aztec-wallet bridge-fee-juice 1000000000000000000 myAccount --no-wait \
+aztec-wallet bridge-fee-juice 1000000000000000000000 myAccount --no-wait \
   --l1-rpc-urls https://rpc.sepolia.ethpandaops.io \
   --l1-chain-id 11155111 \
   --l1-private-key <YOUR_L1_PRIVATE_KEY>

docs/versioned_docs/version-v1.2.0/developers/reference/environment_reference/cli_wallet_reference.md

@@ -143,7 +143,7 @@ First register an account, mint the fee asset on L1 and bridge it to fee juice:
 
 ```bash title="bridge-fee-juice" showLineNumbers
 aztec-wallet create-account -a main --register-only
-aztec-wallet bridge-fee-juice 1000000000000000000 main --mint --no-wait
+aztec-wallet bridge-fee-juice 1000000000000000000000 main --mint --no-wait
 ```
 
 > <sup><sub><a href="https://github.com/AztecProtocol/aztec-packages/blob/v1.2.0/yarn-project/cli-wallet/test/flows/create_account_pay_native.sh#L8-L11" target="_blank" rel="noopener noreferrer">Source code: yarn-project/cli-wallet/test/flows/create_account_pay_native.sh#L8-L11</a></sub></sup>

docs/versioned_docs/version-v1.2.0/developers/tutorials/codealong/first_fees.md

@@ -307,13 +307,13 @@ aztec-wallet create-account -a accBFJ --register-only
 If using the Sandbox, free-minting is allowed from it's anvil L1 to be bridged and claimed on its Aztec node:
 
 ```bash
-aztec-wallet bridge-fee-juice 1000000000000000000 accBFJ --mint --no-wait
+aztec-wallet bridge-fee-juice 1000000000000000000000 accBFJ --mint --no-wait
 ```
 
 If using Aztec testnet, you'll first need an L1 account with sepolia, and additional params for the bridge-fee-juice command:
 
 ```bash
-aztec-wallet bridge-fee-juice 1000000000000000000 accBFJ --mint --no-wait \
+aztec-wallet bridge-fee-juice 1000000000000000000000 accBFJ --mint --no-wait \
   --l1-rpc-urls <See https://chainlist.org/chain/11155111> \ # eg https://rpc.sepolia.ethpandaops.io
   --l1-chain-id 11155111 \
   --l1-private-key <L1 private key of account holding sepolia>

l1-contracts/src/mock/TestERC20.sol

@@ -34,11 +34,8 @@ contract TestERC20 is ERC20, IMintableERC20, Ownable2Step {
   }
 
   function acceptOwnership() public virtual override(Ownable2Step) {
-    address oldOwner = owner();
     address newOwner = pendingOwner();
     super.acceptOwnership();
-
-    removeMinter(oldOwner);
     addMinter(newOwner);
   }
 }

l1-contracts/test/test_erc20/transferOwnership.t.sol

@@ -64,8 +64,6 @@ contract TransferOwnershipTest is TestERC20TestBase {
 
     assertEq(testERC20.owner(), _newOwner);
     assertEq(testERC20.minters(_newOwner), true);
-    if (_newOwner != oldOwner) {
-      assertEq(testERC20.minters(oldOwner), false);
-    }
+    assertEq(testERC20.minters(oldOwner), true);
   }
 }

spartan/devnet-smoke-tests/create_new_accounts.sh

@@ -35,7 +35,7 @@ if [ "$total_account_count" -lt "$max_accounts" ]; then
       -u $FAUCET_URL
 
     aztec-wallet \
-      bridge-fee-juice 1000000000000000000 accounts:main \
+      bridge-fee-juice 1000000000000000000000 accounts:main \
       --mint \
       --l1-rpc-urls $L1_URL \
       --l1-chain-id 1337 \

yarn-project/aztec-faucet/terraform/main.tf

@@ -148,7 +148,7 @@ resource "aws_ecs_task_definition" "aztec-faucet" {
         },
         {
           name  = "EXTRA_ASSET_AMOUNT",
-          value = "1000000000000000000"
+          value = "1000000000000000000000"
         }
       ]
       logConfiguration = {

yarn-project/cli-wallet/test/flows/create_account_pay_native.sh

@@ -7,7 +7,7 @@ test_title "Create an account and deploy using native fee payment with bridging"
 
 # docs:start:bridge-fee-juice
 aztec-wallet create-account -a main --register-only
-aztec-wallet bridge-fee-juice 1000000000000000000 main --mint --no-wait
+aztec-wallet bridge-fee-juice 1000000000000000000000 main --mint --no-wait
 # docs:end:bridge-fee-juice
 
 

yarn-project/cli-wallet/test/flows/shared/create_funded_account.sh

@@ -3,7 +3,7 @@ ALIAS=$1
 section "Creating a funded account (alias: $ALIAS)"
 
 aztec-wallet create-account -a $ALIAS --register-only
-aztec-wallet bridge-fee-juice 1000000000000000000 $ALIAS --mint --no-wait
+aztec-wallet bridge-fee-juice 1000000000000000000000 $ALIAS --mint --no-wait
 
 # The following produces two blocks, allowing the claim to be used in the next block.
 source $flows/shared/deploy_token.sh tmp-token-$ALIAS $ALIAS