feat: merge-train/barretenberg (#19418)

BEGIN_COMMIT_OVERRIDE
chore: remove round.cpp and round.hpp in dsl/acir_format (#19412)
chore: docs for translator (#19056)
chore: update noir/noir-repo to match next branch
chore: update avm-transpiler Cargo.lock for noir submodule
fix: revert noir/noir-repo to match next and update Cargo.lock
fix: add actionable error when bb verify cannot find vk file (#19398)
chore: `utils.cpp` audit (#19425)
chore: sha audit 1 (#19072)
fix: improve no artifacts found message to include search path (#19432)
chore: simplify Flavors' Transcripts + VKs deduplication (#19326)
Add correct VKSerializationMode to AVM VerificationKey Classes
END_COMMIT_OVERRIDE

Author: AztecBot

barretenberg/cpp/scripts/audit/audit_scopes/dsl_audit_scope.md

@@ -12,8 +12,6 @@ Commit hash: 2094fd1467dd9a94803b2c5007cf60ac357aa7d2 (22.12.2025)
 4. `dsl/acir_format/acir_format.cpp`
 5. `dsl/acir_format/arithmetic_constraints.hpp`
 6. `dsl/acir_format/arithmetic_constraints.cpp`
-7. `dsl/acir_format/round.hpp`
-8. `dsl/acir_format/round.cpp`
 9. `dsl/acir_format/utils.hpp`
 10. `dsl/acir_format/utils.cpp`
 
@@ -27,15 +25,13 @@ All constraints except arithmetic constraints work as follows:
 1. Bytes deserialised into Barretenberg's internal representation (`acir_to_constraint_buf`)
 2. Iterate through all instances of the given constraint and add the constraint to the circuit (`acir_format`)
 
-Arithmetic constraints work slighly differently because we leverage the UltraHonk arithmetisation to efficiently encode expressions of the following form:
+Arithmetic constraints work slighly differently because we leverage the UltraHonk arithmetization to efficiently encode expressions of the following form:
 $
 \sum_{i, j} c_{i,j} w_i w_j + \sum_i c_i w_i + c = 0
-$ where $w_i$ are witnesses, $c_{i,j}, c_i$ are the coefficients of the equation, and $c$ is the constant term. For a detailed explanation of how we leverage the UltraHonk arithmetisation to encode arithmetic constraints see the documentation for the functions `acir_to_constraint_buf::split_into_mul_quad_gates` and `arithmetic_constraints::create_big_quad_constraint`.
+$ where $w_i$ are witnesses, $c_{i,j}, c_i$ are the coefficients of the equation, and $c$ is the constant term. For a detailed explanation of how we leverage the UltraHonk arithmetization to encode arithmetic constraints see the documentation for the functions `acir_to_constraint_buf::split_into_mul_quad_gates` and `arithmetic_constraints::create_big_quad_constraint`.
 
 The difference in how arithmetic constraints are handled is the reason why they are the only constraints that are part of this audit scope: to be sure that no bugs are present, the entire flow (from bytes to to constraints) has to be audited for arithmetic constraints.
 
-
-
 ## Test Files
 1. `dsl/acir_format/acir_format.test.cpp`
 2. `dsl/acir_format/arithmetic_constraints.test.cpp`

barretenberg/cpp/scripts/audit/audit_scopes/honk_proving_system_audit_scope.md

@@ -71,6 +71,8 @@ Note: Paths relative to `aztec-packages/barretenberg/cpp/src/barretenberg`
 50. `dsl/acir_format/recursion_constraint.cpp`
 51. `dsl/acir_format/recursion_constraint_output.hpp`
 52. `dsl/acir_format/recursion_constraint_output.cpp`
+53. `dsl/acir_format/honk_recursion_constraint.hpp`
+54. `dsl/acir_format/honk_recursion_constraint.cpp`
 53. `dsl/acir_format/mock_verifier_inputs.hpp`
 
 ## Summary of Module
@@ -93,6 +95,7 @@ The Honk proving system is Barretenberg's core SNARK proving system implementing
 13. `ultra_honk/lookup.test.cpp`
 14. `ultra_honk/rom_ram.test.cpp`
 15. `ultra_honk/range_constraint.test.cpp`
+16. `dsl/acir_format/honk_recursion_constraint.test.cpp`
 
 ## Security Mechanisms
 

barretenberg/cpp/scripts/test_chonk_standalone_vks_havent_changed.sh

@@ -13,7 +13,7 @@ cd ..
 # - Generate a hash for versioning: sha256sum bb-chonk-inputs.tar.gz
 # - Upload the compressed results: aws s3 cp bb-chonk-inputs.tar.gz s3://aztec-ci-artifacts/protocol/bb-chonk-inputs-[hash(0:8)].tar.gz
 # Note: In case of the "Test suite failed to run ... Unexpected token 'with' " error, need to run: docker pull aztecprotocol/build:3.0
-pinned_short_hash="c288d94d"
+pinned_short_hash="04d835ae"
 pinned_chonk_inputs_url="https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/protocol/bb-chonk-inputs-${pinned_short_hash}.tar.gz"
 
 function compress_and_upload {

barretenberg/cpp/src/barretenberg/api/api_chonk.cpp

@@ -123,7 +123,7 @@ bool ChonkAPI::verify([[maybe_unused]] const Flags& flags,
     auto proof_fields = many_from_buffer<fr>(read_file(proof_path));
     auto proof = ChonkProof::from_field_elements(proof_fields);
 
-    auto vk_buffer = read_file(vk_path);
+    auto vk_buffer = read_vk_file(vk_path);
 
     auto response = bbapi::ChonkVerify{ .proof = std::move(proof), .vk = std::move(vk_buffer) }.execute();
     return response.valid;

barretenberg/cpp/src/barretenberg/api/api_ultra_honk.cpp

@@ -101,7 +101,7 @@ bool UltraHonkAPI::verify(const Flags& flags,
     // Read input files
     auto public_inputs = many_from_buffer<uint256_t>(read_file(public_inputs_path));
     auto proof = many_from_buffer<uint256_t>(read_file(proof_path));
-    auto vk_bytes = read_file(vk_path);
+    auto vk_bytes = read_vk_file(vk_path);
 
     // Convert flags to ProofSystemSettings
     bbapi::ProofSystemSettings settings{ .ipa_accumulation = flags.ipa_accumulation,
@@ -209,7 +209,7 @@ void UltraHonkAPI::write_solidity_verifier(const Flags& flags,
 {
     BB_BENCH_NAME("UltraHonkAPI::write_solidity_verifier");
     // Read VK file
-    auto vk_bytes = read_file(vk_path);
+    auto vk_bytes = read_vk_file(vk_path);
 
     // Convert flags to ProofSystemSettings
     bbapi::ProofSystemSettings settings{ .ipa_accumulation = flags.ipa_accumulation,

barretenberg/cpp/src/barretenberg/api/api_ultra_honk.test.cpp

@@ -233,3 +233,35 @@ TEST_F(ApiUltraHonkTest, GatesWithOpcodesSmokeTest)
     // Check that output contains per-opcode information
     EXPECT_TRUE(output.find("gates_per_opcode") != std::string::npos);
 }
+
+TEST_F(ApiUltraHonkTest, VerifyWithMissingVkGivesActionableError)
+{
+    auto [bytecode_path, witness_path] = create_test_circuit_files(test_dir);
+
+    API::Flags flags;
+    flags.oracle_hash_type = "poseidon2";
+    flags.write_vk = true;
+
+    UltraHonkAPI api;
+
+    // Generate proof with vk
+    auto proof_output_dir = test_dir / "proof";
+    std::filesystem::create_directories(proof_output_dir);
+    api.prove(flags, bytecode_path, witness_path, "", proof_output_dir);
+
+    // Try to verify with a non-existent vk path
+    auto nonexistent_vk_path = test_dir / "nonexistent_vk";
+    try {
+        api.verify(flags, proof_output_dir / "public_inputs", proof_output_dir / "proof", nonexistent_vk_path);
+        FAIL() << "Expected an exception to be thrown";
+    } catch (const std::runtime_error& e) {
+        std::string error_msg = e.what();
+        // Check that the error message contains actionable guidance
+        EXPECT_TRUE(error_msg.find("--write_vk") != std::string::npos)
+            << "Error message should mention --write_vk flag. Got: " << error_msg;
+        EXPECT_TRUE(error_msg.find("bb write_vk") != std::string::npos)
+            << "Error message should mention bb write_vk command. Got: " << error_msg;
+        EXPECT_TRUE(error_msg.find("--vk_path") != std::string::npos)
+            << "Error message should mention --vk_path option. Got: " << error_msg;
+    }
+}

barretenberg/cpp/src/barretenberg/api/aztec_process.cpp

@@ -324,7 +324,7 @@ bool process_all_artifacts(const std::string& search_path, bool force)
     auto artifacts = find_contract_artifacts(search_path);
 
     if (artifacts.empty()) {
-        info("No contract artifacts found. Please compile your contracts first with 'nargo compile'.");
+        info("No contract artifacts found in '", search_path, "'.");
         return false;
     }
 

barretenberg/cpp/src/barretenberg/api/file_io.hpp

@@ -5,6 +5,7 @@
 #include <cstdint>
 #include <cstring>
 #include <fcntl.h>
+#include <filesystem>
 #include <fstream>
 #include <ios>
 #include <iostream>
@@ -100,4 +101,23 @@ template <typename Fr> inline std::string field_elements_to_json(const std::vect
     ss << "]";
     return ss.str();
 }
+
+/**
+ * @brief Read a verification key file with an actionable error message if not found.
+ *
+ * @param vk_path Path to the verification key file
+ * @return std::vector<uint8_t> The verification key bytes
+ * @throws std::runtime_error with actionable message if vk file not found
+ */
+inline std::vector<uint8_t> read_vk_file(const std::filesystem::path& vk_path)
+{
+    try {
+        return read_file(vk_path);
+    } catch (const std::runtime_error&) {
+        THROW std::runtime_error("Unable to open file: " + vk_path.string() +
+                                 "\nGenerate a vk during proving by running `bb prove` with an additional `--write_vk` "
+                                 "flag, or run `bb write_vk` to generate a standalone vk."
+                                 "\nIf you already have a vk file, specify its path with `--vk_path <path>`.");
+    }
+}
 } // namespace bb

barretenberg/cpp/src/barretenberg/boomerang_value_detection/graph.cpp

@@ -1241,9 +1241,6 @@ inline void StaticAnalyzer_<FF, CircuitBuilder>::remove_unnecessary_sha256_plook
                                                             BasicTableId::SHA256_WITNESS_SLICE_14_ROTATE_1,
                                                             BasicTableId::SHA256_BASE16,
                                                             BasicTableId::SHA256_BASE16_ROTATE2,
-                                                            BasicTableId::SHA256_BASE16_ROTATE6,
-                                                            BasicTableId::SHA256_BASE16_ROTATE7,
-                                                            BasicTableId::SHA256_BASE16_ROTATE8,
                                                             BasicTableId::SHA256_BASE28,
                                                             BasicTableId::SHA256_BASE28_ROTATE3,
                                                             BasicTableId::SHA256_BASE28_ROTATE6 };

barretenberg/cpp/src/barretenberg/chonk/README.md

@@ -726,7 +726,7 @@ This chain ensures the op queue history is maintained correctly. The Merge proto
 
 ```cpp
 // In OinkVerifier::verify() (called by HypernovaFoldingVerifier for each instance)
-FF vk_hash = vk->hash_with_origin_tagging(domain_separator, *transcript);
+FF vk_hash = vk->hash_with_origin_tagging(*transcript);
 transcript->add_to_hash_buffer(domain_separator + "vk_hash", vk_hash);
 // All subsequent challenges now depend on this hash
 ```