less verbose tests

Author: benesjan

noir-projects/noir-contracts/contracts/app/orderbook_contract/src/test/test.nr

@@ -94,19 +94,15 @@ unconstrained fn full_flow() {
 unconstrained fn create_order_zero_bid_amount() {
     let (mut env, orderbook_address, token0_address, token1_address, _minter) = setup();
 
-    // We create a light account for the maker (as opposed to a contract account) since we are not using authwits here.
-    let maker = env.create_light_account();
-
     let orderbook = Orderbook::at(orderbook_address);
-
-    let bid_amount = 0 as u128;
+    let maker = env.create_light_account();
 
     let _ = env.call_private(
         maker,
         orderbook.create_order(
             token0_address,
             token1_address,
-            bid_amount,
+            0,
             ASK_AMOUNT,
             CREATE_ORDER_AUTHWIT_NONCE,
         ),
@@ -117,20 +113,16 @@ unconstrained fn create_order_zero_bid_amount() {
 unconstrained fn create_order_zero_ask_amount() {
     let (mut env, orderbook_address, token0_address, token1_address, _minter) = setup();
 
-    // We create a light account for the maker (as opposed to a contract account) since we are not using authwits here.
     let maker = env.create_light_account();
-
     let orderbook = Orderbook::at(orderbook_address);
 
-    let ask_amount = 0 as u128;
-
-    let _order_id = env.call_private(
+    let _ = env.call_private(
         maker,
         orderbook.create_order(
             token0_address,
             token1_address,
             BID_AMOUNT,
-            ask_amount,
+            0,
             CREATE_ORDER_AUTHWIT_NONCE,
         ),
     );
@@ -140,14 +132,12 @@ unconstrained fn create_order_zero_ask_amount() {
 unconstrained fn create_order_invalid_bid_token() {
     let (mut env, orderbook_address, _token0_address, token1_address, _minter) = setup();
 
-    // We create a light account for the maker (as opposed to a contract account) since we are not using authwits here.
     let maker = env.create_light_account();
-
     let orderbook = Orderbook::at(orderbook_address);
 
     let invalid_token = AztecAddress::from_field(999);
 
-    let _order_id = env.call_private(
+    let _ = env.call_private(
         maker,
         orderbook.create_order(
             invalid_token,
@@ -163,14 +153,12 @@ unconstrained fn create_order_invalid_bid_token() {
 unconstrained fn create_order_invalid_ask_token() {
     let (mut env, orderbook_address, token0_address, _token1_address, _minter) = setup();
 
-    // We create a light account for the maker (as opposed to a contract account) since we are not using authwits here.
     let maker = env.create_light_account();
-
     let orderbook = Orderbook::at(orderbook_address);
 
     let invalid_token = AztecAddress::from_field(999);
 
-    let _order_id = env.call_private(
+    let _ = env.call_private(
         maker,
         orderbook.create_order(
             token0_address,
@@ -186,12 +174,10 @@ unconstrained fn create_order_invalid_ask_token() {
 unconstrained fn create_order_same_tokens() {
     let (mut env, orderbook_address, token0_address, _token1_address, _minter) = setup();
 
-    // We create a light account for the maker (as opposed to a contract account) since we are not using authwits here.
     let maker = env.create_light_account();
-
     let orderbook = Orderbook::at(orderbook_address);
 
-    let _order_id = env.call_private(
+    let _ = env.call_private(
         maker,
         orderbook.create_order(
             token0_address,