Skip to content

Commit 591ab95

Browse files
authored
fix: move EC2 shutdown timers from bootstrap_ec2 to ci.sh (#20697)
Fixes ci-full variants not allowing for > 60 minute runs.
2 parents fc1a19d + e90c7e7 commit 591ab95

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

ci.sh

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,17 @@ case "$cmd" in
7272
dash)
7373
watch_ci -s next,prs --user --watch
7474
;;
75-
fast|full|full-no-test-cache|full-no-test-cache-makefile|docs|barretenberg|barretenberg-full)
75+
fast|docs|barretenberg|barretenberg-full)
7676
export CI_DASHBOARD="prs"
7777
export JOB_ID="x-$cmd"
7878
bootstrap_ec2 "./bootstrap.sh ci-$cmd"
7979
;;
80+
full|full-no-test-cache|full-no-test-cache-makefile)
81+
export CI_DASHBOARD="prs"
82+
export JOB_ID="x-$cmd"
83+
export AWS_SHUTDOWN_TIME=75
84+
bootstrap_ec2 "./bootstrap.sh ci-$cmd"
85+
;;
8086
barretenberg-debug)
8187
export CI_DASHBOARD="nightly"
8288
export JOB_ID="x-$cmd"
@@ -107,6 +113,8 @@ case "$cmd" in
107113
else
108114
export CI_DASHBOARD="prs"
109115
fi
116+
export AWS_SHUTDOWN_TIME=75
117+
export AWS_SHUTDOWN_TIME_ARM=90
110118
export DENOISE=1
111119
export DENOISE_WIDTH=32
112120
run() {
@@ -128,6 +136,8 @@ case "$cmd" in
128136
else
129137
export CI_DASHBOARD="prs"
130138
fi
139+
export AWS_SHUTDOWN_TIME=75
140+
export AWS_SHUTDOWN_TIME_ARM=90
131141
export DENOISE=1
132142
export DENOISE_WIDTH=32
133143
run() {
@@ -267,6 +277,7 @@ case "$cmd" in
267277
release)
268278
# Spin up ec2 instance and run the release flow.
269279
export CI_DASHBOARD="releases"
280+
export AWS_SHUTDOWN_TIME=75
270281
export DENOISE=1
271282
export DENOISE_WIDTH=32
272283
run() {

ci3/bootstrap_ec2

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,13 @@ export CI=1
1212
# Set to 0 in ci3-external.yml for external contributors who don't have SSH access.
1313
export CI_USE_BUILD_INSTANCE_KEY=${CI_USE_BUILD_INSTANCE_KEY:-1}
1414

15+
export AWS_SHUTDOWN_TIME=${AWS_SHUTDOWN_TIME:-60}
16+
1517
if [ "$arch" == "arm64" ]; then
1618
cores=64
17-
# Allow for 90 minutes as ARM has less cores.
18-
export AWS_SHUTDOWN_TIME=${AWS_SHUTDOWN_TIME:-90}
19+
export AWS_SHUTDOWN_TIME=${AWS_SHUTDOWN_TIME_ARM:-$AWS_SHUTDOWN_TIME}
1920
else
2021
cores=192,128,64
21-
if [ "$CI_FULL" -eq 1 ]; then
22-
# Allow for 75 minutes as ci-full time has crept up.
23-
export AWS_SHUTDOWN_TIME=${AWS_SHUTDOWN_TIME:-75}
24-
fi
2522
fi
2623

2724
# Allow override.

0 commit comments

Comments
 (0)