chore: remove no-longer-used lookup grand prod delta (#16543)

Author: ledwards2225

barretenberg/cpp/scripts/test_civc_standalone_vks_havent_changed.sh

@@ -11,7 +11,7 @@ cd ..
 # - Generate a hash for versioning: sha256sum bb-civc-inputs.tar.gz
 # - Upload the compressed results: aws s3 cp bb-civc-inputs.tar.gz s3://aztec-ci-artifacts/protocol/bb-civc-inputs-[hash(0:8)].tar.gz
 # Note: In case of the "Test suite failed to run ... Unexpected token 'with' " error, need to run: docker pull aztecprotocol/build:3.0
-pinned_short_hash="869efec4"
+pinned_short_hash="d1e22fdb"
 pinned_civc_inputs_url="https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/protocol/bb-civc-inputs-${pinned_short_hash}.tar.gz"
 
 function compress_and_upload {

barretenberg/cpp/src/barretenberg/eccvm/eccvm_trace_checker.cpp

@@ -35,7 +35,6 @@ bool ECCVMTraceChecker::check(Builder& builder,
         .beta = beta,
         .gamma = gamma,
         .public_input_delta = 0,
-        .lookup_grand_product_delta = 0,
         .beta_sqr = beta_sqr,
         .beta_cube = beta_cube,
         .eccvm_set_permutation_delta = eccvm_set_permutation_delta,

barretenberg/cpp/src/barretenberg/flavor/grand_product_library.test.cpp

@@ -55,7 +55,6 @@ template <class FF> class GrandProductTests : public testing::Test {
             .beta = beta,
             .gamma = gamma,
             .public_input_delta = 1,
-            .lookup_grand_product_delta = 1,
         };
 
         compute_grand_product<Flavor, typename bb::UltraPermutationRelation<FF>>(prover_polynomials, params);

barretenberg/cpp/src/barretenberg/relations/relation_parameters.hpp

@@ -21,15 +21,14 @@ template <typename T> struct RelationParameters {
     static constexpr int NUM_BINARY_LIMBS_IN_GOBLIN_TRANSLATOR = 4;
     static constexpr int NUM_NATIVE_LIMBS_IN_GOBLIN_TRANSLATOR = 1;
     static constexpr int NUM_CHALLENGE_POWERS_IN_GOBLIN_TRANSLATOR = 4;
-    static constexpr int NUM_TO_FOLD = 7;
+    static constexpr int NUM_TO_FOLD = 6;
 
-    T eta{ 0 };                        // Lookup + Aux Memory
-    T eta_two{ 0 };                    // Lookup + Aux Memory
-    T eta_three{ 0 };                  // Lookup + Aux Memory
-    T beta{ 0 };                       // Permutation + Lookup
-    T gamma{ 0 };                      // Permutation + Lookup
-    T public_input_delta{ 0 };         // Permutation
-    T lookup_grand_product_delta{ 0 }; // Lookup
+    T eta{ 0 };                // Lookup + Aux Memory
+    T eta_two{ 0 };            // Lookup + Aux Memory
+    T eta_three{ 0 };          // Lookup + Aux Memory
+    T beta{ 0 };               // Permutation + Lookup
+    T gamma{ 0 };              // Permutation + Lookup
+    T public_input_delta{ 0 }; // Permutation
     T beta_sqr{ 0 };
     T beta_cube{ 0 };
     // eccvm_set_permutation_delta is used in the set membership gadget in eccvm/ecc_set_relation.hpp
@@ -48,12 +47,12 @@ template <typename T> struct RelationParameters {
 
     RefArray<T, NUM_TO_FOLD> get_to_fold()
     {
-        return RefArray{ eta, eta_two, eta_three, beta, gamma, public_input_delta, lookup_grand_product_delta };
+        return RefArray{ eta, eta_two, eta_three, beta, gamma, public_input_delta };
     }
 
     RefArray<const T, NUM_TO_FOLD> get_to_fold() const
     {
-        return RefArray{ eta, eta_two, eta_three, beta, gamma, public_input_delta, lookup_grand_product_delta };
+        return RefArray{ eta, eta_two, eta_three, beta, gamma, public_input_delta };
     }
 
     static RelationParameters get_random()
@@ -67,7 +66,6 @@ template <typename T> struct RelationParameters {
         result.beta_cube = result.beta_sqr * result.beta;
         result.gamma = T::random_element();
         result.public_input_delta = T::random_element();
-        result.lookup_grand_product_delta = T::random_element();
         result.eccvm_set_permutation_delta = result.gamma * (result.gamma + result.beta_sqr) *
                                              (result.gamma + result.beta_sqr + result.beta_sqr) *
                                              (result.gamma + result.beta_sqr + result.beta_sqr + result.beta_sqr);
@@ -92,6 +90,6 @@ template <typename T> struct RelationParameters {
         return result;
     }
 
-    MSGPACK_FIELDS(eta, eta_two, eta_three, beta, gamma, public_input_delta, lookup_grand_product_delta);
+    MSGPACK_FIELDS(eta, eta_two, eta_three, beta, gamma, public_input_delta);
 };
 } // namespace bb

barretenberg/cpp/src/barretenberg/stdlib/protogalaxy_verifier/recursive_decider_verification_key.hpp

@@ -93,8 +93,6 @@ template <IsRecursiveFlavor Flavor> class RecursiveDeciderVerificationKey_ {
             relation_parameters.gamma = FF::from_witness(builder, verification_key->relation_parameters.gamma);
             relation_parameters.public_input_delta =
                 FF::from_witness(builder, verification_key->relation_parameters.public_input_delta);
-            relation_parameters.lookup_grand_product_delta =
-                FF::from_witness(builder, verification_key->relation_parameters.lookup_grand_product_delta);
         }
     }
 
@@ -141,8 +139,6 @@ template <IsRecursiveFlavor Flavor> class RecursiveDeciderVerificationKey_ {
         decider_vk.relation_parameters.beta = relation_parameters.beta.get_value();
         decider_vk.relation_parameters.gamma = relation_parameters.gamma.get_value();
         decider_vk.relation_parameters.public_input_delta = relation_parameters.public_input_delta.get_value();
-        decider_vk.relation_parameters.lookup_grand_product_delta =
-            relation_parameters.lookup_grand_product_delta.get_value();
         return decider_vk;
     }
 

barretenberg/cpp/src/barretenberg/vm2/constraining/benchmark/relations_acc.bench.cpp

@@ -82,7 +82,6 @@ bb::RelationParameters<FF> get_params()
         .beta = FF::random_element(),
         .gamma = FF::random_element(),
         .public_input_delta = 0,
-        .lookup_grand_product_delta = 0,
         .beta_sqr = 0,
         .beta_cube = 0,
         .eccvm_set_permutation_delta = 0,

barretenberg/cpp/src/barretenberg/vm2/constraining/check_circuit.cpp

@@ -22,7 +22,6 @@ void run_check_circuit(AvmFlavor::ProverPolynomials& polys, size_t num_rows, boo
         .beta = AvmFlavor::FF::random_element(),
         .gamma = AvmFlavor::FF::random_element(),
         .public_input_delta = 0,
-        .lookup_grand_product_delta = 0,
         .beta_sqr = 0,
         .beta_cube = 0,
         .eccvm_set_permutation_delta = 0,

barretenberg/cpp/src/barretenberg/vm2/constraining/testing/check_relation.cpp

@@ -9,12 +9,11 @@ const RelationParameters<FF>& get_test_params()
         .beta = FF::random_element(),
         .gamma = FF::random_element(),
         .public_input_delta = 0,
-        .lookup_grand_product_delta = 0,
         .beta_sqr = 0,
         .beta_cube = 0,
         .eccvm_set_permutation_delta = 0,
     };
     return params;
 }
 
-} // namespace bb::avm2::constraining::detail
+} // namespace bb::avm2::constraining::detail