chore: track attestation failures for all validators (#18098)

This PR tracks attestation metrics for all validators

Author: alexghr

yarn-project/telemetry-client/src/attributes.ts

@@ -124,3 +124,6 @@ export const TX_COLLECTION_METHOD = 'aztec.tx_collection.method';
 
 /** Scope of L1 transaction (sequencer, prover, or other) */
 export const L1_TX_SCOPE = 'aztec.l1_tx.scope';
+
+/** Generic error type attribute */
+export const IS_COMMITTEE_MEMBER = 'aztec.is_committee_member';

yarn-project/validator-client/src/metrics.ts

@@ -85,15 +85,17 @@ export class ValidatorMetrics {
     this.successfulAttestationsCount.add(num);
   }
 
-  public incFailedAttestationsBadProposal(num: number, reason: string) {
+  public incFailedAttestationsBadProposal(num: number, reason: string, inCommittee: boolean) {
     this.failedAttestationsBadProposalCount.add(num, {
       [Attributes.ERROR_TYPE]: reason,
+      [Attributes.IS_COMMITTEE_MEMBER]: inCommittee,
     });
   }
 
-  public incFailedAttestationsNodeIssue(num: number, reason: string) {
+  public incFailedAttestationsNodeIssue(num: number, reason: string, inCommittee: boolean) {
     this.failedAttestationsNodeIssueCount.add(num, {
       [Attributes.ERROR_TYPE]: reason,
+      [Attributes.IS_COMMITTEE_MEMBER]: inCommittee,
     });
   }
 }

yarn-project/validator-client/src/validator.ts

@@ -289,23 +289,21 @@ export class ValidatorClient extends (EventEmitter as new () => WatcherEmitter)
     if (!validationResult.isValid) {
       this.log.warn(`Proposal validation failed: ${validationResult.reason}`, proposalInfo);
 
-      // Only track attestation failure metrics if we're actually in the committee
-      if (partOfCommittee) {
-        const reason = validationResult.reason || 'unknown';
-        // Classify failure reason: bad proposal vs node issue
-        const badProposalReasons: BlockProposalValidationFailureReason[] = [
-          'invalid_proposal',
-          'state_mismatch',
-          'failed_txs',
-          'in_hash_mismatch',
-          'parent_block_wrong_slot',
-        ];
-
-        if (badProposalReasons.includes(reason as BlockProposalValidationFailureReason)) {
-          this.metrics.incFailedAttestationsBadProposal(1, reason);
-        } else {
-          this.metrics.incFailedAttestationsNodeIssue(1, reason);
-        }
+      const reason = validationResult.reason || 'unknown';
+      // Classify failure reason: bad proposal vs node issue
+      const badProposalReasons: BlockProposalValidationFailureReason[] = [
+        'invalid_proposal',
+        'state_mismatch',
+        'failed_txs',
+        'in_hash_mismatch',
+        'parent_block_wrong_slot',
+      ];
+
+      if (badProposalReasons.includes(reason as BlockProposalValidationFailureReason)) {
+        this.metrics.incFailedAttestationsBadProposal(1, reason, partOfCommittee);
+      } else {
+        // Node issues so we can't attest
+        this.metrics.incFailedAttestationsNodeIssue(1, reason, partOfCommittee);
       }
 
       // Slash invalid block proposals (can happen even when not in committee)