chore: the great deletion (#17926)

Author: ledwards2225

barretenberg/cpp/bootstrap.sh

@@ -284,8 +284,8 @@ function test_cmds {
     # Mostly arbitrary set that touches lots of the code.
     declare -A asan_tests=(
       ["commitment_schemes_recursion_tests"]="IPARecursiveTests.AccumulationAndFullRecursiveVerifier"
-      ["client_ivc_tests"]="ClientIVCTests.BasicStructured"
-      ["ultra_honk_tests"]="MegaHonkTests/0.BasicStructured"
+      ["client_ivc_tests"]="ClientIVCTests.Basic"
+      ["ultra_honk_tests"]="MegaHonkTests/0.Basic"
       ["dsl_tests"]="AcirHonkRecursionConstraint/1.TestBasicDoubleHonkRecursionConstraints"
     )
     # If in amd64 CI, iterate asan_tests, creating a gtest invocation for each.

barretenberg/cpp/scripts/audit/audit_summary.json

@@ -120,17 +120,6 @@
       "not started": 24
     }
   },
-  "protogalaxy": {
-    "internal": {
-      "not started": 9
-    },
-    "external_1": {
-      "not started": 9
-    },
-    "external_2": {
-      "not started": 9
-    }
-  },
   "relations": {
     "internal": {
       "not started": 53

barretenberg/cpp/scripts/benchmark_protogalaxy.sh

@@ -40,7 +40,6 @@
            "nodejs_module": 0,
            "numeric": 1,
            "polynomials": 1,
-           "protogalaxy": 1,
            "relations": 1,
            "serialize": 1,
            "smt_verification": 0,
@@ -96,7 +95,6 @@ def count_weighted_lines():
 weights["client_ivc"] = 1.5
 weights["eccvm"] = 2
 weights["goblin"] = 1.5
-weights["protogalaxy"] = 1.5
 weights["relations"] = 2
 weights["stdlib"] = 1  # partially audited so not reweighting for complexity
 weights["stdlib_circuit_builders"]

barretenberg/cpp/scripts/line_count.py

@@ -102,7 +102,6 @@ add_subdirectory(barretenberg/multilinear_batching)
 add_subdirectory(barretenberg/numeric)
 add_subdirectory(barretenberg/op_queue)
 add_subdirectory(barretenberg/polynomials)
-add_subdirectory(barretenberg/protogalaxy)
 add_subdirectory(barretenberg/relations)
 add_subdirectory(barretenberg/serialize)
 add_subdirectory(barretenberg/solidity_helpers)
@@ -167,7 +166,6 @@ set(BARRETENBERG_TARGET_OBJECTS
     $<TARGET_OBJECTS:numeric_objects>
     $<TARGET_OBJECTS:op_queue_objects>
     $<TARGET_OBJECTS:polynomials_objects>
-    $<TARGET_OBJECTS:protogalaxy_objects>
     $<TARGET_OBJECTS:relations_objects>
     $<TARGET_OBJECTS:srs_objects>
     $<TARGET_OBJECTS:stdlib_aes128_objects>
@@ -184,7 +182,6 @@ set(BARRETENBERG_TARGET_OBJECTS
     $<TARGET_OBJECTS:stdlib_pedersen_hash_objects>
     $<TARGET_OBJECTS:stdlib_poseidon2_objects>
     $<TARGET_OBJECTS:stdlib_primitives_objects>
-    $<TARGET_OBJECTS:stdlib_protogalaxy_verifier_objects>
     $<TARGET_OBJECTS:stdlib_schnorr_objects>
     $<TARGET_OBJECTS:stdlib_sha256_objects>
     $<TARGET_OBJECTS:stdlib_translator_vm_verifier_objects>

barretenberg/cpp/src/CMakeLists.txt

@@ -27,7 +27,6 @@ namespace { // anonymous namespace
  *
  * @param bytecode_path
  * @param witness_path
- * @param use_structured_trace Whether to utilize structured trace when computing VK for circuit
  */
 void write_standalone_vk(std::vector<uint8_t> bytecode, const std::filesystem::path& output_path)
 {

barretenberg/cpp/src/barretenberg/api/api_client_ivc.cpp

@@ -7,7 +7,6 @@
 #include "barretenberg/dsl/acir_format/acir_to_constraint_buf.hpp"
 #include "barretenberg/dsl/acir_format/pg_recursion_constraint.hpp"
 #include "barretenberg/dsl/acir_format/serde/witness_stack.hpp"
-#include "barretenberg/honk/execution_trace/execution_trace_usage_tracker.hpp"
 #include "barretenberg/serialize/msgpack_check_eq.hpp"
 #include "barretenberg/stdlib_circuit_builders/mega_circuit_builder.hpp"
 
@@ -259,7 +258,7 @@ ClientIvcStats::Response ClientIvcStats::execute([[maybe_unused]] BBApiRequest&
          ", circuit_size: ",
          response.circuit_size);
 
-    // Print structured execution trace details
+    // Print execution trace details
     builder.blocks.summarize();
 
     return response;

barretenberg/cpp/src/barretenberg/bbapi/bbapi_client_ivc.cpp

@@ -5,8 +5,6 @@ add_subdirectory(ipa_bench)
 add_subdirectory(ipc_bench)
 add_subdirectory(client_ivc_bench)
 add_subdirectory(pippenger_bench)
-add_subdirectory(protogalaxy_bench)
-add_subdirectory(protogalaxy_rounds_bench)
 add_subdirectory(relations_bench)
 add_subdirectory(poseidon2_bench)
 add_subdirectory(merkle_tree_bench)

barretenberg/cpp/src/barretenberg/benchmark/CMakeLists.txt

@@ -14,7 +14,7 @@ using namespace bb;
 namespace {
 
 /**
- * @brief Benchmark suite for the aztec client PG-Goblin IVC scheme
+ * @brief Benchmark suite for the aztec client IVC scheme
  */
 class ClientIVCBench : public benchmark::Fixture {
   public:
@@ -28,7 +28,7 @@ class ClientIVCBench : public benchmark::Fixture {
 };
 
 /**
- * @brief Benchmark only the verification work for the PG-Goblin IVC protocol
+ * @brief Benchmark only the verification work for the IVC protocol
  */
 BENCHMARK_DEFINE_F(ClientIVCBench, VerificationOnly)(benchmark::State& state)
 {
@@ -42,7 +42,7 @@ BENCHMARK_DEFINE_F(ClientIVCBench, VerificationOnly)(benchmark::State& state)
 }
 
 /**
- * @brief Benchmark the prover work for the full PG-Goblin IVC protocol
+ * @brief Benchmark the prover work for the full IVC protocol
  */
 BENCHMARK_DEFINE_F(ClientIVCBench, Full)(benchmark::State& state)
 {

barretenberg/cpp/src/barretenberg/benchmark/client_ivc_bench/client_ivc.bench.cpp

@@ -30,7 +30,7 @@ using G1 = Curve::AffineElement;
 using Element = Curve::Element;
 namespace {
 /**
- * @brief Benchmark suite for the aztec client PG-Goblin IVC scheme
+ * @brief Benchmark suite for Pippenger scalar multiplication
  */
 class PippengerBench : public benchmark::Fixture {
   public:
@@ -55,7 +55,7 @@ class PippengerBench : public benchmark::Fixture {
 };
 
 /**
- * @brief Benchmark the prover work for the full PG-Goblin IVC protocol
+ * @brief Benchmark the prover work for Pippenger scalar multiplication
  */
 BENCHMARK_DEFINE_F(PippengerBench, Full)(benchmark::State& state)
 {