cleaned up after couple of sergei's comments

Author: notnotraju

barretenberg/cpp/src/barretenberg/eccvm/README.md

@@ -451,7 +451,7 @@ This table is the most algorithmically involved.
 struct alignas(64) MSMRow {
         uint32_t pc = 0; // decreasing point-counter, over all half-length (128 bit) scalar muls used to compute
                          // the required MSMs. however, this value is _constant_ on a given MSM and more precisely
-                         //  refers to the of _completed_ half-length scalar muls completed up until we have started
+                         //  refers to the number of half-length scalar muls completed up until we have started
                          // the current MSM.
         uint32_t msm_size = 0;  // the number of points in the current MSM. (this is _constant_ on MSM blocks.)
         uint32_t msm_count = 0; // number of multiplications processed so far (not including this row) in current MSM

barretenberg/cpp/src/barretenberg/eccvm/msm_builder.hpp

@@ -27,12 +27,12 @@ class ECCVMMSMMBuilder {
     static constexpr size_t NUM_WNAF_DIGITS_PER_SCALAR = bb::eccvm::NUM_WNAF_DIGITS_PER_SCALAR;
 
     struct alignas(64) MSMRow {
-        uint32_t pc = 0; // decreasing point-counter, over all half-length (128 bit) scalar muls used to compute
-                         // the required MSMs. however, this value is _constant_ on a given MSM and more precisely
-                         //  refers to the of _completed_ half-length scalar muls completed up until we have started
-                         // the current MSM.
-        uint32_t msm_size = 0;  // the number of points in (a.k.a. the length of) the MSM in whose computation
-                                // this VM row participates
+        uint32_t pc = 0;       // decreasing point-counter, over all half-length (128 bit) scalar muls used to compute
+                               // the required MSMs. however, this value is _constant_ on a given MSM and more precisely
+                               //  refers to the number of half-length scalar muls completed up until we have started
+                               // the current MSM.
+        uint32_t msm_size = 0; // the number of points in (a.k.a. the length of) the MSM in whose computation
+                               // this VM row participates
         uint32_t msm_count = 0; // number of multiplications processed so far (not including this row) in current MSM
                                 // round (a.k.a. wNAF digit slot). this specifically refers to the number of wNAF-digit
                                 // * point scalar products we have looked up and accumulated.
@@ -79,7 +79,7 @@ class ECCVMMSMMBuilder {
      * @brief Computes the row values for the Straus MSM columns of the ECCVM.
      *
      * For a detailed description of the Straus algorithm and its relation to the ECCVM, please see
-     * https://hackmd.io/@aztec-network/rJ5xhuCsn or, alternatively, the ECCVM readme.
+     * https://hackmd.io/@aztec-network/rJ5xhuCsn or, alternatively, the [ECCVM readme](README.md).
      *
      * @param msms A vector of vectors of `ScalarMul`s, a.k.a. a vector of `MSM`s.
      * @param point_table_read_counts Table of read counts to be populated.

barretenberg/cpp/src/barretenberg/relations/ecc_vm/ecc_msm_relation_impl.hpp

@@ -16,7 +16,7 @@ namespace bb {
  *
  * @details
  * The Straus algorithm for a size-k MSM takes scalars/points (a_i, [P_i]) for i = 0 to k-1.
- * The specific algorithm we use is may be found in the README in the `eccvm` directory. We briefly reprise the
+ * The specific algorithm we use may be found [here](../../eccvm/README.md). We briefly reprise the
  * algorithm nonetheless.
  *
  * PHASE 1: Precomputation (performed in ecc_wnaf_relation.hpp, ecc_point_table_relation.hpp)
@@ -94,7 +94,7 @@ void ECCVMMSMRelationImpl<FF>::accumulate(ContainerOverSubrelations& accumulator
     const auto& q_double = View(in.msm_double); // is 1 iff we are at an DOUBLE row in Straus algorithm
     const auto& q_double_shift = View(in.msm_double_shift);
     const auto& msm_size = View(in.msm_size_of_msm);
-    const auto& pc = View(in.msm_pc);
+    const auto& pc = View(in.msm_pc); // pc stands for `point-counter`.
     const auto& pc_shift = View(in.msm_pc_shift);
     const auto& count = View(in.msm_count);
     const auto& count_shift = View(in.msm_count_shift);