chore: refactor private kernel init and inner (#19025)

Refactor some code and add more comments.

Author: LeilaWang

noir-projects/noir-protocol-circuits/Nargo.template.toml

@@ -4,7 +4,6 @@ members = [
     "crates/types",
     "crates/blob",
     "crates/parity-base",
-    "crates/parity-lib",
     "crates/parity-root",
     "crates/private-kernel-lib",
     "crates/private-kernel-init",

noir-projects/noir-protocol-circuits/bootstrap.sh

@@ -157,7 +157,6 @@ function build {
   echo_stderr "Checking libraries for warnings..."
   parallel -v --line-buffer --tag $NARGO --program-dir {} check ::: \
     ./crates/blob \
-    ./crates/parity-lib \
     ./crates/private-kernel-lib \
     ./crates/rollup-lib \
     ./crates/types \

noir-projects/noir-protocol-circuits/crates/chonk-verifier-public/src/main.nr

@@ -1,6 +1,8 @@
-use dep::rollup_lib::tx_base::{PublicChonkVerifierPrivateInputs, PublicChonkVerifierPublicInputs};
+use dep::rollup_lib::tx_base::{
+    public_chonk_verifier, PublicChonkVerifierPrivateInputs, PublicChonkVerifierPublicInputs,
+};
 
 // CHONK_VERIFIER: Recursively verifies Chonk (Client Honk) proofs in circuits
 fn main(inputs: PublicChonkVerifierPrivateInputs) -> pub PublicChonkVerifierPublicInputs {
-    inputs.execute()
+    public_chonk_verifier::execute(inputs)
 }

noir-projects/noir-protocol-circuits/crates/hiding-kernel-to-public/Nargo.toml

@@ -4,4 +4,5 @@ type = "bin"
 authors = [""]
 
 [dependencies]
+private_kernel_lib = { path = "../private-kernel-lib" }
 types = { path = "../types" }

noir-projects/noir-protocol-circuits/crates/hiding-kernel-to-public/src/main.nr

@@ -1,46 +1,16 @@
-use types::{
+use dep::private_kernel_lib::{hiding_kernel_to_public, HidingKernelToPublicPrivateInputs};
+use dep::types::{
     abis::kernel_circuit_public_inputs::PrivateToPublicKernelCircuitPublicInputs,
-    constants::{MEGA_VK_LENGTH_IN_FIELDS, PRIVATE_KERNEL_TAIL_TO_PUBLIC_INDEX, PROOF_TYPE_HN_FINAL},
-    proof::vk_data::VkData,
+    constants::MEGA_VK_LENGTH_IN_FIELDS, proof::vk_data::VkData,
 };
 
-pub struct HidingKernelToPublicPrivateInputs {
-    previous_kernel_public_inputs: PrivateToPublicKernelCircuitPublicInputs,
-    previous_kernel_vk_data: VkData<MEGA_VK_LENGTH_IN_FIELDS>,
-}
-
-impl HidingKernelToPublicPrivateInputs {
-    pub fn execute(self) {
-        // Verify previous kernel, which contains a folding proof and a decider proof.
-        // The associated public inputs and proofs are linked through the verification queue in the backend.
-        // The proof type `PROOF_TYPE_HN_FINAL` designates the final proof in the client IVC sequence.
-        if !std::runtime::is_unconstrained() {
-            std::verify_proof_with_type(
-                self.previous_kernel_vk_data.vk.key,
-                [],
-                [],
-                self.previous_kernel_vk_data.vk.hash,
-                PROOF_TYPE_HN_FINAL,
-            );
-        }
-
-        // Validate that the vk index corresponds to the `private_kernel_tail_to_public` circuit.
-        assert_eq(self.previous_kernel_vk_data.leaf_index, PRIVATE_KERNEL_TAIL_TO_PUBLIC_INDEX);
-
-        // Validates that the vk hash exists in the vk tree at the expected index.
-        // Note: The hash of the verification key is checked in `verify_proof_with_type` against the given vk hash.
-        self.previous_kernel_vk_data.validate_in_vk_tree(
-            self.previous_kernel_public_inputs.constants.vk_tree_root,
-        );
-    }
-}
-
 fn main(
     previous_kernel_public_inputs: call_data(0) PrivateToPublicKernelCircuitPublicInputs,
     previous_kernel_vk_data: VkData<MEGA_VK_LENGTH_IN_FIELDS>,
 ) -> pub PrivateToPublicKernelCircuitPublicInputs {
-    HidingKernelToPublicPrivateInputs { previous_kernel_public_inputs, previous_kernel_vk_data }
-        .execute();
-
-    previous_kernel_public_inputs
+    let inputs = HidingKernelToPublicPrivateInputs {
+        previous_kernel_public_inputs,
+        previous_kernel_vk_data,
+    };
+    hiding_kernel_to_public::execute(inputs)
 }

noir-projects/noir-protocol-circuits/crates/hiding-kernel-to-rollup/Nargo.toml

@@ -4,4 +4,5 @@ type = "bin"
 authors = [""]
 
 [dependencies]
+private_kernel_lib = { path = "../private-kernel-lib" }
 types = { path = "../types" }

noir-projects/noir-protocol-circuits/crates/hiding-kernel-to-rollup/src/main.nr

@@ -1,46 +1,16 @@
-use types::{
+use dep::private_kernel_lib::{hiding_kernel_to_rollup, HidingKernelToRollupPrivateInputs};
+use dep::types::{
     abis::kernel_circuit_public_inputs::PrivateToRollupKernelCircuitPublicInputs,
-    constants::{MEGA_VK_LENGTH_IN_FIELDS, PRIVATE_KERNEL_TAIL_INDEX, PROOF_TYPE_HN_FINAL},
-    proof::vk_data::VkData,
+    constants::MEGA_VK_LENGTH_IN_FIELDS, proof::vk_data::VkData,
 };
 
-pub struct HidingKernelToRollupPrivateInputs {
-    previous_kernel_public_inputs: PrivateToRollupKernelCircuitPublicInputs,
-    previous_kernel_vk_data: VkData<MEGA_VK_LENGTH_IN_FIELDS>,
-}
-
-impl HidingKernelToRollupPrivateInputs {
-    pub fn execute(self) {
-        // Verify previous kernel, which contains a folding proof and a decider proof.
-        // The associated public inputs and proofs are linked through the verification queue in the backend.
-        // The proof type `PROOF_TYPE_HN_FINAL` designates the final proof in the chonk sequence.
-        if !std::runtime::is_unconstrained() {
-            std::verify_proof_with_type(
-                self.previous_kernel_vk_data.vk.key,
-                [],
-                [],
-                self.previous_kernel_vk_data.vk.hash,
-                PROOF_TYPE_HN_FINAL,
-            );
-        }
-
-        // Validate that the vk index corresponds to the `private_kernel_tail` circuit.
-        assert_eq(self.previous_kernel_vk_data.leaf_index, PRIVATE_KERNEL_TAIL_INDEX);
-
-        // Validates that the vk hash exists in the vk tree at the expected index.
-        // Note: The hash of the verification key is checked in `verify_proof_with_type` against the given vk hash.
-        self.previous_kernel_vk_data.validate_in_vk_tree(
-            self.previous_kernel_public_inputs.constants.vk_tree_root,
-        );
-    }
-}
-
 fn main(
     previous_kernel_public_inputs: call_data(0) PrivateToRollupKernelCircuitPublicInputs,
     previous_kernel_vk_data: VkData<MEGA_VK_LENGTH_IN_FIELDS>,
 ) -> pub PrivateToRollupKernelCircuitPublicInputs {
-    HidingKernelToRollupPrivateInputs { previous_kernel_public_inputs, previous_kernel_vk_data }
-        .execute();
-
-    previous_kernel_public_inputs
+    let inputs = HidingKernelToRollupPrivateInputs {
+        previous_kernel_public_inputs,
+        previous_kernel_vk_data,
+    };
+    hiding_kernel_to_rollup::execute(inputs)
 }

noir-projects/noir-protocol-circuits/crates/parity-base/Nargo.toml

@@ -5,5 +5,5 @@ authors = [""]
 compiler_version = ">=0.18.0"
 
 [dependencies]
-parity_lib = { path = "../parity-lib" }
+rollup_lib = { path = "../rollup-lib" }
 types = { path = "../types" }

noir-projects/noir-protocol-circuits/crates/parity-base/src/main.nr

@@ -1,5 +1,5 @@
-use dep::parity_lib::{ParityBasePrivateInputs, ParityPublicInputs};
+use dep::rollup_lib::parity::{parity_base, ParityBasePrivateInputs, ParityPublicInputs};
 
 fn main(inputs: ParityBasePrivateInputs) -> pub ParityPublicInputs {
-    inputs.execute()
+    parity_base::execute(inputs)
 }