fix: correctly handle prover reverted txs (#16654)

Author: alexghr

yarn-project/prover-node/src/prover-node-publisher.test.ts

@@ -1,12 +1,14 @@
 import { BatchedBlob } from '@aztec/blob-lib';
 import type { L1TxUtils, RollupContract } from '@aztec/ethereum';
 import { SecretValue } from '@aztec/foundation/config';
+import { randomBytes } from '@aztec/foundation/crypto';
 import { EthAddress } from '@aztec/foundation/eth-address';
 import { Fr } from '@aztec/foundation/fields';
 import type { PublisherConfig, TxSenderConfig } from '@aztec/sequencer-client';
 import { Proof } from '@aztec/stdlib/proofs';
 import { RootRollupPublicInputs } from '@aztec/stdlib/rollup';
 
+import { jest } from '@jest/globals';
 import { type MockProxy, mock } from 'jest-mock-extended';
 
 import { ProverNodePublisher } from './prover-node-publisher.js';
@@ -193,4 +195,87 @@ describe('prover-node-publisher', () => {
       }
     },
   );
+
+  it('handles reverted txs correctly', async () => {
+    const blocks = [RootRollupPublicInputs.random(), RootRollupPublicInputs.random()];
+
+    // Return the tips specified by the test
+    rollup.getTips.mockResolvedValue({
+      pendingBlockNumber: 2n,
+      provenBlockNumber: 1n,
+    });
+
+    // Return the requested block
+    rollup.getBlock.mockImplementation((i: bigint) =>
+      Promise.resolve({
+        archive: blocks[Number(i) - 1].endArchiveRoot.toString(),
+        attestationsHash: '0x', // unused,
+        payloadDigest: '0x', // unused,
+        headerHash: '0x', // unused,
+        blobCommitmentsHash: '0x', // unused,
+        slotNumber: 0n, // unused,
+        feeHeader: {
+          excessMana: 0n, // unused
+          manaUsed: 0n, // unused
+          feeAssetPriceNumerator: 0n, // unused
+          congestionCost: 0n, // unused
+          proverCost: 0n, // unused
+        },
+      }),
+    );
+
+    // We have built a rollup proof of the range fromBlock - toBlock
+    // so we need to set our archives and hashes accordingly
+    const ourPublicInputs = RootRollupPublicInputs.random();
+    ourPublicInputs.previousArchiveRoot = blocks[0].endArchiveRoot ?? Fr.ZERO;
+    ourPublicInputs.endArchiveRoot = blocks[1].endArchiveRoot ?? Fr.ZERO;
+
+    const ourBatchedBlob = new BatchedBlob(
+      ourPublicInputs.blobPublicInputs.blobCommitmentsHash,
+      ourPublicInputs.blobPublicInputs.z,
+      ourPublicInputs.blobPublicInputs.y,
+      ourPublicInputs.blobPublicInputs.c,
+      ourPublicInputs.blobPublicInputs.c.negate(), // Fill with dummy value
+    );
+
+    // Return our public inputs
+    const totalFields = ourPublicInputs.toFields();
+    rollup.getEpochProofPublicInputs.mockResolvedValue(totalFields.map(x => x.toString()));
+
+    jest.spyOn(l1Utils, 'getSenderBalance').mockResolvedValue(42n);
+    jest.spyOn(l1Utils, 'getSenderAddress').mockReturnValue(EthAddress.random());
+
+    jest.spyOn(l1Utils, 'sendAndMonitorTransaction').mockResolvedValue({
+      gasPrice: {} as any,
+      receipt: {
+        status: 'reverted',
+        effectiveGasPrice: 1n,
+        gasUsed: 1n,
+        transactionHash: `0x${randomBytes(32).toString('hex')}`,
+        cumulativeGasUsed: 1n,
+        blockNumber: 42n,
+        blockHash: `0x${randomBytes(32).toString('hex')}`,
+        from: EthAddress.random().toString(),
+      } as any,
+    });
+
+    jest.spyOn(l1Utils, 'getTransactionStats').mockResolvedValue({
+      calldataGas: 1,
+      calldataSize: 1,
+      sender: EthAddress.random().toString(),
+      transactionHash: `0x${randomBytes(32).toString('hex')}`,
+    });
+
+    const result = await publisher.submitEpochProof({
+      epochNumber: 2,
+      fromBlock: 2,
+      toBlock: 2,
+      publicInputs: ourPublicInputs,
+      proof: Proof.empty(),
+      batchedBlobInputs: ourBatchedBlob,
+      attestations: [],
+    });
+
+    expect(result).toBe(false);
+  });
 });

yarn-project/prover-node/src/prover-node-publisher.ts

@@ -123,7 +123,7 @@ export class ProverNodePublisher {
       }
 
       // Tx was mined successfully
-      if (txReceipt.status) {
+      if (txReceipt.status === 'success') {
         const tx = await this.l1TxUtils.getTransactionStats(txReceipt.transactionHash);
         const stats: L1PublishProofStats = {
           gasPrice: txReceipt.effectiveGasPrice,