refactored getLowestPriorityEvictable

Author: mralj

yarn-project/p2p/src/mem_pools/tx_pool/aztec_kv_tx_pool.ts

@@ -663,18 +663,22 @@ export class AztecKVTxPool
    * Iterates the priority index in ascending order and skips non-evictable txs.
    */
   public async getLowestPriorityEvictable(limit: number): Promise<TxHash[]> {
-    const result: TxHash[] = [];
+    const txsToEvict: TxHash[] = [];
     if (limit <= 0) {
-      return result;
+      return txsToEvict;
     }
+
     for await (const txHashStr of this.#pendingTxPriorityToHash.valuesAsync()) {
-      if (!this.#nonEvictableTxs.has(txHashStr)) {
-        result.push(TxHash.fromString(txHashStr));
-        if (result.length >= limit) {
-          break;
-        }
+      if (this.#nonEvictableTxs.has(txHashStr)) {
+        continue;
+      }
+
+      txsToEvict.push(TxHash.fromString(txHashStr));
+      if (txsToEvict.length >= limit) {
+        break;
       }
     }
-    return result;
+
+    return txsToEvict;
   }
 }