chore: Update poseidon version & remove unnecessary comptime globals (#20702)

Changes necessary for a breaking Noir change:
noir-lang/noir#11627 requiring comptime globals
to only be evaluated in comptime contexts.
- Updates the `poseidon` version used to `0.2.4`. The previous version
used a `comptime global` in runtime code which did not need to be
comptime, so it was changed.
- bigcurve and bignum versions also had to be updated since they also
require poseidon internally
- Makes the various VK tree constants no longer `comptime` - it was
unnecessary and lead to errors with the above change.
- There is a full copy of poseidon in
`noir-projects/noir-protocol-circuits/crates/types/src/poseidon2.nr`
which has a comment suggesting it should be removed now that there is a
standalone poseidon. I did not remove it here but it should be
considered.

Author: AztecBot

noir-projects/aztec-nr/aztec/Nargo.toml

@@ -7,4 +7,4 @@ type = "lib"
 [dependencies]
 protocol_types = { path = "../../noir-protocol-circuits/crates/types" }
 sha256 = { tag = "v0.3.0", git = "https://github.com/noir-lang/sha256" }
-poseidon = { tag = "v0.2.3", git = "https://github.com/noir-lang/poseidon" }
+poseidon = { tag = "v0.2.6", git = "https://github.com/noir-lang/poseidon" }

noir-projects/noir-contracts/contracts/test/avm_gadgets_test_contract/Nargo.toml

@@ -8,4 +8,4 @@ type = "contract"
 aztec = { path = "../../../../aztec-nr/aztec" }
 keccak256 = { tag = "v0.1.3", git = "https://github.com/noir-lang/keccak256" }
 sha256 = { tag = "v0.3.0", git = "https://github.com/noir-lang/sha256" }
-poseidon = { tag= "v0.2.3", git = "https://github.com/noir-lang/poseidon" }
+poseidon = { tag= "v0.2.6", git = "https://github.com/noir-lang/poseidon" }

noir-projects/noir-contracts/contracts/test/avm_test_contract/Nargo.toml

@@ -9,7 +9,7 @@ aztec = { path = "../../../../aztec-nr/aztec" }
 compressed_string = { path = "../../../../aztec-nr/compressed-string" }
 sha256 = { tag = "v0.3.0", git = "https://github.com/noir-lang/sha256" }
 keccak256 = { tag = "v0.1.3", git = "https://github.com/noir-lang/keccak256" }
-poseidon = { tag= "v0.2.3", git = "https://github.com/noir-lang/poseidon" }
+poseidon = { tag= "v0.2.6", git = "https://github.com/noir-lang/poseidon" }
 fee_juice = { path = "../../protocol_interface/fee_juice_interface" }
 auth_contract = { path = "../../protocol/auth_registry_contract" }
 instance_contract = { path = "../../protocol_interface/contract_instance_registry_interface" }

noir-projects/noir-protocol-circuits/crates/blob/Nargo.toml

@@ -5,6 +5,6 @@ authors = [""]
 compiler_version = ">=0.30.0"
 
 [dependencies]
-bignum = { git = "https://github.com/noir-lang/noir-bignum", tag = "v0.9.0" }
-bigcurve = { git = "https://github.com/noir-lang/noir_bigcurve", tag = "v0.13.0" }
+bignum = { git = "https://github.com/noir-lang/noir-bignum", tag = "v0.9.2" }
+bigcurve = { git = "https://github.com/noir-lang/noir_bigcurve", tag = "v0.13.2" }
 types = { path = "../types" }

noir-projects/noir-protocol-circuits/crates/rollup-lib/Nargo.toml

@@ -5,7 +5,7 @@ authors = [""]
 compiler_version = ">=0.18.0"
 
 [dependencies]
-bignum = { git = "https://github.com/noir-lang/noir-bignum", tag = "v0.9.0" }
-bigcurve = { git = "https://github.com/noir-lang/noir_bigcurve", tag = "v0.13.0" }
+bignum = { git = "https://github.com/noir-lang/noir-bignum", tag = "v0.9.2" }
+bigcurve = { git = "https://github.com/noir-lang/noir_bigcurve", tag = "v0.13.2" }
 types = { path = "../types" }
 blob = { path = "../blob" }

noir-projects/noir-protocol-circuits/crates/types/Nargo.toml

@@ -6,5 +6,5 @@ compiler_version = ">=0.18.0"
 
 [dependencies]
 sha256 = { tag = "v0.3.0", git = "https://github.com/noir-lang/sha256" }
-poseidon = { tag = "v0.2.3", git = "https://github.com/noir-lang/poseidon" }
+poseidon = { tag = "v0.2.6", git = "https://github.com/noir-lang/poseidon" }
 serde = { path = "../serde" }

noir-projects/noir-protocol-circuits/crates/types/src/constants.nr

@@ -103,30 +103,30 @@ pub global MAX_KEY_VALIDATION_REQUESTS_PER_CALL: u32 = MAX_PRIVATE_LOGS_PER_CALL
 pub global NUMBER_OF_L1_L2_MESSAGES_PER_ROLLUP: u32 = 1 << L1_TO_L2_MSG_SUBTREE_HEIGHT;
 
 // VK TREE CONSTANTS
-pub comptime global PRIVATE_KERNEL_INIT_VK_INDEX: u32 = 0;
-pub comptime global PRIVATE_KERNEL_INNER_VK_INDEX: u32 = 1;
-pub comptime global PRIVATE_KERNEL_TAIL_VK_INDEX: u32 = 2;
-pub comptime global PRIVATE_KERNEL_TAIL_TO_PUBLIC_VK_INDEX: u32 = 3;
-pub comptime global HIDING_KERNEL_TO_ROLLUP_VK_INDEX: u32 = 4;
-pub comptime global HIDING_KERNEL_TO_PUBLIC_VK_INDEX: u32 = 5;
-pub comptime global PUBLIC_CHONK_VERIFIER_VK_INDEX: u32 = 6;
-pub comptime global PRIVATE_TX_BASE_ROLLUP_VK_INDEX: u32 = 7;
-pub comptime global PUBLIC_TX_BASE_ROLLUP_VK_INDEX: u32 = 8;
-pub comptime global TX_MERGE_ROLLUP_VK_INDEX: u32 = 9;
-pub comptime global BLOCK_ROOT_FIRST_ROLLUP_VK_INDEX: u32 = 10;
-pub comptime global BLOCK_ROOT_SINGLE_TX_FIRST_ROLLUP_VK_INDEX: u32 = 11;
-pub comptime global BLOCK_ROOT_EMPTY_TX_FIRST_ROLLUP_VK_INDEX: u32 = 12;
-pub comptime global BLOCK_ROOT_ROLLUP_VK_INDEX: u32 = 13;
-pub comptime global BLOCK_ROOT_SINGLE_TX_ROLLUP_VK_INDEX: u32 = 14;
-pub comptime global BLOCK_MERGE_ROLLUP_VK_INDEX: u32 = 15;
-pub comptime global CHECKPOINT_ROOT_ROLLUP_VK_INDEX: u32 = 16;
-pub comptime global CHECKPOINT_ROOT_SINGLE_BLOCK_ROLLUP_VK_INDEX: u32 = 17;
-pub comptime global CHECKPOINT_PADDING_ROLLUP_VK_INDEX: u32 = 18;
-pub comptime global CHECKPOINT_MERGE_ROLLUP_VK_INDEX: u32 = 19;
-pub comptime global ROOT_ROLLUP_VK_INDEX: u32 = 20;
-pub comptime global PARITY_BASE_VK_INDEX: u32 = 21;
-pub comptime global PARITY_ROOT_VK_INDEX: u32 = 22;
-pub comptime global PRIVATE_KERNEL_RESET_VK_INDEX: u32 = 23;
+pub global PRIVATE_KERNEL_INIT_VK_INDEX: u32 = 0;
+pub global PRIVATE_KERNEL_INNER_VK_INDEX: u32 = 1;
+pub global PRIVATE_KERNEL_TAIL_VK_INDEX: u32 = 2;
+pub global PRIVATE_KERNEL_TAIL_TO_PUBLIC_VK_INDEX: u32 = 3;
+pub global HIDING_KERNEL_TO_ROLLUP_VK_INDEX: u32 = 4;
+pub global HIDING_KERNEL_TO_PUBLIC_VK_INDEX: u32 = 5;
+pub global PUBLIC_CHONK_VERIFIER_VK_INDEX: u32 = 6;
+pub global PRIVATE_TX_BASE_ROLLUP_VK_INDEX: u32 = 7;
+pub global PUBLIC_TX_BASE_ROLLUP_VK_INDEX: u32 = 8;
+pub global TX_MERGE_ROLLUP_VK_INDEX: u32 = 9;
+pub global BLOCK_ROOT_FIRST_ROLLUP_VK_INDEX: u32 = 10;
+pub global BLOCK_ROOT_SINGLE_TX_FIRST_ROLLUP_VK_INDEX: u32 = 11;
+pub global BLOCK_ROOT_EMPTY_TX_FIRST_ROLLUP_VK_INDEX: u32 = 12;
+pub global BLOCK_ROOT_ROLLUP_VK_INDEX: u32 = 13;
+pub global BLOCK_ROOT_SINGLE_TX_ROLLUP_VK_INDEX: u32 = 14;
+pub global BLOCK_MERGE_ROLLUP_VK_INDEX: u32 = 15;
+pub global CHECKPOINT_ROOT_ROLLUP_VK_INDEX: u32 = 16;
+pub global CHECKPOINT_ROOT_SINGLE_BLOCK_ROLLUP_VK_INDEX: u32 = 17;
+pub global CHECKPOINT_PADDING_ROLLUP_VK_INDEX: u32 = 18;
+pub global CHECKPOINT_MERGE_ROLLUP_VK_INDEX: u32 = 19;
+pub global ROOT_ROLLUP_VK_INDEX: u32 = 20;
+pub global PARITY_BASE_VK_INDEX: u32 = 21;
+pub global PARITY_ROOT_VK_INDEX: u32 = 22;
+pub global PRIVATE_KERNEL_RESET_VK_INDEX: u32 = 23;
 // Important: Do not define indexes after the PRIVATE_KERNEL_RESET_VK_INDEX. They are allocated for the variants of private kernel reset.
 
 // SIDE EFFECT RELATED CONSTANTS

noir-projects/noir-protocol-circuits/crates/types/src/poseidon2.nr

@@ -5,8 +5,9 @@ use std::meta::derive;
 // It exists as we sometimes need to perform custom absorption, but the stdlib version
 // has a private absorb() method (it's also designed to just be a hasher)
 // Can be removed when standalone noir poseidon lib exists: See noir#6679
+// TODO: Poseidon is stand-alone now
 
-comptime global RATE: u32 = 3;
+global RATE: u32 = 3;
 
 #[derive(Deserialize, Eq, Serialize)]
 pub struct Poseidon2Sponge {