chore: remove _experimental_ prefix from utility call ifaces (#16150)

There never was really a great reason to do this - there is nothing
"experimental" about these interfaces.

Co-authored-by: benesjan <[email protected]>

Author: nventuro

noir-projects/aztec-nr/aztec/src/macros/functions/call_interface_stubs.nr

@@ -169,11 +169,8 @@ comptime fn create_utility_stub(f: FunctionDefinition) -> Quoted {
         create_stub_base(f);
     let fn_return_type = f.return_type();
 
-    // This is here because utility function call interfaces can only be used within TXe tests.
-    let modified_fn_name = f"_experimental_{fn_name}".quoted_contents();
-
     quote {
-        pub fn $modified_fn_name(self, $fn_parameters_list) -> dep::aztec::context::call_interfaces::UtilityCallInterface<$fn_name_len, $fn_return_type> {
+        pub fn $fn_name(self, $fn_parameters_list) -> dep::aztec::context::call_interfaces::UtilityCallInterface<$fn_name_len, $fn_return_type> {
             $serialized_args_slice_construction
             let selector = $FROM_FIELD($fn_selector);
             dep::aztec::context::call_interfaces::UtilityCallInterface::new(

noir-projects/noir-contracts/contracts/app/nft_contract/src/test/utils.nr

@@ -74,8 +74,8 @@ pub unconstrained fn assert_owns_private_nft(
     owner: AztecAddress,
     token_id: Field,
 ) {
-    let (private_nfts, _) = env.simulate_utility(NFT::at(nft_contract_address)
-        ._experimental_get_private_nfts(owner, 0));
+    let (private_nfts, _) =
+        env.simulate_utility(NFT::at(nft_contract_address).get_private_nfts(owner, 0));
 
     let mut nft_found = false;
     for obtained_token_id in private_nfts {

noir-projects/noir-contracts/contracts/app/token_contract/src/test/utils.nr

@@ -84,9 +84,7 @@ pub unconstrained fn check_private_balance(
     address_amount: u128,
 ) {
     assert_eq(
-        env.simulate_utility(Token::at(token_contract_address)._experimental_balance_of_private(
-            address,
-        )),
+        env.simulate_utility(Token::at(token_contract_address).balance_of_private(address)),
         address_amount,
     );
 }

noir-projects/noir-contracts/contracts/test/counter_contract/src/main.nr

@@ -124,8 +124,8 @@ pub contract Counter {
             let (mut env, contract_address, owner) = setup(initial_value);
 
             // Read the stored value in the note
-            let initial_counter = env.simulate_utility(Counter::at(contract_address)
-                ._experimental_get_counter(owner));
+            let initial_counter =
+                env.simulate_utility(Counter::at(contract_address).get_counter(owner));
             assert(
                 initial_counter == initial_value,
                 f"Expected {initial_value} but got {initial_counter}",
@@ -134,8 +134,8 @@ pub contract Counter {
             // Increment the counter
             env.call_private(owner, Counter::at(contract_address).increment(owner));
 
-            let incremented_counter = env.simulate_utility(Counter::at(contract_address)
-                ._experimental_get_counter(owner));
+            let incremented_counter =
+                env.simulate_utility(Counter::at(contract_address).get_counter(owner));
             let expected_current_value = initial_value + 1;
             assert(
                 expected_current_value == incremented_counter,
@@ -150,31 +150,22 @@ pub contract Counter {
             let (env, contract_address, owner) = setup(initial_value);
 
             // Checking that the note was discovered from private logs
-            let initial_note_value = env.simulate_utility(Counter::at(contract_address)
-                ._experimental_get_counter(owner));
+            let initial_note_value =
+                env.simulate_utility(Counter::at(contract_address).get_counter(owner));
             assert(initial_note_value == initial_value);
 
             env.call_private(owner, Counter::at(contract_address).increment_twice(owner));
 
-            assert_eq(
-                env.simulate_utility(Counter::at(contract_address)._experimental_get_counter(owner)),
-                7,
-            );
+            assert_eq(env.simulate_utility(Counter::at(contract_address).get_counter(owner)), 7);
 
             let _ = env.call_private(
                 owner,
                 Counter::at(contract_address).increment_and_decrement(owner),
             );
-            assert_eq(
-                env.simulate_utility(Counter::at(contract_address)._experimental_get_counter(owner)),
-                7,
-            );
+            assert_eq(env.simulate_utility(Counter::at(contract_address).get_counter(owner)), 7);
 
             env.call_private(owner, Counter::at(contract_address).decrement(owner));
-            assert_eq(
-                env.simulate_utility(Counter::at(contract_address)._experimental_get_counter(owner)),
-                6,
-            );
+            assert_eq(env.simulate_utility(Counter::at(contract_address).get_counter(owner)), 6);
         }
     }
 }

noir-projects/noir-contracts/contracts/test/test_contract/src/test/note_delivery.nr

@@ -49,10 +49,8 @@ unconstrained fn create_note_private_only_tx_and_read_in_utility() {
         test_contract.call_create_note(VALUE, recipient, STORAGE_SLOT, make_tx_hybrid),
     );
 
-    let retrieved = env.simulate_utility(test_contract._experimental_call_view_notes(
-        STORAGE_SLOT,
-        ACTIVE_OR_NULLIFIED,
-    ));
+    let retrieved =
+        env.simulate_utility(test_contract.call_view_notes(STORAGE_SLOT, ACTIVE_OR_NULLIFIED));
     assert_eq(retrieved, VALUE);
 }
 
@@ -86,10 +84,8 @@ unconstrained fn create_note_hybrid_tx_and_read_in_utility() {
         test_contract.call_create_note(VALUE, recipient, STORAGE_SLOT, make_tx_hybrid),
     );
 
-    let retrieved = env.simulate_utility(test_contract._experimental_call_view_notes(
-        STORAGE_SLOT,
-        ACTIVE_OR_NULLIFIED,
-    ));
+    let retrieved =
+        env.simulate_utility(test_contract.call_view_notes(STORAGE_SLOT, ACTIVE_OR_NULLIFIED));
     assert_eq(retrieved, VALUE);
 }
 
@@ -121,10 +117,8 @@ unconstrained fn create_partial_note_in_one_tx_and_read_in_utility() {
         test_contract.call_create_and_complete_partial_note(recipient, STORAGE_SLOT, VALUE),
     );
 
-    let retrieved = env.simulate_utility(test_contract._experimental_call_view_notes(
-        STORAGE_SLOT,
-        ACTIVE_OR_NULLIFIED,
-    ));
+    let retrieved =
+        env.simulate_utility(test_contract.call_view_notes(STORAGE_SLOT, ACTIVE_OR_NULLIFIED));
     assert_eq(retrieved, VALUE);
 }
 
@@ -156,9 +150,7 @@ unconstrained fn create_partial_note_in_two_txs_and_read_in_utility() {
 
     env.call_public(sender, test_contract.call_complete_partial_note(partial_note, VALUE));
 
-    let retrieved = env.simulate_utility(test_contract._experimental_call_view_notes(
-        STORAGE_SLOT,
-        ACTIVE_OR_NULLIFIED,
-    ));
+    let retrieved =
+        env.simulate_utility(test_contract.call_view_notes(STORAGE_SLOT, ACTIVE_OR_NULLIFIED));
     assert_eq(retrieved, VALUE);
 }