fix: Default slashing to tally in all networks (#16929)

spalladino · web-flow · commit c661ad699da6 · 2025-09-10T18:16:36.000Z
- Sets a common slashing config for all deployments in `chain_l2_config`
(tally slashing, no vetoer, fast execution, sentinel enabled).
- Disables inactivity offenses if their penalty is set to zero.
- Defaults `slashInactivityTargetPercentage` to a valid value (it was
zero on some configs).
- Defaults `slashInactivityConsecutiveEpochThreshold` to 1 (may change
in the near future).
- Handles slasher being `none` in `yarn-project/ethereum/src/queries.ts`
- Caches slasher address in the slasher clients
- Renames `getSlasher` to `getSlasherAddress` to differentiate it from
`getSlasherContract`.
diff --git a/yarn-project/aztec-node/src/sentinel/sentinel.ts b/yarn-project/aztec-node/src/sentinel/sentinel.ts
@@ -190,6 +190,10 @@ export class Sentinel extends (EventEmitter as new () => WatcherEmitter) impleme
   }
 
   protected async handleProvenPerformance(epoch: bigint, performance: ValidatorsEpochPerformance) {
+    if (this.config.slashInactivityPenalty === 0n) {
+      return;
+    }
+
     const inactiveValidators = getEntries(performance)
       .filter(([_, { missed, total }]) => missed / total >= this.config.slashInactivityTargetPercentage)
       .map(([address]) => address);
diff --git a/yarn-project/cli/src/config/chain_l2_config.ts b/yarn-project/cli/src/config/chain_l2_config.ts
@@ -34,6 +34,40 @@ export type L2ChainConfig = L1ContractsConfig &
     sentinelEnabled: boolean;
   };
 
+const DefaultSlashConfig = {
+  /** Tally-style slashing */
+  slasherFlavor: 'tally',
+  /** Allow one round for vetoing */
+  slashingExecutionDelayInRounds: 1,
+  /** How long for a slash payload to be executed */
+  slashingLifetimeInRounds: 5,
+  /** Allow 2 rounds to discover faults */
+  slashingOffsetInRounds: 2,
+  /** No slash vetoer */
+  slashingVetoer: EthAddress.ZERO,
+  /** Use default slash amounts */
+  slashAmountSmall: DefaultL1ContractsConfig.slashAmountSmall,
+  slashAmountMedium: DefaultL1ContractsConfig.slashAmountMedium,
+  slashAmountLarge: DefaultL1ContractsConfig.slashAmountLarge,
+
+  // Slashing stuff
+  slashMinPenaltyPercentage: 0.5,
+  slashMaxPenaltyPercentage: 2.0,
+  slashInactivityTargetPercentage: 0.7,
+  slashInactivityConsecutiveEpochThreshold: 1,
+  slashInactivityPenalty: DefaultL1ContractsConfig.slashAmountSmall,
+  slashPrunePenalty: DefaultL1ContractsConfig.slashAmountSmall,
+  slashDataWithholdingPenalty: DefaultL1ContractsConfig.slashAmountSmall,
+  slashProposeInvalidAttestationsPenalty: DefaultL1ContractsConfig.slashAmountLarge,
+  slashAttestDescendantOfInvalidPenalty: DefaultL1ContractsConfig.slashAmountLarge,
+  slashUnknownPenalty: DefaultL1ContractsConfig.slashAmountSmall,
+  slashBroadcastedInvalidBlockPenalty: DefaultL1ContractsConfig.slashAmountMedium,
+  slashMaxPayloadSize: 50,
+  slashGracePeriodL2Slots: 32 * 2, // Two epochs from genesis
+  slashOffenseExpirationRounds: 8,
+  sentinelEnabled: true,
+} satisfies Partial<L2ChainConfig>;
+
 export const stagingIgnitionL2ChainConfig: L2ChainConfig = {
   l1ChainId: 11155111,
   testAccounts: true,
@@ -55,6 +89,7 @@ export const stagingIgnitionL2ChainConfig: L2ChainConfig = {
   publicMetricsCollectFrom: ['sequencer'],
 
   ...DefaultL1ContractsConfig,
+  ...DefaultSlashConfig,
 
   /** How many seconds an L1 slot lasts. */
   ethereumSlotDuration: 12,
@@ -70,26 +105,6 @@ export const stagingIgnitionL2ChainConfig: L2ChainConfig = {
   manaTarget: 0n,
   /** The proving cost per mana */
   provingCostPerMana: 0n,
-
-  slasherFlavor: 'none',
-  slashAmountSmall: 0n,
-  slashAmountMedium: 0n,
-  slashAmountLarge: 0n,
-  slashMinPenaltyPercentage: 0.5,
-  slashMaxPenaltyPercentage: 200,
-  slashInactivityTargetPercentage: 0,
-  slashInactivityConsecutiveEpochThreshold: 1,
-  slashInactivityPenalty: 0n,
-  slashPrunePenalty: 0n,
-  slashDataWithholdingPenalty: 0n,
-  slashProposeInvalidAttestationsPenalty: 0n,
-  slashAttestDescendantOfInvalidPenalty: 0n,
-  slashBroadcastedInvalidBlockPenalty: 0n,
-  slashMaxPayloadSize: 50,
-  slashGracePeriodL2Slots: 0,
-  slashUnknownPenalty: 0n,
-  slashOffenseExpirationRounds: 10,
-  sentinelEnabled: false,
 };
 
 export const stagingPublicL2ChainConfig: L2ChainConfig = {
@@ -139,37 +154,8 @@ export const stagingPublicL2ChainConfig: L2ChainConfig = {
   provingCostPerMana: DefaultL1ContractsConfig.provingCostPerMana,
   /** Exit delay for stakers */
   exitDelaySeconds: DefaultL1ContractsConfig.exitDelaySeconds,
-  /** Tally-style slashing */
-  slasherFlavor: 'tally',
-  /** Allow one round for vetoing */
-  slashingExecutionDelayInRounds: 1,
-  /** How long for a slash payload to be executed */
-  slashingLifetimeInRounds: 5,
-  /** Allow 2 rounds to discover faults */
-  slashingOffsetInRounds: 2,
-  /** No slash vetoer */
-  slashingVetoer: EthAddress.ZERO,
-  /** Use default slash amounts */
-  slashAmountSmall: DefaultL1ContractsConfig.slashAmountSmall,
-  slashAmountMedium: DefaultL1ContractsConfig.slashAmountMedium,
-  slashAmountLarge: DefaultL1ContractsConfig.slashAmountLarge,
 
-  // Slashing stuff
-  slashMinPenaltyPercentage: 0.5,
-  slashMaxPenaltyPercentage: 2.0,
-  slashInactivityTargetPercentage: 0.7,
-  slashInactivityConsecutiveEpochThreshold: 1,
-  slashInactivityPenalty: DefaultL1ContractsConfig.slashAmountSmall,
-  slashPrunePenalty: DefaultL1ContractsConfig.slashAmountSmall,
-  slashDataWithholdingPenalty: DefaultL1ContractsConfig.slashAmountSmall,
-  slashProposeInvalidAttestationsPenalty: DefaultL1ContractsConfig.slashAmountLarge,
-  slashAttestDescendantOfInvalidPenalty: DefaultL1ContractsConfig.slashAmountLarge,
-  slashUnknownPenalty: DefaultL1ContractsConfig.slashAmountSmall,
-  slashBroadcastedInvalidBlockPenalty: DefaultL1ContractsConfig.slashAmountMedium,
-  slashMaxPayloadSize: 50,
-  slashGracePeriodL2Slots: 32 * 2, // Two epochs from genesis
-  slashOffenseExpirationRounds: 8,
-  sentinelEnabled: true,
+  ...DefaultSlashConfig,
 };
 
 export const testnetL2ChainConfig: L2ChainConfig = {
@@ -219,37 +205,8 @@ export const testnetL2ChainConfig: L2ChainConfig = {
   provingCostPerMana: DefaultL1ContractsConfig.provingCostPerMana,
   /** Exit delay for stakers */
   exitDelaySeconds: DefaultL1ContractsConfig.exitDelaySeconds,
-  /** Tally-style slashing */
-  slasherFlavor: 'tally',
-  /** Allow one round for vetoing */
-  slashingExecutionDelayInRounds: 1,
-  /** How long for a slash payload to be executed */
-  slashingLifetimeInRounds: 5,
-  /** Allow 2 rounds to discover faults */
-  slashingOffsetInRounds: 2,
-  /** No slash vetoer */
-  slashingVetoer: EthAddress.ZERO,
-  /** Use default slash amounts */
-  slashAmountSmall: DefaultL1ContractsConfig.slashAmountSmall,
-  slashAmountMedium: DefaultL1ContractsConfig.slashAmountMedium,
-  slashAmountLarge: DefaultL1ContractsConfig.slashAmountLarge,
 
-  // Slashing stuff
-  slashMinPenaltyPercentage: 0.5,
-  slashMaxPenaltyPercentage: 2.0,
-  slashInactivityTargetPercentage: 0.7,
-  slashInactivityConsecutiveEpochThreshold: 1,
-  slashInactivityPenalty: DefaultL1ContractsConfig.slashAmountSmall,
-  slashPrunePenalty: DefaultL1ContractsConfig.slashAmountSmall,
-  slashDataWithholdingPenalty: DefaultL1ContractsConfig.slashAmountSmall,
-  slashProposeInvalidAttestationsPenalty: DefaultL1ContractsConfig.slashAmountLarge,
-  slashAttestDescendantOfInvalidPenalty: DefaultL1ContractsConfig.slashAmountLarge,
-  slashUnknownPenalty: DefaultL1ContractsConfig.slashAmountSmall,
-  slashBroadcastedInvalidBlockPenalty: DefaultL1ContractsConfig.slashAmountMedium,
-  slashMaxPayloadSize: 50,
-  slashGracePeriodL2Slots: 32 * 2, // Two epochs from genesis
-  slashOffenseExpirationRounds: 8,
-  sentinelEnabled: true,
+  ...DefaultSlashConfig,
 };
 
 const BOOTNODE_CACHE_DURATION_MS = 60 * 60 * 1000; // 1 hour;
diff --git a/yarn-project/end-to-end/src/e2e_p2p/p2p_network.ts b/yarn-project/end-to-end/src/e2e_p2p/p2p_network.ts
@@ -415,7 +415,7 @@ export class P2PNetworkTest {
     );
 
     const slasherContract = getContract({
-      address: getAddress(await rollup.getSlasher()),
+      address: getAddress(await rollup.getSlasherAddress()),
       abi: SlasherAbi,
       client: this.ctx.deployL1ContractsValues.l1Client,
     });
diff --git a/yarn-project/end-to-end/src/e2e_p2p/slash_veto_demo.test.ts b/yarn-project/end-to-end/src/e2e_p2p/slash_veto_demo.test.ts
@@ -284,7 +284,7 @@ describe('veto slash', () => {
 
       await t.ctx.cheatCodes.eth.stopImpersonating(t.ctx.deployL1ContractsValues.l1ContractAddresses.governanceAddress);
 
-      const slasherAddress = await rollup.getSlasher();
+      const slasherAddress = await rollup.getSlasherAddress();
       expect(slasherAddress.toLowerCase()).toEqual(newSlasherAddress.toString().toLowerCase());
       debugLogger.info(`\n\nnew slasher address: ${slasherAddress}\n\n`);
       const slasher = getContract({
@@ -352,7 +352,7 @@ describe('veto slash', () => {
       //##############################//
 
       if (shouldVeto) {
-        const slasherAddress = await rollup.getSlasher();
+        const slasherAddress = await rollup.getSlasherAddress();
         const { receipt } = await vetoerL1TxUtils.sendAndMonitorTransaction({
           to: slasherAddress,
           data: encodeFunctionData({
diff --git a/yarn-project/ethereum/src/contracts/empire_slashing_proposer.ts b/yarn-project/ethereum/src/contracts/empire_slashing_proposer.ts
@@ -33,10 +33,14 @@ export class EmpireSlashingProposerContract extends EventEmitter implements IEmp
 
   constructor(
     public readonly client: ViemClient,
-    address: Hex,
+    address: Hex | EthAddress,
   ) {
     super();
-    this.proposer = getContract({ address, abi: EmpireSlashingProposerAbi, client });
+    this.proposer = getContract({
+      address: typeof address === 'string' ? address : address.toString(),
+      abi: EmpireSlashingProposerAbi,
+      client,
+    });
   }
 
   public get address() {
diff --git a/yarn-project/ethereum/src/contracts/rollup.ts b/yarn-project/ethereum/src/contracts/rollup.ts
@@ -3,7 +3,6 @@ import { EthAddress } from '@aztec/foundation/eth-address';
 import type { ViemSignature } from '@aztec/foundation/eth-signature';
 import { RollupAbi } from '@aztec/l1-artifacts/RollupAbi';
 import { RollupStorage } from '@aztec/l1-artifacts/RollupStorage';
-import { SlasherAbi } from '@aztec/l1-artifacts/SlasherAbi';
 
 import chunk from 'lodash.chunk';
 import {
@@ -12,7 +11,6 @@ import {
   type Hex,
   type StateOverride,
   encodeFunctionData,
-  getAddress,
   getContract,
   hexToBigInt,
   keccak256,
@@ -160,13 +158,12 @@ export class RollupContract {
   public async getSlashingProposer(): Promise<
     EmpireSlashingProposerContract | TallySlashingProposerContract | undefined
   > {
-    const slasherAddress = await this.rollup.read.getSlasher();
-    if (EthAddress.fromString(slasherAddress).isZero()) {
+    const slasher = await this.getSlasherContract();
+    if (!slasher) {
       return undefined;
     }
 
-    const slasher = getContract({ address: slasherAddress, abi: SlasherAbi, client: this.client });
-    const proposerAddress = await slasher.read.PROPOSER();
+    const proposerAddress = await slasher.getProposer();
     const proposerAbi = [
       {
         type: 'function',
@@ -177,7 +174,7 @@ export class RollupContract {
       },
     ] as const;
 
-    const proposer = getContract({ address: proposerAddress, abi: proposerAbi, client: this.client });
+    const proposer = getContract({ address: proposerAddress.toString(), abi: proposerAbi, client: this.client });
     const proposerType = await proposer.read.SLASHING_PROPOSER_TYPE();
     if (proposerType === SlashingProposerType.Tally.valueOf()) {
       return new TallySlashingProposerContract(this.client, proposerAddress);
@@ -298,16 +295,19 @@ export class RollupContract {
     };
   }
 
-  getSlasher() {
+  getSlasherAddress() {
     return this.rollup.read.getSlasher();
   }
 
   /**
    * Returns a SlasherContract instance for interacting with the slasher contract.
    */
-  async getSlasherContract(): Promise<SlasherContract> {
-    const slasherAddress = await this.getSlasher();
-    return new SlasherContract(this.client, EthAddress.fromString(slasherAddress));
+  async getSlasherContract(): Promise<SlasherContract | undefined> {
+    const slasherAddress = EthAddress.fromString(await this.getSlasherAddress());
+    if (slasherAddress.isZero()) {
+      return undefined;
+    }
+    return new SlasherContract(this.client, slasherAddress);
   }
 
   getOwner() {
@@ -319,13 +319,11 @@ export class RollupContract {
   }
 
   public async getSlashingProposerAddress() {
-    const slasherAddress = await this.getSlasher();
-    const slasher = getContract({
-      address: getAddress(slasherAddress.toString()),
-      abi: SlasherAbi,
-      client: this.client,
-    });
-    return EthAddress.fromString(await slasher.read.PROPOSER());
+    const slasher = await this.getSlasherContract();
+    if (!slasher) {
+      return EthAddress.ZERO;
+    }
+    return await slasher.getProposer();
   }
 
   getBlockReward() {
diff --git a/yarn-project/ethereum/src/deploy_l1_contracts.ts b/yarn-project/ethereum/src/deploy_l1_contracts.ts
@@ -1143,7 +1143,7 @@ export const deployL1Contracts = async (
 
       // Include Slasher and SlashingProposer (if deployed) in verification data
       try {
-        const slasherAddrHex = await rollup.getSlasher();
+        const slasherAddrHex = await rollup.getSlasherAddress();
         const slasherAddr = EthAddress.fromString(slasherAddrHex);
         if (!slasherAddr.isZero()) {
           // Slasher constructor: (address _vetoer, address _governance)
diff --git a/yarn-project/ethereum/src/queries.ts b/yarn-project/ethereum/src/queries.ts
@@ -1,7 +1,4 @@
 import { EthAddress } from '@aztec/foundation/eth-address';
-import { SlasherAbi } from '@aztec/l1-artifacts/SlasherAbi';
-
-import { getContract } from 'viem';
 
 import type { L1ContractsConfig } from './config.js';
 import { ReadOnlyGovernanceContract } from './contracts/governance.js';
@@ -27,8 +24,7 @@ export async function getL1ContractsConfig(
   const rollupAddress = addresses.rollupAddress ?? (await governanceProposer.getRollupAddress());
   const rollup = new RollupContract(publicClient, rollupAddress.toString());
   const slasherProposer = await rollup.getSlashingProposer();
-  const slasherAddress = await rollup.getSlasher();
-  const slasher = getContract({ address: slasherAddress, abi: SlasherAbi, client: publicClient });
+  const slasher = await rollup.getSlasherContract();
 
   const [
     l1StartBlock,
@@ -72,7 +68,7 @@ export async function getL1ContractsConfig(
     slasherProposer?.getExecutionDelayInRounds() ?? 0n,
     slasherProposer?.type === 'tally' ? slasherProposer.getSlashOffsetInRounds() : 0n,
     slasherProposer?.type === 'tally' ? slasherProposer.getSlashingAmounts() : [0n, 0n, 0n],
-    slasher.read.VETOER(),
+    slasher?.getVetoer() ?? EthAddress.ZERO,
     rollup.getManaTarget(),
     rollup.getProvingCostPerMana(),
     rollup.getVersion(),
@@ -96,7 +92,7 @@ export async function getL1ContractsConfig(
     slashingRoundSizeInEpochs: Number(slashingRoundSize / aztecEpochDuration),
     slashingLifetimeInRounds: Number(slashingLifetimeInRounds),
     slashingExecutionDelayInRounds: Number(slashingExecutionDelayInRounds),
-    slashingVetoer: EthAddress.fromString(slashingVetoer),
+    slashingVetoer,
     manaTarget: manaTarget,
     provingCostPerMana: provingCostPerMana,
     rollupVersion: Number(rollupVersion),
diff --git a/yarn-project/slasher/src/empire_slasher_client.test.ts b/yarn-project/slasher/src/empire_slasher_client.test.ts
@@ -173,6 +173,7 @@ describe('EmpireSlasherClient', () => {
       settings,
       slashFactoryContract,
       slashingProposer,
+      slasherContract,
       rollupContract,
       [dummyWatcher],
       dateProvider,
@@ -641,6 +642,7 @@ class TestEmpireSlasherClient extends EmpireSlasherClient {
     settings: EmpireSlasherSettings,
     slashFactoryContract: SlashFactoryContract,
     slashingProposer: EmpireSlashingProposerContract,
+    slasher: SlasherContract,
     rollup: RollupContract,
     watchers: Watcher[],
     dateProvider: DateProvider,
@@ -653,6 +655,7 @@ class TestEmpireSlasherClient extends EmpireSlasherClient {
       settings,
       slashFactoryContract,
       slashingProposer,
+      slasher,
       rollup,
       watchers,
       dateProvider,
diff --git a/yarn-project/slasher/src/empire_slasher_client.ts b/yarn-project/slasher/src/empire_slasher_client.ts
@@ -1,4 +1,4 @@
-import { EmpireSlashingProposerContract, RollupContract } from '@aztec/ethereum';
+import { EmpireSlashingProposerContract, RollupContract, SlasherContract } from '@aztec/ethereum';
 import { sumBigint } from '@aztec/foundation/bigint';
 import { compactArray, filterAsync, maxBy, pick } from '@aztec/foundation/collection';
 import { EthAddress } from '@aztec/foundation/eth-address';
@@ -121,6 +121,7 @@ export class EmpireSlasherClient implements ProposerSlashActionProvider, Slasher
     private settings: EmpireSlasherSettings,
     private slashFactoryContract: SlashFactoryContract,
     private slashingProposer: EmpireSlashingProposerContract,
+    private slasher: SlasherContract,
     private rollup: RollupContract,
     watchers: Watcher[],
     private dateProvider: DateProvider,
@@ -404,8 +405,7 @@ export class EmpireSlasherClient implements ProposerSlashActionProvider, Slasher
       }
 
       // Check if the slash payload is vetoed
-      const slasherContract = await this.rollup.getSlasherContract();
-      const isVetoed = await slasherContract.isPayloadVetoed(payload.payload);
+      const isVetoed = await this.slasher.isPayloadVetoed(payload.payload);
 
       if (isVetoed) {
         this.log.info(`Payload ${payload.payload} from round ${payload.round} is vetoed, skipping execution`);
diff --git a/yarn-project/slasher/src/factory/create_implementation.ts b/yarn-project/slasher/src/factory/create_implementation.ts
diff --git a/yarn-project/slasher/src/tally_slasher_client.test.ts b/yarn-project/slasher/src/tally_slasher_client.test.ts
diff --git a/yarn-project/slasher/src/tally_slasher_client.ts b/yarn-project/slasher/src/tally_slasher_client.ts
