chore: Accumulated backports to v2 (#18530)

This PR accumulates backport commits throughout the day and will be
auto-merged overnight.

Latest backport: #18525 - chore: loudly fail in network config

🤖 This PR is managed automatically by the backport workflow.
- #18529 - chore: remove --funding-account option until it's implemented
- #18540 - fix: max gas can have fractional part
- #18553 - fix: priority fee fractional part

---------

Co-authored-by: ludamad <[email protected]>
Co-authored-by: spypsy <[email protected]>
Co-authored-by: Santiago Palladino <[email protected]>
Co-authored-by: alexghr <[email protected]>
Co-authored-by: PhilWindle <[email protected]>

Author: 6 people

aztec-up/bin/aztec

@@ -212,6 +212,12 @@ case ${1:-} in
       -v $(realpath $(dirname $2))/:/tmp \
       $DOCKER_REPO:$VERSION /tmp/$(basename $2) $3
     ;;
+  valkeys|valKeys|validator-keys)
+    # Special case for validator keys command to inject LEGACY_BLS_CLI environment variable
+    export ENV_VARS_TO_INJECT="LEGACY_BLS_CLI"
+    exec $(dirname $0)/.aztec-run aztec \
+      node --no-warnings /usr/src/yarn-project/aztec/dest/bin/index.js "$@"
+    ;;
   *)
     export ENV_VARS_TO_INJECT="SECRET_KEY"
     exec $(dirname $0)/.aztec-run aztec \

yarn-project/archiver/package.json

@@ -82,7 +82,7 @@
     "lodash.omit": "^4.5.0",
     "tsc-watch": "^6.0.0",
     "tslib": "^2.5.0",
-    "viem": "npm:@spalladino/[email protected].2-eip7594.2"
+    "viem": "npm:@aztec/[email protected]"
   },
   "devDependencies": {
     "@jest/globals": "^30.0.0",

yarn-project/aztec-faucet/package.json

@@ -70,7 +70,7 @@
     "koa": "^2.16.1",
     "koa-bodyparser": "^4.4.1",
     "koa-router": "^13.1.1",
-    "viem": "npm:@spalladino/[email protected].2-eip7594.2",
+    "viem": "npm:@aztec/[email protected]",
     "zod": "^3.23.8"
   },
   "devDependencies": {

yarn-project/aztec-node/package.json

@@ -92,7 +92,7 @@
     "koa": "^2.16.1",
     "koa-router": "^13.1.1",
     "tslib": "^2.4.0",
-    "viem": "npm:@spalladino/[email protected].2-eip7594.2"
+    "viem": "npm:@aztec/[email protected]"
   },
   "devDependencies": {
     "@jest/globals": "^30.0.0",

yarn-project/aztec.js/package.json

@@ -90,7 +90,8 @@
     "@aztec/stdlib": "workspace:^",
     "axios": "^1.12.0",
     "tslib": "^2.4.0",
-    "viem": "npm:@spalladino/[email protected]"
+    "viem": "npm:@aztec/[email protected]",
+    "zod": "^3.23.8"
   },
   "devDependencies": {
     "@jest/globals": "^30.0.0",

yarn-project/aztec/package.json

@@ -65,7 +65,7 @@
     "commander": "^12.1.0",
     "koa": "^2.16.1",
     "koa-router": "^13.1.1",
-    "viem": "npm:@spalladino/[email protected].2-eip7594.2"
+    "viem": "npm:@aztec/[email protected]"
   },
   "files": [
     "dest",

yarn-project/bb-prover/package.json

@@ -99,7 +99,7 @@
     "jest-mock-extended": "^4.0.0",
     "ts-node": "^10.9.1",
     "typescript": "^5.3.3",
-    "viem": "npm:@spalladino/[email protected].2-eip7594.2"
+    "viem": "npm:@aztec/[email protected]"
   },
   "files": [
     "dest",

yarn-project/blob-sink/package.json

@@ -68,7 +68,7 @@
     "snappy": "^7.2.2",
     "source-map-support": "^0.5.21",
     "tslib": "^2.4.0",
-    "viem": "npm:@spalladino/[email protected].2-eip7594.2",
+    "viem": "npm:@aztec/[email protected]",
     "zod": "^3.23.8"
   },
   "devDependencies": {

yarn-project/cli/package.json

@@ -93,7 +93,7 @@
     "semver": "^7.5.4",
     "source-map-support": "^0.5.21",
     "tslib": "^2.4.0",
-    "viem": "npm:@spalladino/[email protected].2-eip7594.2"
+    "viem": "npm:@aztec/[email protected]"
   },
   "devDependencies": {
     "@aztec/accounts": "workspace:^",

yarn-project/cli/src/cmds/validator_keys/add.ts

@@ -42,7 +42,6 @@ export async function addValidatorKeys(existing: string, options: AddValidatorKe
     json,
     feeRecipient: feeRecipientOpt,
     coinbase: coinbaseOpt,
-    fundingAccount: fundingAccountOpt,
     remoteSigner: remoteSignerOpt,
     password,
     encryptedKeystoreDir,
@@ -63,8 +62,6 @@ export async function addValidatorKeys(existing: string, options: AddValidatorKe
     throw new Error('feeRecipient is required (either present in existing file or via --fee-recipient)');
   }
   const coinbase = (coinbaseOpt as EthAddress | undefined) ?? (first.coinbase as EthAddress | undefined);
-  const fundingAccount =
-    (fundingAccountOpt as EthAddress | undefined) ?? (first.fundingAccount as EthAddress | undefined);
   const derivedRemoteSigner = (first.attester as any)?.remoteSignerUrl || (first.attester as any)?.eth?.remoteSignerUrl;
   const remoteSigner = remoteSignerOpt ?? derivedRemoteSigner;
 
@@ -87,7 +84,6 @@ export async function addValidatorKeys(existing: string, options: AddValidatorKe
     feeRecipient,
     coinbase,
     remoteSigner,
-    fundingAccount,
   });
 
   keystore.validators.push(...validators);