Skip to content

Commit f43b23d

Browse files
committed
chore: reduce lookup tuple for double in scalarmul
1 parent b093bb8 commit f43b23d

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

barretenberg/cpp/pil/vm2/scalar_mul.pil

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,10 +176,10 @@ namespace scalar_mul;
176176
temp_inf' - temp_inf' = 0;
177177

178178
#[DOUBLE]
179-
sel_not_end { temp_x, temp_y, temp_inf, temp_x', temp_y', temp_inf', temp_x', temp_y', temp_inf' }
179+
sel_not_end { temp_x, temp_y, temp_inf, temp_x', temp_y', temp_inf', sel_not_end /* = 1 */ }
180180
in
181181
ecc.sel
182-
{ ecc.r_x, ecc.r_y, ecc.r_is_inf, ecc.p_x, ecc.p_y, ecc.p_is_inf, ecc.q_x, ecc.q_y, ecc.q_is_inf };
182+
{ ecc.r_x, ecc.r_y, ecc.r_is_inf, ecc.p_x, ecc.p_y, ecc.p_is_inf, ecc.double_op };
183183

184184
///////////////////////////////
185185
// Result Computation

barretenberg/cpp/src/barretenberg/vm2/generated/relations/lookups_scalar_mul.hpp

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -44,22 +44,21 @@ using lookup_scalar_mul_to_radix_relation = lookup_relation_base<FF_, lookup_sca
4444
struct lookup_scalar_mul_double_settings_ {
4545
static constexpr std::string_view NAME = "LOOKUP_SCALAR_MUL_DOUBLE";
4646
static constexpr std::string_view RELATION_NAME = "scalar_mul";
47-
static constexpr size_t LOOKUP_TUPLE_SIZE = 9;
47+
static constexpr size_t LOOKUP_TUPLE_SIZE = 7;
4848
static constexpr Column SRC_SELECTOR = Column::scalar_mul_sel_not_end;
4949
static constexpr Column DST_SELECTOR = Column::ecc_sel;
5050
static constexpr Column COUNTS = Column::lookup_scalar_mul_double_counts;
5151
static constexpr Column INVERSES = Column::lookup_scalar_mul_double_inv;
5252
static constexpr std::array<ColumnAndShifts, LOOKUP_TUPLE_SIZE> SRC_COLUMNS = {
53-
ColumnAndShifts::scalar_mul_temp_x, ColumnAndShifts::scalar_mul_temp_y,
54-
ColumnAndShifts::scalar_mul_temp_inf, ColumnAndShifts::scalar_mul_temp_x_shift,
55-
ColumnAndShifts::scalar_mul_temp_y_shift, ColumnAndShifts::scalar_mul_temp_inf_shift,
56-
ColumnAndShifts::scalar_mul_temp_x_shift, ColumnAndShifts::scalar_mul_temp_y_shift,
57-
ColumnAndShifts::scalar_mul_temp_inf_shift
53+
ColumnAndShifts::scalar_mul_temp_x, ColumnAndShifts::scalar_mul_temp_y,
54+
ColumnAndShifts::scalar_mul_temp_inf, ColumnAndShifts::scalar_mul_temp_x_shift,
55+
ColumnAndShifts::scalar_mul_temp_y_shift, ColumnAndShifts::scalar_mul_temp_inf_shift,
56+
ColumnAndShifts::scalar_mul_sel_not_end
5857
};
5958
static constexpr std::array<ColumnAndShifts, LOOKUP_TUPLE_SIZE> DST_COLUMNS = {
60-
ColumnAndShifts::ecc_r_x, ColumnAndShifts::ecc_r_y, ColumnAndShifts::ecc_r_is_inf,
61-
ColumnAndShifts::ecc_p_x, ColumnAndShifts::ecc_p_y, ColumnAndShifts::ecc_p_is_inf,
62-
ColumnAndShifts::ecc_q_x, ColumnAndShifts::ecc_q_y, ColumnAndShifts::ecc_q_is_inf
59+
ColumnAndShifts::ecc_r_x, ColumnAndShifts::ecc_r_y, ColumnAndShifts::ecc_r_is_inf,
60+
ColumnAndShifts::ecc_p_x, ColumnAndShifts::ecc_p_y, ColumnAndShifts::ecc_p_is_inf,
61+
ColumnAndShifts::ecc_double_op
6362
};
6463
};
6564

0 commit comments

Comments
 (0)