Skip to content

Commit fe7696f

Browse files
author
notnotraju
committed
comments on set impl related to MSM stuff
1 parent b106827 commit fe7696f

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

barretenberg/cpp/src/barretenberg/relations/ecc_vm/ecc_set_relation_impl.hpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -357,8 +357,11 @@ Accumulator ECCVMSetRelationImpl<FF>::compute_grand_product_denominator(const Al
357357
* @brief Third term: tuple of (pc, P.x, P.y, msm-size) from ECCVMTranscriptRelation.
358358
* (P.x, P.y) is the *claimed* output of a multi-scalar-multiplication evaluated in ECCVMMSMRelation.
359359
* We need to validate that the msm output produced in ECCVMMSMRelation is equivalent to the output present
360-
* in `transcript_msm_output_x, transcript_msm_output_y`, for a given multi-scalar multiplication starting at
361-
* `transcript_pc` and has size `transcript_msm_count`
360+
* in `transcript_msm_output_x, transcript_msm_output_y`, for a given multi-scalar multiplication starting at
361+
* `transcript_pc` and has size `transcript_msm_count`.
362+
* @note In the case of an honest prover, `(transcript_msm_output_x, transcript_msm_output_y)` is the value of the
363+
* just-completed MSM + `OFFSET` (as this is what the MSM table computes with to avoid branch logic.)
364+
*
362365
*/
363366
{
364367
auto transcript_pc_shift = View(in.transcript_pc_shift);

0 commit comments

Comments
 (0)