Skip to content

chore: audit databus - small cleanups and tests coverage #16703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kashbrti merged 9 commits into from
Sep 5, 2025
Merged

chore: audit databus - small cleanups and tests coverage #16703

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7e33fd3
small refactor
kashbrti Sep 2, 2025
d9f1b05
Merge branch 'merge-train/barretenberg' into kb/databus_small_refactor
kashbrti Sep 2, 2025
d6ac2dd
changed to use set_variable
kashbrti Sep 2, 2025
e8662d0
added tests for constants and unnormalized indexes
kashbrti Sep 3, 2025
5f47ccc
typo
kashbrti Sep 3, 2025
5c79d7a
fixed indices in tests
kashbrti Sep 3, 2025
e9d0d5a
small test change
kashbrti Sep 3, 2025
c8a2339
comments updated
kashbrti Sep 3, 2025
5de83a5
better comments
kashbrti Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions barretenberg/cpp/src/barretenberg/dsl/acir_format/block_constraint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,14 +179,10 @@ void process_call_data_operations(Builder& builder,
BB_ASSERT_EQ(op.access_type, 0);
field_ct value = poly_to_field_ct(op.value, builder);
field_ct index = poly_to_field_ct(op.index, builder);
fr w_value = 0;
if (has_valid_witness_assignments) {
// If witness are assigned, we use the correct value for w
w_value = index.get_value();
value.assert_equal(calldata_array[index]);
if (!has_valid_witness_assignments) {
index.is_zero();
Copy link
Contributor Author

@kashbrti kashbrti Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need to do this? This if is only reached when mocking. We were already checking that the index value is zero with the copy constraint. But if it's only in mock cases, do we need to assert it's zero in circuit? I think the change I made causes issues because the mock would have an extra gate, so probably vk generation will be wrong

}
field_ct w = field_ct::from_witness(&builder, w_value);
value.assert_equal(calldata_array[w]);
w.assert_equal(index);
}
};

Expand Down
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/stdlib/primitives/databus/databus.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ field_t<Builder> databus<Builder>::bus_vector::operator[](const field_pt& index)
if (index.is_constant()) {
index_witness_idx = context->put_constant_variable(index.get_value());
} else {
index_witness_idx = index.normalize().get_witness_index();
index_witness_idx = index.get_normalized_witness_index();
}

// Read from the bus vector at the specified index. Creates a single read gate
Expand Down
Loading