Conversation
While the pieces were there before, I would say the culmination of them amounts to a new feature. Now if you do --print_bench or BB_BENCH=1 on a bb or a test (or even a bench to get clearer numbers) you will get a listing like below
AztecBot
requested review from
IlyasRidhuan,
Maddiaa0,
charlielye,
fcarreiro and
jeanmon
as code owners
ludamad
approved these changes
Sep 2, 2025
Any commits made after this event will not be merged.
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
…16201) This changes vks to be serialized as bytes using to_field_elements. Proofs were already byte-compatible, this allows having bb not worry about how to split fields into JSON The changes are holistic as we now need to split the fields from the binary vk/proof - but this is now trivial with the new deserialization format.
Some issue with updating backend.ts I don't understand
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat(bb): --print_bench (#16673)
refactor(bb): remove --output_format, have one-size-fits-all format (#16201)
fix(bb): fix vk simplified buffer (#16720)
fix(avm): avm vk after serialization unification (#16721)
END_COMMIT_OVERRIDE