-
Notifications
You must be signed in to change notification settings - Fork 580
feat: aztec-up installs without docker #18665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hi. Any chance we can have automatic aztec version selection by specifying the aztec version inside a dotfile per each project. Similar to gaztec: https://github.com/nemi-fi/gaztec |
d3ec352 to
03f7ef2
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8e792d8 to
ab988be
Compare
a85f821 to
530d114
Compare
ludamad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool. Do we at some point just release a contract dev image thats just the result of running aztec-up on a fresh ubuntu, and then strip everything contract dev-related out of release-image?
|
Thanks for doing this maddeningly detail-oriented work |
It's possible, but I also thought we'd probably just stop providing any kind of "contract dev" image, and just provide an image for node operators (of which the build of the image could possibly use the installer if we make bb-avm part of an npm package). parts of the contract dev experience could work ok in the container (e.g running the TXE and local network), but things like the wallet, that wanted to use ssh agent were a right pain. Seems easier at this point to just commit to supporting all native installs, and just provide an image for infrastructure convienience. |
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Now we're shipping `bb` in bb.js for supported architectures/os's, we can support installs without needing docker. The user does however need a distribution with: * The minimum required node version. * Tools e.g: `make`, `gcc`, `python`, `git`. _Note: You will not be able to do backend proving as we don't ship `bb-avm`. This is contract development only. Provers/validators are expected to still use the release image._ This PR: * `boxes` and `aztec-up` no longer depends on `release-image`. * We test `aztec-up` with a local npm registry (`verdaccio`) that we prime with the monorepo packages. * New install script that installs correct versions of: * `nargo` * foundry * jq * packages `@aztec/aztec`, `@aztec/cli-wallet`, `bb` via `@aztec/bb.js`. * `./bootstrap.sh versions` outputs all expected versions of relevant tools (used by aztec-up). * `boxes` now build and test without any requirement on a release image (they start the local network directly). * Remove unwanted `npx aztec-create` stuff from boxes. * Remove some never used log commands from ci.sh. * Rework some bootstrap release stuff so we can easily get paths to packages to be released (helps load into verdaccio). * Remove interactive query from noir precommit hook as they can't be interactive. * Move the nasty aztec cli extension script(s) out of `aztec-up` and into `yarn-project/aztec/scripts/aztec.sh` and make it the entrypoint. The script was only every meant to abstract away the docker container but additional functionality made its way in. This functionality should probably all be TS code, but for now at least it's owned by the cli package. Extensions are `test`, `compile`, `new`, `init`. Co-authored-by: iAmMichaelConnor <[email protected]> Co-authored-by: ludamad <[email protected]>
cd2bf56 to
0ffc1e0
Compare

Now we're shipping
bbin bb.js for supported architectures/os's, we can support installs without needing docker.The user does however need a distribution with:
make,gcc,python,git.Note: You will not be able to do backend proving as we don't ship
bb-avm. This is contract development only. Provers/validators are expected to still use the release image.This PR:
boxesandaztec-upno longer depends onrelease-image.aztec-upwith a local npm registry (verdaccio) that we prime with the monorepo packages.nargo@aztec/aztec,@aztec/cli-wallet,bbvia@aztec/bb.js../bootstrap.sh versionsoutputs all expected versions of relevant tools (used by aztec-up).boxesnow build and test without any requirement on a release image (they start the local network directly).npx aztec-createstuff from boxes.aztec-upand intoyarn-project/aztec/scripts/aztec.shand make it the entrypoint. The script was only every meant to abstract away the docker container but additional functionality made its way in. This functionality should probably all be TS code, but for now at least it's owned by the cli package. Extensions aretest,compile,new,init.