refactor!: StakingAssetHandler is a normal faucet #19136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
just-mitch
force-pushed
the
mitch/a-422-refactor-stakingassethandler-to-be-a-normal-faucet
branch
2 times, most recently
from
50af28c to
d341d96
Compare
just-mitch
force-pushed
the
mitch/a-422-refactor-stakingassethandler-to-be-a-normal-faucet
branch
2 times, most recently
from
5fe09a7 to
f272c2b
Compare
just-mitch
force-pushed
the
mitch/a-422-refactor-stakingassethandler-to-be-a-normal-faucet
branch
3 times, most recently
from
698e95e to
48379c3
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
just-mitch
force-pushed
the
mitch/a-422-refactor-stakingassethandler-to-be-a-normal-faucet
branch
from
48379c3 to
4984525
Compare
just-mitch
changed the base branch from
graphite-base/19136
to
mitch/a-445-add-claude-skill-for-updating-docs
Base automatically changed from
mitch/a-445-add-claude-skill-for-updating-docs
to
next
January 6, 2026 20:08
LHerskind
approved these changes
Jan 13, 2026
Contributor
LHerskind
left a comment
LHerskind
left a comment
There was a problem hiding this comment.
took a very quick look mainly on the staking asset handler.
| validityPeriodInSeconds: 604_800, domain: "testnet.aztec.network", scope: "personhood", devMode: false | ||
| }) | ||
| }); | ||
| // vm.prank(0x3c2D61cC98DED634E8bbbFC1fA071fE4b92E1250); |
| _triggerDeposit(rollup, activationThreshold, _attester, _publicKeyG1, _publicKeyG2, _signature); | ||
| } | ||
| // Validate passport proof for sybil resistance | ||
| bytes32 nullifier = _validatePassportProof(msg.sender, _params); |
Contributor
There was a problem hiding this comment.
Is it on purpose that the nullifier is not used in any state updates but just used for the event?
Got misled by the naming 😂 Thought the validate meant that it just validated but it also stores the nullifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the StakingAssetHandler to function like a "normal" faucet. That is, the user submits a zkpassport proof and gets a lump sum of tokens (1M by default).
To do so, it bumps the zkpassport version to 0.15.0, and so needs to bump solc version to 0.8.30.
Contract deployed to https://sepolia.etherscan.io/address/0xD966ce81B6E6eD5A96219DDF896258CBd04eaa69
It also demonstrates use of the new "updating-changelog" claude skill. I asked claude code to "update the changelogs".