refactor: staged writes in private events #19488
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mverzilli
added
the
ci-no-fail-fast
mverzilli
changed the base branch from
next
to
martin/staged-writes-in-tagging-stores
Thunkar
reviewed
Jan 12, 2026
yarn-project/pxe/src/storage/private_event_store/private_event_store.ts
Outdated
Show resolved
Hide resolved
Thunkar
approved these changes
Jan 12, 2026
nventuro
reviewed
Jan 12, 2026
Contributor
nventuro
left a comment
nventuro
left a comment
There was a problem hiding this comment.
I'm not sure I understand your point re. rollbacks, but other than that this looks good. It's sad that the event store is in poor state but thats' life I guess.
yarn-project/pxe/src/storage/private_event_store/private_event_store.ts
Outdated
Show resolved
Hide resolved
yarn-project/pxe/src/storage/private_event_store/private_event_store.ts
Outdated
Show resolved
Hide resolved
yarn-project/pxe/src/storage/private_event_store/private_event_store.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
Good news: this morning I approved a PR by @benesjan that makes the event store substantially nicer |
AztecBot
force-pushed
the
martin/staged-writes-in-tagging-stores
branch
from
e3c729d to
9619e78
Compare
Base automatically changed from
martin/staged-writes-in-tagging-stores
to
next
January 14, 2026 09:39
mverzilli
added
ci-squash-and-merge
and removed
ci-no-fail-fast
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
AztecBot
force-pushed
the
martin/staged-writes-in-private-events
branch
from
17914e7 to
ee88b93
Compare
AztecBot
force-pushed
the
martin/staged-writes-in-private-events
branch
from
ee88b93 to
08fb4a0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
AztecBot
force-pushed
the
martin/staged-writes-in-private-events
branch
from
a874c13 to
8dddf6e
Compare
AztecBot
force-pushed
the
martin/staged-writes-in-private-events
branch
from
8dddf6e to
96dfd77
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mverzilli
requested review from
charlielye,
dbanks12,
fcarreiro and
sirasistant
as code owners
mverzilli
removed request for
charlielye,
dbanks12,
fcarreiro and
sirasistant
Fourth part of the series started with #19445. This makes the PrivateEventStore work based on staged writes. With this, private events aren't written to persistent storage until PXE decides to commit the job.
mverzilli
force-pushed
the
martin/staged-writes-in-private-events
branch
from
e6f491b to
ef81e22
Compare
mverzilli
added
the
ci-no-fail-fast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fourth part of the series started with #19445.
This makes the PrivateEventStore work based on staged writes. With this, private events aren't written to persistent storage until PXE decides to commit the job.