Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
TomAFrench
reviewed
Jan 7, 2025
Maddiaa0
force-pushed
the
md/opt-sol-honk
branch
from
4dccea4 to
9db332e
Compare
lucasxia01
reviewed
Jul 29, 2025
lucasxia01
reviewed
Jul 29, 2025
lucasxia01
reviewed
Jul 29, 2025
barretenberg/acir_tests/bootstrap.sh
Outdated
| echo "$prefix FLOW=sol_honk USE_OPTIMIZED_CONTRACT=true $run_test assert_statement" | ||
| echo "$prefix FLOW=sol_honk USE_OPTIMIZED_CONTRACT=true $run_test a_1_mul" | ||
| echo "$prefix FLOW=sol_honk USE_OPTIMIZED_CONTRACT=true $run_test slices" | ||
| echo "$prefix FLOW=sol_honk USE_OPTIMIZED_CONTRACT=true $run_test verify_honk_proof" |
Contributor
There was a problem hiding this comment.
we don't care about optimized zk contract?
Member
Author
There was a problem hiding this comment.
not for now, its not P1 for audit right now, but will be made a priority once everything in the current round of audits is complete
ludamad
reviewed
Sep 2, 2025
ludamad
reviewed
Sep 2, 2025
| #!/bin/bash | ||
|
|
||
| # Script to copy optimized Solidity verifier files into the C++ honk_optimized_contract.hpp file | ||
| # This automates the manual process of copying optimized verifier contracts |
Collaborator
There was a problem hiding this comment.
Comments from slack:
No comments are blocking, ok with this going in as-is for now
but - we can probably remove a bit of brittleness. you're doing template discovery on what would normally be an output artifact, then doing find replace with strings.
What about:
the script copies the solidity as-is. but the solidity has e.g. // c++-replace VK_HASH comments.
the c++-replace directives can affect the next line
2. store the C++ artifacts in a map of symbol to string
3. process the c++-replace directives
probably error on any unused symbols
Collaborator
There was a problem hiding this comment.
the other thing is, it's more normal to bundle artifacts in C++ as its own header file
ludamad
approved these changes
Sep 2, 2025
AztecBot
force-pushed
the
md/opt-sol-honk
branch
from
f824ebc to
4cfb472
Compare
Complete, without zk Cuts off a million next steps: proof size has a large consequence with this one, due to memory expansion, so having a different proof type for the keccak one which does tighter serialisation will save a good chunk of gas - working on this next - pr here #16018
AztecBot
force-pushed
the
md/opt-sol-honk
branch
from
4cfb472 to
39cc87a
Compare
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete, without zk
Cuts off a million
next steps:
proof size has a large consequence with this one, due to memory expansion, so having a different proof type for the keccak one which does tighter serialisation will save a good chunk of gas - working on this next