applying suggestions, making testnet ci job run nightly

Author: signorecello

.github/workflows/testnet.yaml

@@ -1,14 +1,8 @@
 name: Testnet Tests
 
 on:
-  push:
-    branches:
-      - main
-      - dev
-  pull_request:
-    branches:
-      - main
-      - dev
+  schedule:
+    - cron: '0 2 * * *'
   workflow_dispatch:
     inputs:
       skip_deployment:
@@ -59,7 +53,7 @@ jobs:
       - name: Test testnet connectivity
         run: |
           echo "Testing testnet connectivity..."
-          curl -s https://aztec-alpha-testnet-fullnode.zkv.xyz/status || echo "Warning: Could not connect to testnet"
+          curl -s https://aztec-testnet-fullnode.zkv.xyz/status || echo "Warning: Could not connect to testnet"
 
       - name: Deploy account to testnet
         if: ${{ !inputs.skip_deployment }}

.gitignore

@@ -6,3 +6,4 @@ log/
 .DS_Store
 codegenCache.json
 store/
+.tsbuildinfo

README.md

@@ -50,13 +50,14 @@ aztec-up 2.0.2
 
 ### Environment Configuration
 
-This project uses environment-specific `.env` files to manage configuration:
+This project uses JSON configuration files to manage environment-specific settings:
 
-- `.env.sandbox` - Configuration for local sandbox development
-- `.env.testnet` - Configuration for testnet deployment
-- `.env.local` - Alternative configuration for local development (optional)
+- `config/sandbox.json` - Configuration for local sandbox development
+- `config/testnet.json` - Configuration for testnet deployment
 
-The system automatically loads the appropriate `.env` file based on the `ENV` environment variable. If `ENV` is not set, it defaults to `sandbox`.
+The system automatically loads the appropriate configuration file based on the `ENV` environment variable. If `ENV` is not set, it defaults to `sandbox`.
+
+The configuration files contain network URLs, timeouts, and environment-specific settings. You can modify these files to customize your development environment.
 
 ### Running on Sandbox (Local Development)
 
@@ -84,7 +85,7 @@ yarn deploy-account::testnet      # Deploy account to testnet
 yarn interaction-existing-contract::testnet  # Interact with testnet contracts
 ```
 
-The `::testnet` suffix automatically sets `ENV=testnet`, loading configuration from `.env.testnet`.
+The `::testnet` suffix automatically sets `ENV=testnet`, loading configuration from `config/testnet.json`.
 
 ---
 
@@ -171,10 +172,10 @@ You can find a handful of scripts in the `./scripts` folder.
 
 The `./src/utils/` folder contains utility functions:
 
-- `./src/utils/create_account_from_env.ts` provides functions to create Schnorr accounts from environment variables (SECRET and SALT), useful for account management across different environments.
-- `./src/utils/setup_pxe.ts` provides a function to set up and configure the Private Execution Environment (PXE) service with proper configuration for local development.
+- `./src/utils/create_account_from_env.ts` provides functions to create Schnorr accounts from environment variables (SECRET, SIGNING_KEY, and SALT), useful for account management across different environments.
+- `./src/utils/setup_pxe.ts` provides a function to set up and configure the Private Execution Environment (PXE) service with proper configuration based on the environment.
 - `./src/utils/deploy_account.ts` provides a function to deploy Schnorr accounts to the network with sponsored fee payment, including key generation and deployment verification.
-- `./src/utils/environment.ts` provides environment-aware configuration loading, automatically selecting the correct `.env` file based on the `ENV` variable.
+- `./config/config.ts` provides environment-aware configuration loading, automatically selecting the correct JSON config file based on the `ENV` variable.
 
 ## ❗ **Error Resolution**
 

config/testnet.json

@@ -2,7 +2,7 @@
   "name": "testnet",
   "environment": "testnet",
   "network": {
-    "nodeUrl": "https://aztec-alpha-testnet-fullnode.zkv.xyz",
+    "nodeUrl": "https://aztec-testnet-fullnode.zkv.xyz",
     "l1RpcUrl": "https://ethereum-sepolia-rpc.publicnode.com",
     "l1ChainId": 11155111
   },

src/test/e2e/accounts.test.ts

@@ -2,7 +2,6 @@ import { PrivateVotingContractArtifact, PrivateVotingContract } from "../../arti
 import { AccountManager, AccountWallet, ContractDeployer, createLogger, Fr, PXE, TxStatus, getContractInstanceFromInstantiationParams, Logger, Fq } from "@aztec/aztec.js";
 import { generateSchnorrAccounts } from "@aztec/accounts/testing"
 import { getSchnorrAccount } from '@aztec/accounts/schnorr';
-import { deriveSigningKey } from '@aztec/stdlib/keys';
 import { spawn, spawnSync } from 'child_process';
 
 import { SponsoredFeePaymentMethod } from "@aztec/aztec.js/fee/testing";
@@ -59,7 +58,7 @@ describe("Accounts", () => {
         let secretKey = Fr.random();
         let signingKey = Fq.random();
         let salt = Fr.random();
-        let schnorrAccount = await getSchnorrAccount(pxe, secretKey, deriveSigningKey(secretKey), salt)
+        let schnorrAccount = await getSchnorrAccount(pxe, secretKey, signingKey, salt)
         await schnorrAccount.deploy({ fee: { paymentMethod: sponsoredPaymentMethod } }).wait({ timeout: getTimeouts().deployTimeout });
         ownerWallet = await schnorrAccount.getWallet();
     }, 600000)

src/test/e2e/index.test.ts

@@ -9,7 +9,6 @@ import { createEthereumChain, createExtendedL1Client } from '@aztec/ethereum';
 import { getSponsoredFPCInstance } from "../../utils/sponsored_fpc.js";
 import { setupPXE } from "../../utils/setup_pxe.js";
 import { SponsoredFPCContract } from "@aztec/noir-contracts.js/SponsoredFPC";
-import { deriveSigningKey } from "@aztec/stdlib/keys";
 import { getL1RpcUrl, getTimeouts } from "../../../config/config.js";
 
 describe("Voting", () => {
@@ -48,7 +47,7 @@ describe("Voting", () => {
         let secretKey = Fr.random();
         let signingKey = Fq.random();
         let salt = Fr.random();
-        let schnorrAccount = await getSchnorrAccount(pxe, secretKey, deriveSigningKey(secretKey), salt)
+        let schnorrAccount = await getSchnorrAccount(pxe, secretKey, signingKey, salt)
         await schnorrAccount.deploy({ fee: { paymentMethod: sponsoredPaymentMethod } }).wait({ timeout: getTimeouts().deployTimeout });
         firstWallet = await schnorrAccount.getWallet();
         const existingSenders = await pxe.getSenders();