Enhance constructor argument processing in interaction_existing_contract.ts by improving whitespace and control character handling. Update sandbox workflow to strip ANSI codes from constructor args for cleaner output.

Author: critesjosh

.github/workflows/sandbox.yaml

@@ -138,8 +138,8 @@ jobs:
           PK_OUTGOING=$(grep -o "Master Outgoing Viewing: 0x[a-fA-F0-9]*" "$TEMP_OUTPUT" | head -1 | sed 's/Master Outgoing Viewing: //' || echo "")
           PK_TAGGING=$(grep -o "Master Tagging: 0x[a-fA-F0-9]*" "$TEMP_OUTPUT" | head -1 | sed 's/Master Tagging: //' || echo "")
 
-          # Extract constructor args (JSON array)
-          CONSTRUCTOR_ARGS=$(grep "Constructor args:" "$TEMP_OUTPUT" | sed 's/.*Constructor args: //' || echo "")
+          # Extract constructor args (JSON array), strip ANSI codes, and trim whitespace
+          CONSTRUCTOR_ARGS=$(grep "Constructor args:" "$TEMP_OUTPUT" | sed 's/.*Constructor args: //' | sed 's/\x1b\[[0-9;]*m//g' | tr -d '\n\r' | sed 's/[[:space:]]*$//' || echo "")
 
           rm "$TEMP_OUTPUT"
 

scripts/interaction_existing_contract.ts

@@ -52,12 +52,21 @@ async function main() {
     // Parse constructor args
     let constructorArgs;
     try {
-        // Remove any surrounding quotes that might have been added
-        const cleanedJson = constructorArgsJson.trim().replace(/^['"]|['"]$/g, '');
+        // Remove any surrounding quotes, whitespace, and control characters
+        let cleanedJson = constructorArgsJson.trim();
+        // Remove surrounding quotes (single or double)
+        cleanedJson = cleanedJson.replace(/^['"]|['"]$/g, '');
+        // Remove any trailing whitespace or control characters
+        cleanedJson = cleanedJson.replace(/[\s\r\n]+$/, '');
+
         logger.info(`Parsing constructor args: ${cleanedJson}`);
+        logger.info(`Constructor args length: ${cleanedJson.length}`);
+
         constructorArgs = JSON.parse(cleanedJson).map((arg: string) => AztecAddress.fromString(arg));
     } catch (error) {
-        logger.error(`Failed to parse constructor args: ${constructorArgsJson}`);
+        logger.error(`Failed to parse constructor args`);
+        logger.error(`Raw value: ${JSON.stringify(constructorArgsJson)}`);
+        logger.error(`Raw value length: ${constructorArgsJson.length}`);
         logger.error(`Error: ${error}`);
         throw error;
     }