error handling

Author: signorecello

tooling/sparta/packages/discord/src/api/apiProvider.ts

@@ -1,6 +1,5 @@
 import { clientPromise } from "./axios";
 import type { Client as ApiClient } from "@sparta/utils/openapi/types";
-import { logger } from "@sparta/utils";
 
 /**
  * Singleton class to provide access to the API client
@@ -31,23 +30,11 @@ export class ApiProvider {
 		if (this.client) return; // Already initialized
 
 		try {
-			logger.info("Initializing API client");
 			this.client = await clientPromise;
-			logger.info("API client initialized successfully");
 			this.error = null;
 		} catch (err) {
 			this.error = err instanceof Error ? err : new Error(String(err));
-			logger.error(
-				{
-					error: this.error,
-					message: this.error.message,
-					stack: this.error.stack,
-					apiUrl:
-						process.env.VITE_APP_API_URL || "http://localhost:3000",
-					apiKeyPresent: !!process.env.BACKEND_API_KEY,
-				},
-				"ApiProvider: Failed to initialize client"
-			);
+			console.error("ApiProvider: Failed to initialize client:", err);
 		}
 	}
 
@@ -57,11 +44,7 @@ export class ApiProvider {
 	 */
 	public getClient(): ApiClient {
 		if (!this.client) {
-			const error = new Error(
-				"API client not initialized. Call init() first."
-			);
-			logger.error({ error }, "Failed to get API client");
-			throw error;
+			throw new Error("API client not initialized. Call init() first.");
 		}
 		return this.client;
 	}

tooling/sparta/packages/discord/src/api/axios.ts

@@ -1,16 +1,6 @@
 import { OpenAPIClientAxios } from "openapi-client-axios";
 import { apiDocs } from "@sparta/utils";
 import { type Client } from "@sparta/utils/openapi/types";
-import { logger } from "@sparta/utils";
-
-// Log environment variables related to API configuration
-logger.info(
-	{
-		apiUrl: process.env.VITE_APP_API_URL,
-		nodeEnv: process.env.NODE_ENV,
-	},
-	"API client configuration"
-);
 
 const apiInstance = new OpenAPIClientAxios({
 	// @ts-ignore
@@ -23,20 +13,13 @@ const apiInstance = new OpenAPIClientAxios({
 			Accept: "application/json",
 			"x-api-key": process.env.BACKEND_API_KEY,
 		},
-		// Adding option to allow absolute URLs
-		allowAbsoluteUrls: true,
 	},
 });
 
 // Initialize and export the promise directly
 export const clientPromise = apiInstance
 	.init<Client>()
 	.then((client) => {
-		// Log the configured base URL of the client
-		logger.info(
-			{ baseURL: apiInstance.getAxiosInstance().defaults.baseURL },
-			"API client initialized"
-		);
 		return client;
 	})
 	.catch((err) => {

tooling/sparta/packages/discord/src/slashCommands/humans/verify.ts

@@ -45,16 +45,6 @@ export async function handleVerifyCommand(
 		const client = apiProvider.getClient();
 
 		try {
-			// Log API configuration for debugging
-			const apiConfig = {
-				baseUrl:
-					process.env.VITE_APP_API_URL || "http://localhost:3000",
-				apiPath: `/api/users/discord/${userId}`,
-				hasApiKey: !!process.env.BACKEND_API_KEY,
-				apiKeyLength: process.env.BACKEND_API_KEY?.length,
-			};
-			logger.info({ apiConfig }, "API client configuration");
-
 			// Check if the user already exists
 			const userResponse = await client.getUserByDiscordId({
 				discordUserId: userId,
@@ -145,19 +135,7 @@ export async function handleVerifyCommand(
 				return;
 			}
 
-			// Ensure the URL has the correct format
-			let verificationUrl = `${publicFrontendUrl}`;
-			if (verificationUrl.endsWith("/")) {
-				verificationUrl = `${verificationUrl}?verificationId=${verificationId}`;
-			} else {
-				verificationUrl = `${verificationUrl}/?verificationId=${verificationId}`;
-			}
-
-			// Log the verification URL (strip the ID for security)
-			logger.info(
-				{ verificationUrlBase: verificationUrl.split("?")[0] },
-				"Created verification URL"
-			);
+			const verificationUrl = `${publicFrontendUrl}/?verificationId=${verificationId}`;
 
 			// Create a button with the verification link
 			const verifyButton = new ButtonBuilder()
@@ -181,22 +159,7 @@ export async function handleVerifyCommand(
 				"Created verification session for user"
 			);
 		} catch (error: any) {
-			logger.error(
-				{
-					error,
-					errorMessage: error.message,
-					stack: error.stack,
-					code: error.code,
-					status: error.status,
-					config: error.config,
-					baseUrl:
-						process.env.VITE_APP_API_URL || "http://localhost:3000",
-					backendApiKey: process.env.BACKEND_API_KEY
-						? "present"
-						: "missing",
-				},
-				"Error handling passport verify command"
-			);
+			logger.error(error, "Error handling passport verify command");
 
 			await interaction.reply({
 				content:
@@ -205,22 +168,7 @@ export async function handleVerifyCommand(
 			});
 		}
 	} catch (error: any) {
-		logger.error(
-			{
-				error,
-				errorMessage: error.message,
-				stack: error.stack,
-				code: error.code,
-				status: error.status,
-				config: error.config,
-				baseUrl:
-					process.env.VITE_APP_API_URL || "http://localhost:3000",
-				backendApiKey: process.env.BACKEND_API_KEY
-					? "present"
-					: "missing",
-			},
-			"Error handling passport verify command"
-		);
+		logger.error(error, "Error handling passport verify command");
 
 		await interaction.reply({
 			content:

tooling/sparta/terraform/main.tf

@@ -492,7 +492,7 @@ resource "aws_ecs_task_definition" "sparta_api" {
         { name = "L1_CHAIN_ID", value = var.l1_chain_id },
         { name = "LOG_LEVEL", value = var.log_level },
         { name = "LOG_PRETTY_PRINT", value = var.log_pretty_print ? "true" : "false" },
-        { name = "VITE_APP_API_URL", value = "http://${aws_lb.sparta_alb.dns_name}/api" },
+        { name = "VITE_APP_API_URL", value = "http://${aws_lb.sparta_alb.dns_name}" },
         { name = "CORS_ALLOWED_ORIGINS", value = "http://${aws_lb.sparta_alb.dns_name}" },
         { name = "USERS_TABLE_NAME", value = aws_dynamodb_table.sparta_users.name },
         { name = "NODE_OPERATORS_TABLE_NAME", value = aws_dynamodb_table.sparta_node_operators.name }