Skip to content

Commit 79a1c62

Browse files
committed
Add concern on simulation times.
1 parent 93a3422 commit 79a1c62

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

in-progress/6973-refactor-base-contract-interaction.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1023,6 +1023,10 @@ export class BinarySearchGasEstimator implements GasEstimator {
10231023

10241024
### Concerns
10251025

1026+
#### Long time to simulate for gas estimation
1027+
1028+
The binary search proposed in the gas estimation algorithm could add a lot of time needed for simulation. If/when we find this to be the case, we could impose an interface on FPCs to provide more information around how much gas the use of that FPC is going to cost, though the exact mechanism here is a bit unclear.
1029+
10261030
#### `UserRequest` is a kitchen sink
10271031

10281032
The `UserRequest` object is a bit of a kitchen sink. It might be better to have a `DeployRequest`, `CallRequest`, etc. that extends `UserRequest`.

0 commit comments

Comments
 (0)