Updated linter to golangci-lint (#13)

* Updated linter to golangci-lint

* Removed support for go1.9 and added for go1.12

Author: thspinto

.circleci/config.yml

@@ -23,10 +23,6 @@ references:
 
 version: 2
 jobs:
-  go-1.9:
-    <<: *defaults
-    docker:
-      - image: circleci/golang:1.9
   go-1.10:
     <<: *defaults
     docker:
@@ -35,11 +31,15 @@ jobs:
     <<: *defaults
     docker:
       - image: circleci/golang:1.11
+  go-1.12:
+    <<: *defaults
+    docker:
+      - image: circleci/golang:1.12
 
 workflows:
   version: 2
   test-all-go-versions:
     jobs:
-    - go-1.9
     - go-1.10
-    - go-1.11
+    - go-1.11
+    - go-1.12

.golangci.yml

@@ -0,0 +1,20 @@
+run:
+  skip-dirs:
+    - vendor$
+
+linters:
+  enable:
+    - deadcode
+    - unconvert
+    - errcheck
+    - vet
+    - vetshadow
+    - golint
+    - gosimple
+    - misspell
+
+issues:
+  exclude-rules:
+    - path: keycloak/service\.go
+      linters:
+        - structcheck

.gometalinter.json

@@ -19,7 +19,7 @@ CI_TEST_REPORTS ?= /tmp/test-results
 init-ci:
 	@echo "$(OK_COLOR)==> Installing minimal build requirements$(NO_COLOR)"
 	dep ensure -v
-	curl -L https://git.io/vp6lP | sh
+	curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh
 	go get -u github.com/jstemmer/go-junit-report
 
 .PHONY: init
@@ -44,8 +44,7 @@ generate:
 .PHONY: lint
 lint:
 	@echo "$(OK_COLOR)==> Linting$(NO_COLOR)$(NO_COLOR)"
-	@go list -f '{{.Dir}}' ./... | grep -v 'vendor' | \
-	xargs gometalinter
+	./bin/golangci-lint run
 
 # Test
 .PHONY: test
@@ -104,7 +103,7 @@ test-circle:
 .PHONY: lint-ci
 lint-ci:
 	@echo "$(OK_COLOR)==> Running CI lint$(NO_COLOR)"
-	go list -f '{{.Dir}}' ./... | grep -v 'vendor' | xargs gometalinter --json > lint.json
+	/bin/golangci-lint run --out-format json > lint.json
 
 # Quick test for rapid dev-feedback cycles
 .PHONY: qt

Makefile

@@ -18,7 +18,7 @@ func ExampleConfig_Client() {
 	client := config.Client(context.Background())
 
 	// This will make an authenticated request
-	client.Get("https://keycloak.local/auth/admin/realms/master/users?username=keycloak-admin")
+	_, _ = client.Get("https://keycloak.local/auth/admin/realms/master/users?username=keycloak-admin")
 }
 
 func ExampleConfig_Client_client_credentials() {
@@ -32,5 +32,5 @@ func ExampleConfig_Client_client_credentials() {
 	client := config.Client(context.Background())
 
 	// This will make an authenticated request
-	client.Get("https://keycloak.local/auth/admin/realms/master/users?username=keycloak-admin")
+	_, _ = client.Get("https://keycloak.local/auth/admin/realms/master/users?username=keycloak-admin")
 }

keycloak/auth/auth_example_test.go

@@ -13,7 +13,7 @@ import (
 
 func ExampleNewUserService() {
 	userService := NewUserService(&Client{})
-	userService.Create(context.TODO(), "my-realm", &UserRepresentation{})
+	_, _ = userService.Create(context.TODO(), "my-realm", &UserRepresentation{})
 }
 
 type userServiceTests struct {
@@ -80,7 +80,7 @@ func (suite *userServiceTests) TestUserServiceCreateUserFailure() {
 
 	suite.True(ok)
 	suite.NotNil(actualError)
-	//suite.Equal(500, actualError.Code)
+	suite.Equal(500, actualError.Code)
 }
 
 func (suite *userServiceTests) TestUserServiceUpdateUser() {