add visibility handling

Author: brecht.vermeersch

src/AzureBlobStorageAdapter.php

@@ -33,13 +33,17 @@
 
 class AzureBlobStorageAdapter implements FilesystemAdapter, ChecksumProvider, TemporaryUrlGenerator
 {
+    public const ON_VISIBILITY_THROW_ERROR = 'throw';
+    public const ON_VISIBILITY_IGNORE = 'ignore';
+
     private readonly MimeTypeDetector $mimeTypeDetector;
     private readonly PathPrefixer $prefixer;
 
     public function __construct(
         private readonly BlobContainerClient $containerClient,
         string $prefix = "",
         ?MimeTypeDetector $mimeTypeDetector = null,
+        private readonly string $visibilityHandling = self::ON_VISIBILITY_THROW_ERROR,
     ) {
         $this->prefixer = new PathPrefixer($prefix);
         $this->mimeTypeDetector = $mimeTypeDetector ?? new FinfoMimeTypeDetector();
@@ -165,7 +169,9 @@ public function createDirectory(string $path, Config $config): void
 
     public function setVisibility(string $path, string $visibility): void
     {
-        throw UnableToSetVisibility::atLocation($path, "Azure does not support this operation.");
+        if ($this->visibilityHandling === self::ON_VISIBILITY_THROW_ERROR) {
+            throw UnableToSetVisibility::atLocation($path, 'Azure does not support this operation.');
+        }
     }
 
     public function visibility(string $path): FileAttributes

tests/AzureBlobStorageTest.php

@@ -10,7 +10,9 @@
 use League\Flysystem\AdapterTestUtilities\FilesystemAdapterTestCase;
 use League\Flysystem\Config;
 use League\Flysystem\FilesystemAdapter;
+use League\Flysystem\UnableToSetVisibility;
 use League\Flysystem\Visibility;
+use PHPUnit\Framework\Attributes\Test;
 
 class AzureBlobStorageTest extends FilesystemAdapterTestCase
 {
@@ -163,4 +165,29 @@ public function file_exists_on_directory_is_false(): void
             $this->assertFalse($adapter->fileExists('test'));
         });
     }
+
+    #[Test]
+    public function setting_visibility_can_be_ignored_not_supported(): void
+    {
+        $this->givenWeHaveAnExistingFile('some-file.md');
+        $this->expectNotToPerformAssertions();
+
+        $adapter = new AzureBlobStorageAdapter(
+            self::createContainerClient(),
+            visibilityHandling: AzureBlobStorageAdapter::ON_VISIBILITY_IGNORE,
+        );
+
+        $adapter->setVisibility('some-file.md', 'public');
+    }
+
+    #[Test]
+    public function setting_visibility_causes_errors(): void
+    {
+        $this->givenWeHaveAnExistingFile('some-file.md');
+        $adapter = $this->adapter();
+
+        $this->expectException(UnableToSetVisibility::class);
+
+        $adapter->setVisibility('some-file.md', 'public');
+    }
 }