Merge pull request #127 from SQLPlayer/bug125

Fixed `Test-AdfCode` when validating empty factory #125

Author: NowinskiK

README.md

@@ -23,7 +23,8 @@ The main advantage of the module is the ability to publish all the Azure Data Fa
 * Tokenisation in config file allows replace any value by Environment Variable or Variable from DevOps Pipeline
   * (new!) Allows to define multiple file (objects) by wildcarding
 * Global Parameters
-
+* Support for Managed VNET and Managed Private Endpoint (new!)
+  
 The following features coming in the future:
 * Build function to support validation of files, dependencies and config
 * Unit Tests of selected Pipelines and Linked Services

azure.datafactory.tools.psd1

@@ -4,6 +4,9 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
+## [0.75.0] - 2021-08-05
+* Fixed `Test-AdfCode` when validating empty factory #125
+
 ## [0.74.0] - 2021-08-03
 * Cmdlet `Test-AdfCode` validates config files #62
 * Support configuration for Managed Private Endpoint #95

changelog.md

@@ -84,7 +84,7 @@ function Test-AdfCode {
         }
     }
 
-    if ($adf.Factories.Count -gt 0) {
+    if ($adf.Factories.Count -gt 0 -and (Get-Member -InputObject $adf.Factories[0].Body -name "properties" -Membertype "Properties")) {
         Get-Member -InputObject $adf.Factories[0].Body.properties.globalParameters -Membertype "NoteProperty" | ForEach-Object {
             [string] $name = $_.Name
             if ($name.Contains('-')) {
@@ -98,9 +98,11 @@ function Test-AdfCode {
     Write-Host "=== Validating config files ..."
     if (!$ConfigPath) {
         $filePattern = Join-Path -Path $adf.Location -ChildPath 'deployment\*' 
+        if (!(Test-Path $filePattern)) { $filePattern = $null }
     } else {
         $filePattern = $ConfigPath -split ','
     }
+
     $files = Get-ChildItem -Path $filePattern -Include '*.csv','*.json'
     $err = $null
     $adf.PublishOptions.FailsWhenConfigItemNotFound = $True

public/Test-AdfCode.ps1

@@ -0,0 +1,25 @@
+BeforeDiscovery {
+    $ModuleRootPath = $PSScriptRoot | Split-Path -Parent
+    $moduleManifestName = 'azure.datafactory.tools.psd1'
+    $moduleManifestPath = Join-Path -Path $ModuleRootPath -ChildPath $moduleManifestName
+    
+    Import-Module -Name $moduleManifestPath -Force -Verbose:$false
+}
+
+InModuleScope azure.datafactory.tools {
+    $testHelperPath = $PSScriptRoot | Join-Path -ChildPath 'TestHelper'
+    Import-Module -Name $testHelperPath -Force
+
+    # Variables for use in tests
+
+    Describe 'Test-AdfCode' -Tag 'Unit' {
+        It 'Should run successfully even for empty factory' {
+            $DataFactoryName = "emptyFactory"
+            $RootFolder = Join-Path -Path $PSScriptRoot -ChildPath $DataFactoryName
+            { Test-AdfCode $RootFolder } | Should -Not -Throw
+        }
+
+        
+
+    } 
+}

test/Test-AdfCode.Tests.ps1

@@ -0,0 +1,4 @@
+{
+	"name": "emptyFactory",
+	"location": "EastUS"
+}