Replace policy_xml_replacement with read_policy_xml

Resolves #16

Author: simonkurtz-MSFT

infrastructure/afd-apim/create.ipynb

@@ -45,7 +45,7 @@
     "# 3) Define the APIs and their operations and policies\n",
     "\n",
     "# Policies\n",
-    "hello_world_policy_xml  = utils.policy_xml_replacement(HELLO_WORLD_XML_POLICY_PATH)\n",
+    "hello_world_policy_xml  = utils.read_policy_xml(HELLO_WORLD_XML_POLICY_PATH)\n",
     "\n",
     "# Hello World (Root)\n",
     "api_hwroot_get  = GET_APIOperation('This is a GET for API 1', hello_world_policy_xml)\n",

samples/general/create.ipynb

@@ -66,7 +66,7 @@
     "api2 = API('API2', 'API 2', '/api2', 'This is API 2', operations = [api2_post], tags = tags)\n",
     "\n",
     "# Request Headers\n",
-    "rh_policy_xml = utils.policy_xml_replacement(REQUEST_HEADERS_XML_POLICY_PATH)\n",
+    "rh_policy_xml = utils.read_policy_xml(REQUEST_HEADERS_XML_POLICY_PATH)\n",
     "rh_get = GET_APIOperation('Gets the request headers for the current request and returns them. Great for troubleshooting.', rh_policy_xml)\n",
     "rh = API('requestheaders', 'Request Headers', '/request-headers', 'API for request headers', operations = [rh_get], tags = tags)\n",
     "\n",

shared/python/utils.py

@@ -306,26 +306,6 @@ def does_resource_group_exist(rg_name: str) -> bool:
     output = run(f"az group show --name {rg_name}", print_output = False, print_errors = False)
     return output.success
 
-def policy_xml_replacement(policy_xml_filepath: str) -> str:
-    """
-    Read and return the contents of a policy XML file.
-
-    Args:
-        policy_xml_filepath (str): Path to the policy XML file.
-
-    Returns:
-        str: Contents of the policy XML file.
-    """
-
-    # Read the specified policy XML file
-    with open(policy_xml_filepath, 'r') as policy_xml_file:
-        policy_template_xml = policy_xml_file.read()
-
-    # TODO: Perform any replacements here
-
-    # Convert the XML to JSON format
-    return policy_template_xml
-
 def read_policy_xml(policy_xml_filepath: str) -> str:
     """
     Read and return the contents of a policy XML file.

tests/python/test_utils.py

@@ -162,15 +162,6 @@ def test_read_policy_xml_empty_file(monkeypatch):
     result = utils.read_policy_xml('empty.xml')
     assert result == ''
 
-# ------------------------------
-#    policy_xml_replacement
-# ------------------------------
-
-def test_policy_xml_replacement(monkeypatch):
-    m = mock_open(read_data='<xml>foo</xml>')
-    monkeypatch.setattr(builtins, 'open', m)
-    assert utils.policy_xml_replacement('dummy.xml') == '<xml>foo</xml>'
-
 # ------------------------------
 #    cleanup_resources (smoke)
 # ------------------------------