Skip to content

Commit c8ba82d

Browse files
Update Bicep version, correct protocol casing in NSG
1 parent e046722 commit c8ba82d

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

infrastructure/afd-apim-pe/main.bicep

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ var appInsightsInstrumentationKey = appInsightsModule.outputs.instrumentationKey
7878
// We also do not presently use a custom route table for the subnets, which is a best practice for production workloads.
7979

8080
// https://learn.microsoft.com/azure/templates/microsoft.network/networksecuritygroups
81-
resource nsg 'Microsoft.Network/networkSecurityGroups@2024-05-01' = {
81+
resource nsg 'Microsoft.Network/networkSecurityGroups@2025-01-01' = {
8282
name: 'nsg-default'
8383
location: location
8484
}
@@ -170,6 +170,7 @@ module acaModule1 '../../shared/bicep/modules/aca/v1/containerapp.bicep' = if (u
170170
environmentId: acaEnvModule!.outputs.environmentId
171171
}
172172
}
173+
173174
module acaModule2 '../../shared/bicep/modules/aca/v1/containerapp.bicep' = if (useACA) {
174175
name: 'acaModule-2'
175176
params: {

infrastructure/appgw-apim-pe/main.bicep

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,13 @@ var appInsightsId = appInsightsModule.outputs.id
9797
var appInsightsInstrumentationKey = appInsightsModule.outputs.instrumentationKey
9898

9999
// 3. Virtual Network and Subnets
100-
resource nsgDefault 'Microsoft.Network/networkSecurityGroups@2024-05-01' = {
100+
resource nsgDefault 'Microsoft.Network/networkSecurityGroups@2025-01-01' = {
101101
name: 'nsg-default'
102102
location: location
103103
}
104104

105105
// App Gateway needs a specific NSG
106-
resource nsgAppGw 'Microsoft.Network/networkSecurityGroups@2024-05-01' = {
106+
resource nsgAppGw 'Microsoft.Network/networkSecurityGroups@2025-01-01' = {
107107
name: 'nsg-appgw'
108108
location: location
109109
properties: {
@@ -112,7 +112,7 @@ resource nsgAppGw 'Microsoft.Network/networkSecurityGroups@2024-05-01' = {
112112
name: 'AllowGatewayManagerInbound'
113113
properties: {
114114
description: 'Allow Azure infrastructure communication'
115-
protocol: 'Tcp'
115+
protocol: 'TCP'
116116
sourcePortRange: '*'
117117
destinationPortRange: '65200-65535'
118118
sourceAddressPrefix: 'GatewayManager'
@@ -126,7 +126,7 @@ resource nsgAppGw 'Microsoft.Network/networkSecurityGroups@2024-05-01' = {
126126
name: 'AllowHTTPSInbound'
127127
properties: {
128128
description: 'Allow HTTPS traffic'
129-
protocol: 'Tcp'
129+
protocol: 'TCP'
130130
sourcePortRange: '*'
131131
destinationPortRange: '443'
132132
sourceAddressPrefix: '*'
@@ -328,6 +328,7 @@ module acaModule1 '../../shared/bicep/modules/aca/v1/containerapp.bicep' = if (u
328328
environmentId: acaEnvModule!.outputs.environmentId
329329
}
330330
}
331+
331332
module acaModule2 '../../shared/bicep/modules/aca/v1/containerapp.bicep' = if (useACA) {
332333
name: 'acaModule-2'
333334
params: {

0 commit comments

Comments
 (0)