fixing deployment issues

Author: mawasile

cicd/network.storage.tf

@@ -9,7 +9,7 @@ resource "azurerm_subnet" "storage" {
   service_endpoints = []
 
   # Enable private endpoint network policies
-  private_endpoint_network_policies = "Enabled"
+  private_endpoint_network_policies = "Disabled"
 }
 
 # Create Network Security Group
@@ -59,29 +59,29 @@ resource "azurerm_network_security_group" "storage" {
   }
 
   # Deny all other inbound traffic
-  security_rule {
-    name                       = "DenyAllInbound"
-    priority                   = 4096
-    direction                  = "Inbound"
-    access                     = "Deny"
-    protocol                   = "*"
-    source_port_range          = "*"
-    destination_port_range     = "*"
-    source_address_prefix      = "*"
-    destination_address_prefix = "*"
-  }
-  # Deny all other outbound traffic
-  security_rule {
-    name                       = "DenyAllOutbound"
-    priority                   = 4096
-    direction                  = "Outbound"
-    access                     = "Deny"
-    protocol                   = "*"
-    source_port_range          = "*"
-    destination_port_range     = "*"
-    source_address_prefix      = "*"
-    destination_address_prefix = "*"
-  }
+  # security_rule {
+  #   name                       = "DenyAllInbound"
+  #   priority                   = 4096
+  #   direction                  = "Inbound"
+  #   access                     = "Deny"
+  #   protocol                   = "*"
+  #   source_port_range          = "*"
+  #   destination_port_range     = "*"
+  #   source_address_prefix      = "*"
+  #   destination_address_prefix = "*"
+  # }
+  # # Deny all other outbound traffic
+  # security_rule {
+  #   name                       = "DenyAllOutbound"
+  #   priority                   = 4096
+  #   direction                  = "Outbound"
+  #   access                     = "Deny"
+  #   protocol                   = "*"
+  #   source_port_range          = "*"
+  #   destination_port_range     = "*"
+  #   source_address_prefix      = "*"
+  #   destination_address_prefix = "*"
+  # }
 }
 
 # Associate NSG with Subnet

docs/cicd.md

@@ -13,7 +13,7 @@ All infrastructure for CI/CD lives under `cicd/` and can be customized to meet y
 
 ## Prerequisites
 
-- Working local environment of this template. If you do not have one, Follow the step by step instructions for setting up your [**Local Environment**](./../readme.md).
+- Working local environment of this template. If you do not have one, Follow the step by step instructions for setting up your [**Local Environment**](../README.md#local-environment)
 - An Azure subscription with either User Access Administrator or Owner permissions to create workload identity resources like service principal, and OIDC to be used by the GitHub Actions.
 - GitHub CLI (`gh`) installed and authenticated to trigger the bootstrap workflow from your terminal.
 

infra/modules/copilot_studio/power_platform_users.tf

@@ -41,5 +41,5 @@ resource "powerplatform_user" "new_non_dataverse_user" {
   environment_id = local.power_platform_environment_id
   security_roles = local.security_role_ids
   aad_id         = each.value
-  // disable_delete = false
+  disable_delete = false
 }