Skip to content

Commit 83455ba

Browse files
fix(.github): address Copilot review comments on PR #22
- link-lang-check: remove unused SoftFail param splatting - link-lang-check: correct env var LINK_LANG_CHECK_FAILED to LINK_LANG_FAILED - pr-validation: add pull-requests: write for dependency-review job - dependency-review: remove duplicate pull_request trigger, add harden-runner - package.json: use exact versions (remove ^ prefix) - codeql-analysis: clarify time format to 04:00 UTC 🔧 - Generated by Copilot
1 parent 7ef5901 commit 83455ba

File tree

5 files changed

+12
-14
lines changed

5 files changed

+12
-14
lines changed

.github/workflows/codeql-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: CodeQL Security Analysis
22

33
on:
44
schedule:
5-
# Weekly scan: Sundays at 4 AM UTC
5+
# Weekly scan: Sundays at 04:00 UTC
66
- cron: '0 4 * * 0'
77
workflow_call:
88

.github/workflows/dependency-review.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
name: Dependency Review
22

33
on:
4-
pull_request:
5-
branches: [main, develop]
64
workflow_call:
75

86
permissions:
@@ -18,6 +16,11 @@ jobs:
1816
pull-requests: write
1917

2018
steps:
19+
- name: Harden Runner
20+
uses: step-security/harden-runner@95d9a5deda9de15063e7595e9719c11c38c90ae2 # v2.10.2
21+
with:
22+
egress-policy: audit
23+
2124
- name: Checkout code
2225
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v4.2.2
2326
with:

.github/workflows/link-lang-check.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,7 @@ jobs:
3737
- name: Run Link Language Check
3838
shell: pwsh
3939
run: |
40-
$params = @{}
41-
42-
if ('${{ inputs.soft-fail }}' -eq 'true') {
43-
$params['SoftFail'] = $true
44-
}
45-
46-
& scripts/linting/Invoke-LinkLanguageCheck.ps1 @params
40+
& scripts/linting/Invoke-LinkLanguageCheck.ps1
4741
continue-on-error: ${{ inputs.soft-fail }}
4842

4943
- name: Upload link language check results
@@ -58,7 +52,7 @@ jobs:
5852
if: ${{ !inputs.soft-fail }}
5953
shell: pwsh
6054
run: |
61-
if ($env:LINK_LANG_CHECK_FAILED -eq 'true') {
55+
if ($env:LINK_LANG_FAILED -eq 'true') {
6256
Write-Host "Link language check failed and soft-fail is false. Failing the job."
6357
exit 1
6458
}

.github/workflows/pr-validation.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ on:
1111

1212
permissions:
1313
contents: read
14-
pull-requests: read
14+
pull-requests: write
1515

1616
jobs:
1717
# Spell checking using cspell
@@ -64,3 +64,4 @@ jobs:
6464
uses: ./.github/workflows/dependency-review.yml
6565
permissions:
6666
contents: read
67+
pull-requests: write

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
"devDependencies": {
1717
"cspell": "9.4.0",
1818
"markdown-link-check": "3.14.2",
19-
"markdown-table-formatter": "^1.6.0",
20-
"markdownlint-cli2": "^0.19.1"
19+
"markdown-table-formatter": "1.6.0",
20+
"markdownlint-cli2": "0.19.1"
2121
},
2222
"repository": {
2323
"type": "git",

0 commit comments

Comments
 (0)