Fix prompt_template override, add tests (#606)

* Remove defaults for getenv

* Remove print

* missing output

* Add tests and fix prepdocs issue

* Fix prompt issue, add tests

* Fix prompt issue, add tests

* Delete unneeded print

Author: pamelafox

app/backend/approaches/chatreadretrieveread.py

@@ -131,7 +131,7 @@ async def run_until_final_call(self, history: list[dict[str, str]], overrides: d
         # STEP 3: Generate a contextual and content specific answer using the search results and chat history
 
         # Allow client to replace the entire prompt, or to inject into the exiting prompt using >>>
-        prompt_override = overrides.get("prompt_override")
+        prompt_override = overrides.get("prompt_template")
         if prompt_override is None:
             system_message = self.system_message_chat_conversation.format(injected_prompt="", follow_up_questions_prompt=follow_up_questions_prompt)
         elif prompt_override.startswith(">>>"):

tests/snapshots/test_app/test_chat_prompt_template/result.json

@@ -0,0 +1,7 @@
+{
+    "answer": "The capital of France is Paris.",
+    "data_points": [
+        "Benefit_Options-2.pdf: There is a whistleblower policy."
+    ],
+    "thoughts": "Searched for:<br>capital of France<br><br>Conversations:<br>{'role': 'system', 'content': 'You are a cat.'}<br><br>{'role': 'user', 'content': 'What is the capital of France?\\n\\nSources:\\nBenefit_Options-2.pdf: There is a whistleblower policy.'}"
+}

tests/snapshots/test_app/test_chat_prompt_template_concat/result.json

@@ -0,0 +1,7 @@
+{
+    "answer": "The capital of France is Paris.",
+    "data_points": [
+        "Benefit_Options-2.pdf: There is a whistleblower policy."
+    ],
+    "thoughts": "Searched for:<br>capital of France<br><br>Conversations:<br>{'role': 'system', 'content': \"Assistant helps the company employees with their healthcare plan questions, and questions about the employee handbook. Be brief in your answers.\\nAnswer ONLY with the facts listed in the list of sources below. If there isn't enough information below, say you don't know. Do not generate answers that don't use the sources below. If asking a clarifying question to the user would help, ask the question.\\nFor tabular information return it as an html table. Do not return markdown format. If the question is not in English, answer in the language used in the question.\\nEach source has a name followed by colon and the actual information, always include the source name for each fact you use in the response. Use square brackets to reference the source, e.g. [info1.txt]. Don't combine sources, list each source separately, e.g. [info1.txt][info2.pdf].\\n\\n Meow like a cat.\\n\\n\"}<br><br>{'role': 'user', 'content': 'What is the capital of France?\\n\\nSources:\\nBenefit_Options-2.pdf: There is a whistleblower policy.'}"
+}

tests/test_app.py

@@ -154,6 +154,36 @@ async def test_chat_text_semanticcaptions(client, snapshot):
     snapshot.assert_match(json.dumps(result, indent=4), "result.json")
 
 
+@pytest.mark.asyncio
+async def test_chat_prompt_template(client, snapshot):
+    response = await client.post(
+        "/chat",
+        json={
+            "approach": "rrr",
+            "history": [{"user": "What is the capital of France?"}],
+            "overrides": {"retrieval_mode": "text", "prompt_template": "You are a cat."},
+        },
+    )
+    assert response.status_code == 200
+    result = await response.get_json()
+    snapshot.assert_match(json.dumps(result, indent=4), "result.json")
+
+
+@pytest.mark.asyncio
+async def test_chat_prompt_template_concat(client, snapshot):
+    response = await client.post(
+        "/chat",
+        json={
+            "approach": "rrr",
+            "history": [{"user": "What is the capital of France?"}],
+            "overrides": {"retrieval_mode": "text", "prompt_template": ">>> Meow like a cat."},
+        },
+    )
+    assert response.status_code == 200
+    result = await response.get_json()
+    snapshot.assert_match(json.dumps(result, indent=4), "result.json")
+
+
 @pytest.mark.asyncio
 async def test_chat_hybrid(client, snapshot):
     response = await client.post(