Skip to content

Commit 4a0a04a

Browse files
committed
aca main.bicep polish
1 parent c0dd2f2 commit 4a0a04a

File tree

2 files changed

+14
-43
lines changed

2 files changed

+14
-43
lines changed

deploy/aca/infra/main.bicep

Lines changed: 13 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -83,18 +83,9 @@ param apiAppExists bool = false
8383
param webAppExists bool = false
8484
param indexerAppExists bool = false
8585

86-
// Used for the optional login and document level access control system
87-
param useAuthentication bool = false
88-
param serverAppId string = ''
89-
@secure()
90-
param serverAppSecret string = ''
91-
param clientAppId string = ''
9286

93-
// Used for optional CORS support for alternate frontends
94-
param allowedOrigin string = '' // should start with https://, shouldn't end with a /
95-
96-
@description('Id of the user or app to assign application roles')
97-
param principalId string = ''
87+
@description('Id of the user to assign application roles for CLI to ingest documents')
88+
param userPrincipalId string = ''
9889

9990
@description('Use Application Insights for monitoring and performance tracing')
10091
param useApplicationInsights bool = false
@@ -271,6 +262,10 @@ module indexer './app/indexer.bicep' = {
271262
name: 'AZURE_SERVICEBUS_NAMESPACE'
272263
value: servicebusQueue.outputs.name
273264
}
265+
{
266+
name: 'AZURE_SERVICEBUS_QUEUE_NAME'
267+
value: queueName
268+
}
274269
]
275270
}
276271
}
@@ -419,7 +414,7 @@ module openAiRoleUser '../../shared/security/role.bicep' = if (openAiHost == 'az
419414
scope: openAiResourceGroup
420415
name: 'openai-role-user'
421416
params: {
422-
principalId: principalId
417+
principalId: userPrincipalId
423418
roleDefinitionId: '5e0bd9bd-7b93-4f28-af87-19fc36ad61bd'
424419
principalType: 'User'
425420
}
@@ -429,7 +424,7 @@ module formRecognizerRoleUser '../../shared/security/role.bicep' = {
429424
scope: formRecognizerResourceGroup
430425
name: 'formrecognizer-role-user'
431426
params: {
432-
principalId: principalId
427+
principalId: userPrincipalId
433428
roleDefinitionId: 'a97b65f3-24c7-4388-baec-2e87135dc908'
434429
principalType: 'User'
435430
}
@@ -439,7 +434,7 @@ module storageRoleUser '../../shared/security/role.bicep' = {
439434
scope: storageResourceGroup
440435
name: 'storage-role-user'
441436
params: {
442-
principalId: principalId
437+
principalId: userPrincipalId
443438
roleDefinitionId: '2a2b9908-6ea1-4ae2-8e65-a410df84e7d1'
444439
principalType: 'User'
445440
}
@@ -449,7 +444,7 @@ module storageContribRoleUser '../../shared/security/role.bicep' = {
449444
scope: storageResourceGroup
450445
name: 'storage-contribrole-user'
451446
params: {
452-
principalId: principalId
447+
principalId: userPrincipalId
453448
roleDefinitionId: 'ba92f5b4-2d11-453d-a403-e96b0029c9fe'
454449
principalType: 'User'
455450
}
@@ -459,7 +454,7 @@ module searchRoleUser '../../shared/security/role.bicep' = {
459454
scope: searchServiceResourceGroup
460455
name: 'search-role-user'
461456
params: {
462-
principalId: principalId
457+
principalId: userPrincipalId
463458
roleDefinitionId: '1407120a-92aa-4202-b7e9-c0e197c71c8f'
464459
principalType: 'User'
465460
}
@@ -469,7 +464,7 @@ module searchContribRoleUser '../../shared/security/role.bicep' = {
469464
scope: searchServiceResourceGroup
470465
name: 'search-contrib-role-user'
471466
params: {
472-
principalId: principalId
467+
principalId: userPrincipalId
473468
roleDefinitionId: '8ebe5a00-799e-43f5-93ac-243d3dce84a7'
474469
principalType: 'User'
475470
}
@@ -479,7 +474,7 @@ module searchSvcContribRoleUser '../../shared/security/role.bicep' = {
479474
scope: searchServiceResourceGroup
480475
name: 'search-svccontrib-role-user'
481476
params: {
482-
principalId: principalId
477+
principalId: userPrincipalId
483478
roleDefinitionId: '7ca78c08-252a-4471-8644-bb5ff32d4ba0'
484479
principalType: 'User'
485480
}

deploy/aca/infra/main.parameters.json

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"location": {
1212
"value": "${AZURE_LOCATION}"
1313
},
14-
"principalId": {
14+
"userPrincipalId": {
1515
"value": "${AZURE_PRINCIPAL_ID}"
1616
},
1717
"openAiServiceName": {
@@ -77,32 +77,8 @@
7777
"embeddingDeploymentName": {
7878
"value": "${AZURE_OPENAI_EMB_DEPLOYMENT=embedding}"
7979
},
80-
"openAiHost":{
81-
"value": "${OPENAI_HOST=azure}"
82-
},
83-
"openAiApiKey": {
84-
"value": "${OPENAI_API_KEY}"
85-
},
86-
"openAiApiOrganization": {
87-
"value": "${OPENAI_ORGANIZATION}"
88-
},
8980
"useApplicationInsights": {
9081
"value": "${AZURE_USE_APPLICATION_INSIGHTS=true}"
91-
},
92-
"useAuthentication": {
93-
"value": "${AZURE_USE_AUTHENTICATION=false}"
94-
},
95-
"serverAppId": {
96-
"value": "${AZURE_SERVER_APP_ID}"
97-
},
98-
"serverAppSecret": {
99-
"value": "${AZURE_SERVER_APP_SECRET}"
100-
},
101-
"clientAppId": {
102-
"value": "${AZURE_CLIENT_APP_ID}"
103-
},
104-
"allowedOrigin": {
105-
"value": "${ALLOWED_ORIGIN}"
10682
}
10783
}
10884
}

0 commit comments

Comments
 (0)