Skip to content

Commit feed2a2

Browse files
authored
Merge pull request #14 from johnoliver/fix-deploy
Fix a number of azd issues and docs
2 parents 8a615d4 + 3298753 commit feed2a2

File tree

4 files changed

+9
-1
lines changed

4 files changed

+9
-1
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,13 @@ If you already have existing Azure resources, you can re-use those by setting `a
101101
#### Existing resource group
102102

103103
1. Run `azd env set AZURE_RESOURCE_GROUP {Name of existing resource group}`
104-
1. Run `azd env set AZURE_LOCATION {Location of existing resource group}`
104+
1. Run `azd env set AZURE_LOCATION {Location of existing resource group (i.e eastus2)}`
105105

106106
#### Existing OpenAI resource
107107

108108
1. Run `azd env set AZURE_OPENAI_SERVICE {Name of existing OpenAI service}`
109109
1. Run `azd env set AZURE_OPENAI_RESOURCE_GROUP {Name of existing resource group that OpenAI service is provisioned to}`
110+
1. Run `azd env set AZURE_OPENAI_SERVICE_LOCATION {Location of existing resource (i.e eastus2)}`. Only needed if your OpenAI resource is in a different location than the one you'll pick for the `azd up` step.
110111
1. Run `azd env set AZURE_OPENAI_CHATGPT_DEPLOYMENT {Name of existing ChatGPT deployment}`. Only needed if your ChatGPT deployment is not the default 'chat'.
111112
1. Run `azd env set AZURE_OPENAI_EMB_DEPLOYMENT {Name of existing GPT embedding deployment}`. Only needed if your embeddings deployment is not the default 'embedding'.
112113

app/backend/mvnw

100644100755
File mode changed.

infra/core/ai/cognitiveservices.bicep

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@ resource account 'Microsoft.CognitiveServices/accounts@2023-05-01' = {
1818
properties: {
1919
customSubDomainName: customSubDomainName
2020
publicNetworkAccess: publicNetworkAccess
21+
networkAcls: {
22+
bypass: 'AzureServices'
23+
defaultAction: 'Allow'
24+
}
2125
}
2226
sku: sku
2327
}

infra/main.parameters.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@
2020
"openAiResourceGroupName": {
2121
"value": "${AZURE_OPENAI_RESOURCE_GROUP}"
2222
},
23+
"openAiResourceGroupLocation": {
24+
"value": "${AZURE_OPENAI_SERVICE_LOCATION}"
25+
},
2326
"openAiSkuName": {
2427
"value": "S0"
2528
},

0 commit comments

Comments
 (0)