Skip to content

Commit 0d0abb0

Browse files
committed
Revert unneeded changes
1 parent d7f070b commit 0d0abb0

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

docs/deploy_private.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,3 +96,7 @@ Deploying with public access disabled adds additional cost to your deployment. P
9696
```bash
9797
azd deploy
9898
```
99+
100+
## Compatibility with other features
101+
102+
* **GitHub Actions / Azure DevOps**: The private access deployment is not compatible with the built-in CI/CD pipelines, as it requires a VPN connection to deploy the app. You could modify the pipeline to only do provisioning, and set up a different deployment strategy for the app.

infra/core/host/container-app-upsert.bicep

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ param name string
33
param location string = resourceGroup().location
44
param tags object = {}
55

6+
67
@description('The number of CPU cores allocated to a single container instance, e.g., 0.5')
78
param containerCpuCoreCount string = '0.5'
89

@@ -28,7 +29,6 @@ param containerRegistryName string
2829
@description('Hostname suffix for container registry. Set when deploying to sovereign clouds')
2930
param containerRegistryHostSuffix string = 'azurecr.io'
3031

31-
3232
@allowed(['http', 'grpc'])
3333
@description('The protocol used by Dapr to connect to the app, e.g., HTTP or gRPC')
3434
param daprAppProtocol string = 'http'

0 commit comments

Comments
 (0)