Skip to content

Commit 466e283

Browse files
committed
updates for GPT4o
1 parent ab73c8c commit 466e283

File tree

2 files changed

+47
-33
lines changed

2 files changed

+47
-33
lines changed

infra/main.bicep

Lines changed: 46 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,9 @@ param speechServiceResourceGroupName string = ''
5757
param speechServiceLocation string = ''
5858
param speechServiceName string = ''
5959
param speechServiceSkuName string // Set in main.parameters.json
60-
param useGPT4V bool = false
60+
param useGPT4v bool = false
61+
param useGPT4 bool = true
62+
param altEmb bool = false
6163

6264
@description('Location for the OpenAI resource group')
6365
@allowed([
@@ -110,32 +112,44 @@ param chatGptModelName string = ''
110112
param chatGptDeploymentName string = ''
111113
param chatGptDeploymentVersion string = ''
112114
param chatGptDeploymentCapacity int = 0
113-
var chatGpt = {
114-
modelName: !empty(chatGptModelName)
115-
? chatGptModelName
116-
: startsWith(openAiHost, 'azure') ? 'gpt-35-turbo' : 'gpt-3.5-turbo'
117-
deploymentName: !empty(chatGptDeploymentName) ? chatGptDeploymentName : 'opensourcerer-completions-35t'
118-
deploymentVersion: !empty(chatGptDeploymentVersion) ? chatGptDeploymentVersion : '0613'
119-
deploymentCapacity: chatGptDeploymentCapacity != 0 ? chatGptDeploymentCapacity : 50
120-
}
121-
122-
param embeddingModelName string = ''
123-
param embeddingDeploymentName string = ''
124-
param embeddingDeploymentVersion string = ''
125-
param embeddingDeploymentCapacity int = 0
126-
param embeddingDimensions int = 0
127-
var embedding = {
128-
modelName: !empty(embeddingModelName) ? embeddingModelName : 'text-embedding-ada-002'
129-
deploymentName: !empty(embeddingDeploymentName) ? embeddingDeploymentName : 'opensourcerer-embeddings'
130-
deploymentVersion: !empty(embeddingDeploymentVersion) ? embeddingDeploymentVersion : '2'
131-
deploymentCapacity: embeddingDeploymentCapacity != 0 ? embeddingDeploymentCapacity : 50
132-
dimensions: embeddingDimensions != 0 ? embeddingDimensions : 1536
133-
}
134115

116+
// To be removed during cleanup now that 4V is no longer the default
135117
param gpt4vModelName string = 'gpt-4o'
136-
param gpt4vDeploymentName string = 'opensourcerer-completions-4o'
118+
param gpt4vDeploymentName string = 'gpt-4o'
137119
param gpt4vModelVersion string = '2024-05-13'
138-
param gpt4vDeploymentCapacity int = 50
120+
param gpt4vDeploymentCapacity int = 10
121+
122+
param gpt4ModelName string = 'gpt-4o'
123+
param gpt4DeploymentName string = 'opensourcerer-completions-4o'
124+
param gpt4ModelVersion string = '2024-05-13'
125+
param gpt4DeploymentCapacity int = 50
126+
127+
var chatGpt = {
128+
modelName: !useGPT4 ? chatGptModelName : gpt4ModelName
129+
deploymentName: !useGPT4 ? chatGptDeploymentName : gpt4DeploymentName
130+
deploymentVersion: !useGPT4 ? chatGptDeploymentVersion : gpt4ModelVersion
131+
deploymentCapacity: !useGPT4 ? chatGptDeploymentCapacity : gpt4DeploymentCapacity
132+
}
133+
134+
param embeddingModelName string = 'text-embedding-ada-002'
135+
param embeddingDeploymentName string = 'opensourcerer-embeddings'
136+
param embeddingDeploymentVersion string = '2'
137+
param embeddingDeploymentCapacity int = 50
138+
param embeddingDimensions int = 1536
139+
140+
param AlternateEmbeddingModelName string = 'text-embedding-3-large'
141+
param AlternateEmbeddingDeploymentName string = 'opensourcerer-embeddings-003'
142+
param AlternateEmbeddingDeploymentVersion string = '1'
143+
param AlternateEmbeddingDeploymentCapacity int = 50
144+
param AlternateEmbeddingDimensions int = 1536
145+
146+
var embedding = {
147+
modelName: !altEmb ? embeddingModelName : AlternateEmbeddingModelName
148+
deploymentName: !altEmb ? embeddingDeploymentName : AlternateEmbeddingDeploymentName
149+
deploymentVersion: !altEmb ? embeddingDeploymentVersion : AlternateEmbeddingDeploymentVersion
150+
deploymentCapacity: !altEmb ? embeddingDeploymentCapacity : AlternateEmbeddingDeploymentCapacity
151+
dimensions: !altEmb ? embeddingDimensions : AlternateEmbeddingDimensions
152+
}
139153

140154
param tenantId string = tenant().tenantId
141155
param authTenantId string = ''
@@ -302,7 +316,7 @@ var appEnvVariables = {
302316
AZURE_SEARCH_INDEX: searchIndexName
303317
AZURE_SEARCH_SERVICE: searchService.outputs.name
304318
AZURE_SEARCH_SEMANTIC_RANKER: actualSearchServiceSemanticRankerLevel
305-
AZURE_VISION_ENDPOINT: useGPT4V ? computerVision.outputs.endpoint : ''
319+
AZURE_VISION_ENDPOINT: useGPT4 ? computerVision.outputs.endpoint : ''
306320
AZURE_SEARCH_QUERY_LANGUAGE: searchQueryLanguage
307321
AZURE_SEARCH_QUERY_SPELLER: searchQuerySpeller
308322
APPLICATIONINSIGHTS_CONNECTION_STRING: useApplicationInsights
@@ -324,7 +338,7 @@ var appEnvVariables = {
324338
AZURE_OPENAI_SERVICE: isAzureOpenAiHost && deployAzureOpenAi ? openAi.outputs.name : ''
325339
AZURE_OPENAI_CHATGPT_DEPLOYMENT: chatGpt.deploymentName
326340
AZURE_OPENAI_EMB_DEPLOYMENT: embedding.deploymentName
327-
AZURE_OPENAI_GPT4V_DEPLOYMENT: useGPT4V ? gpt4vDeploymentName : ''
341+
AZURE_OPENAI_GPT4V_DEPLOYMENT: useGPT4 ? gpt4vDeploymentName : ''
328342
AZURE_OPENAI_API_VERSION: azureOpenAiApiVersion
329343
AZURE_OPENAI_API_KEY_OVERRIDE: azureOpenAiApiKey
330344
AZURE_OPENAI_CUSTOM_URL: azureOpenAiCustomUrl
@@ -346,7 +360,7 @@ var appEnvVariables = {
346360
// CORS support, for frontends on other hosts
347361
ALLOWED_ORIGIN: allowedOrigin
348362
USE_VECTORS: useVectors
349-
USE_GPT4V: useGPT4V
363+
USE_GPT4V: useGPT4
350364
USE_USER_UPLOAD: useUserUpload
351365
AZURE_USERSTORAGE_ACCOUNT: useUserUpload ? userStorage.outputs.name : ''
352366
AZURE_USERSTORAGE_CONTAINER: useUserUpload ? userStorageContainerName : ''
@@ -470,7 +484,7 @@ var defaultOpenAiDeployments = [
470484

471485
var openAiDeployments = concat(
472486
defaultOpenAiDeployments,
473-
useGPT4V
487+
useGPT4v
474488
? [
475489
{
476490
name: gpt4vDeploymentName
@@ -534,7 +548,7 @@ module documentIntelligence 'br/public:avm/res/cognitive-services/account:0.5.4'
534548
}
535549
}
536550

537-
module computerVision 'br/public:avm/res/cognitive-services/account:0.5.4' = if (useGPT4V) {
551+
module computerVision 'br/public:avm/res/cognitive-services/account:0.5.4' = if (useGPT4) {
538552
name: 'computerVision'
539553
scope: computerVisionResourceGroup
540554
params: {
@@ -856,7 +870,7 @@ var openAiPrivateEndpointConnection = (isAzureOpenAiHost && deployAzureOpenAi &&
856870
dnsZoneName: 'privatelink.openai.azure.com'
857871
resourceIds: concat(
858872
[openAi.outputs.resourceId],
859-
useGPT4V ? [computerVision.outputs.resourceId] : [],
873+
useGPT4 ? [computerVision.outputs.resourceId] : [],
860874
!useLocalPdfParser ? [documentIntelligence.outputs.resourceId] : []
861875
)
862876
}
@@ -927,7 +941,7 @@ module searchContribRoleBackend 'core/security/role.bicep' = if (useUserUpload)
927941
}
928942

929943
// For computer vision access by the backend
930-
module computerVisionRoleBackend 'core/security/role.bicep' = if (useGPT4V) {
944+
module computerVisionRoleBackend 'core/security/role.bicep' = if (useGPT4) {
931945
scope: computerVisionResourceGroup
932946
name: 'computervision-role-backend'
933947
params: {
@@ -974,7 +988,7 @@ output AZURE_OPENAI_GPT4V_DEPLOYMENT string = isAzureOpenAiHost ? gpt4vDeploymen
974988
output AZURE_SPEECH_SERVICE_ID string = useSpeechOutputAzure ? speech.outputs.resourceId : ''
975989
output AZURE_SPEECH_SERVICE_LOCATION string = useSpeechOutputAzure ? speech.outputs.location : ''
976990

977-
output AZURE_VISION_ENDPOINT string = useGPT4V ? computerVision.outputs.endpoint : ''
991+
output AZURE_VISION_ENDPOINT string = useGPT4 ? computerVision.outputs.endpoint : ''
978992

979993
output AZURE_DOCUMENTINTELLIGENCE_SERVICE string = documentIntelligence.outputs.name
980994
output AZURE_DOCUMENTINTELLIGENCE_RESOURCE_GROUP string = documentIntelligenceResourceGroup.name

infra/main.parameters.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@
153153
"value": "${USE_VECTORS=true}"
154154
},
155155
"useGPT4V": {
156-
"value": "${USE_GPT4V=false}"
156+
"value": "${USE_GPT4V}"
157157
},
158158
"enableLanguagePicker": {
159159
"value": "${ENABLE_LANGUAGE_PICKER=false}"

0 commit comments

Comments
 (0)