More tests, Windows check

Author: pamelafox

.github/workflows/python-test.yaml

@@ -62,8 +62,10 @@ jobs:
         - name: Check formatting with black
           run: black . --check --verbose
         - name: Run Python tests
+          if: runner.os != 'Windows'
           run: pytest -s -vv --cov --cov-report=xml --cov-fail-under=90
         - name: Check diff coverage
+          if: runner.os != 'Windows'
           run: |
             git fetch origin main:refs/remotes/origin/main
             diff-cover coverage.xml --compare-branch=origin/main --fail-under=90

tests/mocks.py

@@ -108,10 +108,10 @@ async def __aexit__(self, *args):
         pass
 
     async def open(self):
-        pass
+        pass  # pragma: no cover
 
     async def close(self):
-        pass
+        pass  # pragma: no cover
 
 
 class MockAsyncPageIterator:

tests/test_blob_manager.py

@@ -166,7 +166,7 @@ async def test_dont_remove_if_no_container(
     monkeypatch, mock_env, mock_blob_container_client_does_not_exist, blob_manager
 ):
     async def mock_delete_blob(*args, **kwargs):
-        assert False, "delete_blob() shouldn't have been called"
+        assert False, "delete_blob() shouldn't have been called"  # pragma: no cover
 
     monkeypatch.setattr("azure.storage.blob.aio.ContainerClient.delete_blob", mock_delete_blob)
 
@@ -377,7 +377,7 @@ def __init__(self):
             self.properties = None  # This is the condition we're testing
 
         async def readall(self):
-            return b"This content should not be returned"
+            assert False, "This should not be called, as properties is None"  # pragma: no cover
 
     async def mock_download_blob(*args, **kwargs):
         return MockDownloadResponseWithNoProperties()

tests/test_searchmanager.py

@@ -508,7 +508,7 @@ async def mock_create_index(self, index):
 
     async def mock_list_index_names(self):
         for index in []:
-            yield index
+            yield index  # pragma: no cover
 
     monkeypatch.setattr(SearchIndexClient, "create_index", mock_create_index)
     monkeypatch.setattr(SearchIndexClient, "list_index_names", mock_list_index_names)
@@ -562,17 +562,6 @@ async def mock_list_index_names(self):
 @pytest.mark.asyncio
 async def test_create_index_with_search_images_no_endpoint(monkeypatch, search_info):
     """Test that SearchManager raises an error when search_images=True but no Azure Vision endpoint is provided."""
-    indexes = []
-
-    async def mock_create_index(self, index):
-        indexes.append(index)
-
-    async def mock_list_index_names(self):
-        for index in []:
-            yield index
-
-    monkeypatch.setattr(SearchIndexClient, "create_index", mock_create_index)
-    monkeypatch.setattr(SearchIndexClient, "list_index_names", mock_list_index_names)
 
     # Create a SearchManager with search_images=True but no Azure Vision endpoint
     manager = SearchManager(
@@ -599,25 +588,7 @@ async def mock_create_index(self, index):
 
     async def mock_list_index_names(self):
         for index in []:
-            yield index
-
-    async def mock_create_client(*args, **kwargs):
-        return MockClient(
-            embeddings_client=MockEmbeddingsClient(
-                create_embedding_response=openai.types.CreateEmbeddingResponse(
-                    object="list",
-                    data=[
-                        openai.types.Embedding(
-                            embedding=[0.1, 0.2, 0.3],
-                            index=0,
-                            object="embedding",
-                        )
-                    ],
-                    model=MOCK_EMBEDDING_MODEL_NAME,
-                    usage=Usage(prompt_tokens=8, total_tokens=8),
-                )
-            )
-        )
+            yield index  # pragma: no cover
 
     monkeypatch.setattr(SearchIndexClient, "create_index", mock_create_index)
     monkeypatch.setattr(SearchIndexClient, "list_index_names", mock_list_index_names)
@@ -640,7 +611,6 @@ async def mock_create_client(*args, **kwargs):
         credential=AzureKeyCredential("test"),
         disable_batch=True,
     )
-    monkeypatch.setattr(embeddings, "create_client", mock_create_client)
 
     # Create a SearchManager with both search_images and embeddings
     manager = SearchManager(