Skip to content

Commit 7443f9e

Browse files
committed
Properly handle Azure speech service voice var
1 parent 023dc1b commit 7443f9e

File tree

6 files changed

+10
-2
lines changed

6 files changed

+10
-2
lines changed

.azdo/pipelines/azure-dev.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ steps:
101101
AZURE_SPEECH_SERVICE_RESOURCE_GROUP: $(AZURE_SPEECH_SERVICE_RESOURCE_GROUP)
102102
AZURE_SPEECH_SERVICE_LOCATION: $(AZURE_SPEECH_SERVICE_LOCATION)
103103
AZURE_SPEECH_SERVICE_SKU: $(AZURE_SPEECH_SERVICE_SKU)
104+
AZURE_SPEECH_SERVICE_VOICE: $(AZURE_SPEECH_SERVICE_VOICE)
104105
AZURE_KEY_VAULT_NAME: $(AZURE_KEY_VAULT_NAME)
105106
AZURE_USE_AUTHENTICATION: $(AZURE_USE_AUTHENTICATION)
106107
AZURE_ENFORCE_ACCESS_CONTROL: $(AZURE_ENFORCE_ACCESS_CONTROL)

.github/workflows/azure-dev.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ jobs:
8787
AZURE_SPEECH_SERVICE_RESOURCE_GROUP: ${{ vars.AZURE_SPEECH_RESOURCE_GROUP }}
8888
AZURE_SPEECH_SERVICE_LOCATION: ${{ vars.AZURE_SPEECH_SERVICE_LOCATION }}
8989
AZURE_SPEECH_SERVICE_SKU: ${{ vars.AZURE_SPEECH_SERVICE_SKU }}
90+
AZURE_SPEECH_SERVICE_VOICE: ${{ vars.AZURE_SPEECH_SERVICE_VOICE }}
9091
AZURE_KEY_VAULT_NAME: ${{ vars.AZURE_KEY_VAULT_NAME }}
9192
AZURE_USE_AUTHENTICATION: ${{ vars.AZURE_USE_AUTHENTICATION }}
9293
AZURE_ENFORCE_ACCESS_CONTROL: ${{ vars.AZURE_ENFORCE_ACCESS_CONTROL }}

app/backend/app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ async def setup_clients():
444444

445445
AZURE_SPEECH_SERVICE_ID = os.getenv("AZURE_SPEECH_SERVICE_ID")
446446
AZURE_SPEECH_SERVICE_LOCATION = os.getenv("AZURE_SPEECH_SERVICE_LOCATION")
447-
AZURE_SPEECH_VOICE = os.getenv("AZURE_SPEECH_VOICE", "en-US-AndrewMultilingualNeural")
447+
AZURE_SPEECH_SERVICE_VOICE = os.getenv("AZURE_SPEECH_SERVICE_VOICE") or "en-US-AndrewMultilingualNeural"
448448

449449
USE_GPT4V = os.getenv("USE_GPT4V", "").lower() == "true"
450450
USE_USER_UPLOAD = os.getenv("USE_USER_UPLOAD", "").lower() == "true"
@@ -567,7 +567,7 @@ async def setup_clients():
567567
raise ValueError("Azure speech resource not configured correctly, missing AZURE_SPEECH_SERVICE_LOCATION")
568568
current_app.config[CONFIG_SPEECH_SERVICE_ID] = AZURE_SPEECH_SERVICE_ID
569569
current_app.config[CONFIG_SPEECH_SERVICE_LOCATION] = AZURE_SPEECH_SERVICE_LOCATION
570-
current_app.config[CONFIG_SPEECH_SERVICE_VOICE] = AZURE_SPEECH_VOICE
570+
current_app.config[CONFIG_SPEECH_SERVICE_VOICE] = AZURE_SPEECH_SERVICE_VOICE
571571
# Wait until token is needed to fetch for the first time
572572
current_app.config[CONFIG_SPEECH_SERVICE_TOKEN] = None
573573
current_app.config[CONFIG_CREDENTIAL] = azure_credential

azure.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ pipeline:
100100
- AZURE_SPEECH_SERVICE_RESOURCE_GROUP
101101
- AZURE_SPEECH_SERVICE_LOCATION
102102
- AZURE_SPEECH_SERVICE_SKU
103+
- AZURE_SPEECH_SERVICE_VOICE
103104
- AZURE_KEY_VAULT_NAME
104105
- AZURE_USE_AUTHENTICATION
105106
- AZURE_ENFORCE_ACCESS_CONTROL

infra/main.bicep

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ param speechServiceResourceGroupName string = ''
5757
param speechServiceLocation string = ''
5858
param speechServiceName string = ''
5959
param speechServiceSkuName string // Set in main.parameters.json
60+
param speechServiceVoice string = ''
6061
param useGPT4V bool = false
6162

6263
@description('Location for the OpenAI resource group')
@@ -325,6 +326,7 @@ var appEnvVariables = {
325326
: ''
326327
AZURE_SPEECH_SERVICE_ID: useSpeechOutputAzure ? speech.outputs.resourceId : ''
327328
AZURE_SPEECH_SERVICE_LOCATION: useSpeechOutputAzure ? speech.outputs.location : ''
329+
AZURE_SPEECH_SERVICE_VOICE: useSpeechOutputAzure ? speechServiceVoice : ''
328330
ENABLE_LANGUAGE_PICKER: enableLanguagePicker
329331
USE_SPEECH_INPUT_BROWSER: useSpeechInputBrowser
330332
USE_SPEECH_OUTPUT_BROWSER: useSpeechOutputBrowser

infra/main.parameters.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,9 @@
200200
"speechServiceLocation": {
201201
"value": "${AZURE_SPEECH_SERVICE_LOCATION}"
202202
},
203+
"speechServiceVoice": {
204+
"value": "${AZURE_SPEECH_SERVICE_VOICE}"
205+
},
203206
"useAuthentication": {
204207
"value": "${AZURE_USE_AUTHENTICATION=false}"
205208
},

0 commit comments

Comments
 (0)