Feedback from Matt

Author: pamelafox

app/backend/app.py

@@ -821,7 +821,7 @@ def create_app():
 
     # Log levels should be one of https://docs.python.org/3/library/logging.html#logging-levels
     # Set root level to WARNING to avoid seeing overly verbose logs from SDKS
-    logging.basicConfig(level=logging.DEBUG)
+    logging.basicConfig(level=logging.WARNING)
     # Set our own logger levels to INFO by default
     app_level = os.getenv("APP_LOG_LEVEL", "INFO")
     app.logger.setLevel(os.getenv("APP_LOG_LEVEL", app_level))

docs/deploy_private.md

@@ -51,7 +51,7 @@ Deploying with public access disabled adds additional cost to your deployment. P
     ```shell
     azd env set AZURE_USE_PRIVATE_ENDPOINT true
     azd env set AZURE_USE_VPN_GATEWAY true
-    azd env set AZURE_PUBLIC_NETWORK_ACCESS Enabled
+    azd env set AZURE_PUBLIC_NETWORK_ACCESS Disabled
     azd up
     ```
 

infra/network-isolation.bicep

@@ -234,10 +234,8 @@ module vnet 'br/public:avm/res/network/virtual-network:0.6.1' = {
       {
         name: 'app-int-subnet'
         addressPrefix: '10.0.0.0/21'
-        //privateEndpointNetworkPolicies: 'Enabled' // TODO: Needed?
-        //privateLinkServiceNetworkPolicies: 'Enabled' // TODO: Needed?
         networkSecurityGroupResourceId: containerAppsNSG.outputs.resourceId
-        delegation: 'Microsoft.App/environments' // TODO: Needed?
+        delegation: 'Microsoft.App/environments'
       }
     ]
   }

todo.txt

@@ -1 +1,5 @@
 * Better error when youre trying to run prepdocs and not connected to VPN.
+   * Hit up /ping and check that it returns 200 OK. Anything else = no bueno.
+   * If they have AZURE_USE_PRIVATE_ENDPOINT and it gets non-200, reminds them to set up VPN.
+* Bring back App Service's subnet
+* Move vnet-y things into network-isolation.bicep