Skip to content

Commit bd73a5d

Browse files
committed
Accept gpt and chat gpt deployment names as parameters; Ensure empty strings are not allowed
1 parent 868d238 commit bd73a5d

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

infra/main.bicep

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ param formRecognizerResourceGroupLocation string = location
3737

3838
param formRecognizerSkuName string = 'S0'
3939

40-
param gptDeploymentName string = 'davinci'
40+
param gptDeploymentName string = ''
4141
param gptDeploymentCapacity int = 30
4242
param gptModelName string = 'text-davinci-003'
43-
param chatGptDeploymentName string = 'chat'
43+
param chatGptDeploymentName string = ''
4444
param chatGptDeploymentCapacity int = 30
4545
param chatGptModelName string = 'gpt-35-turbo'
4646

@@ -50,6 +50,8 @@ param principalId string = ''
5050
var abbrs = loadJsonContent('abbreviations.json')
5151
var resourceToken = toLower(uniqueString(subscription().id, environmentName, location))
5252
var tags = { 'azd-env-name': environmentName }
53+
var gptDeployment = empty(gptDeploymentName) ? 'davinci' : gptDeploymentName
54+
var chatGptDeployment = empty(chatGptDeploymentName) ? 'chat' : chatGptDeploymentName
5355

5456
// Organize resources in a resource group
5557
resource resourceGroup 'Microsoft.Resources/resourceGroups@2021-04-01' = {
@@ -109,8 +111,8 @@ module backend 'core/host/appservice.bicep' = {
109111
AZURE_OPENAI_SERVICE: openAi.outputs.name
110112
AZURE_SEARCH_INDEX: searchIndexName
111113
AZURE_SEARCH_SERVICE: searchService.outputs.name
112-
AZURE_OPENAI_GPT_DEPLOYMENT: gptDeploymentName
113-
AZURE_OPENAI_CHATGPT_DEPLOYMENT: chatGptDeploymentName
114+
AZURE_OPENAI_GPT_DEPLOYMENT: gptDeployment
115+
AZURE_OPENAI_CHATGPT_DEPLOYMENT: chatGptDeployment
114116
}
115117
}
116118
}
@@ -127,7 +129,7 @@ module openAi 'core/ai/cognitiveservices.bicep' = {
127129
}
128130
deployments: [
129131
{
130-
name: gptDeploymentName
132+
name: gptDeployment
131133
model: {
132134
format: 'OpenAI'
133135
name: gptModelName
@@ -136,7 +138,7 @@ module openAi 'core/ai/cognitiveservices.bicep' = {
136138
capacity: gptDeploymentCapacity
137139
}
138140
{
139-
name: chatGptDeploymentName
141+
name: chatGptDeployment
140142
model: {
141143
format: 'OpenAI'
142144
name: chatGptModelName
@@ -313,8 +315,8 @@ output AZURE_RESOURCE_GROUP string = resourceGroup.name
313315

314316
output AZURE_OPENAI_SERVICE string = openAi.outputs.name
315317
output AZURE_OPENAI_RESOURCE_GROUP string = openAiResourceGroup.name
316-
output AZURE_OPENAI_GPT_DEPLOYMENT string = gptDeploymentName
317-
output AZURE_OPENAI_CHATGPT_DEPLOYMENT string = chatGptDeploymentName
318+
output AZURE_OPENAI_GPT_DEPLOYMENT string = gptDeployment
319+
output AZURE_OPENAI_CHATGPT_DEPLOYMENT string = chatGptDeployment
318320

319321
output AZURE_FORMRECOGNIZER_SERVICE string = formRecognizer.outputs.name
320322
output AZURE_FORMRECOGNIZER_RESOURCE_GROUP string = formRecognizerResourceGroup.name

infra/main.parameters.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,12 @@
4343
},
4444
"storageResourceGroupName": {
4545
"value": "${AZURE_STORAGE_RESOURCE_GROUP}"
46+
},
47+
"chatGptDeploymentName": {
48+
"value": "${AZURE_OPENAI_CHATGPT_DEPLOYMENT}"
49+
},
50+
"gptDeploymentName": {
51+
"value": "${AZURE_OPENAI_GPT_DEPLOYMENT}"
4652
}
4753
}
4854
}

0 commit comments

Comments
 (0)