Skip to content

Conversation

pamelafox
Copy link
Collaborator

@pamelafox pamelafox commented Oct 28, 2024

Purpose

Improve the developer experience for new developers by using ACA for faster deployment.
The biggest drawback of this change is that existing developers will need to keep a code change to azure.yaml in order to keep using App Service, since we can't do this with solely environment variables.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[X] Yes - existing devs need to follow app service guide to keep using it.
[ ] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[X] No - I dont see an App Service mention

Type of change

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

@pamelafox pamelafox merged commit e34edd5 into Azure-Samples:main Oct 28, 2024
16 checks passed
@pamelafox pamelafox deleted the acadefault branch October 28, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants