Bug report in digital-locker smart contract

[academic-starter]

• Constructor function does not satisfy its specification
  

  blockchain/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol

  Lines 18 to 24 in 1b712d6

  	constructor(string memory lockerFriendlyName, address bankAgent) public
  	{
  	Owner = msg.sender;
  	LockerFriendlyName = lockerFriendlyName;
  	State = StateType.DocumentReview; //////////////// should be StateType.Requested?

As documented by its following specification, Constructor funtion should finish with Requested state instead of DocumentReview.

blockchain/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.json

Line 31 in 1b712d6

"StartState": "Requested",

• Other implementation bugs according to contract specification.
  

  blockchain/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.json

  Lines 272 to 421 in 1b712d6

  	"States": [
  	{
  	"Name": "Requested",
  	"DisplayName": "Requested",
  	"Description": "...",
  	"PercentComplete": 0,
  	"Style": "Success",
  	"Transitions": [
  	{
  	"AllowedRoles": [
  	"BankAgent"
  	],
  	"AllowedInstanceRoles": [],
  	"Description": "...",
  	"Function": "BeginReviewProcess",
  	"NextStates": [
  	"DocumentReview"
  	],
  	"DisplayName": "Begin Review Process"
  	}
  	]
  	},
  	{
  	"Name": "DocumentReview",
  	"DisplayName": "DocumentReview",
  	"Description": "...",
  	"PercentComplete": 20,
  	"Style": "Success",
  	"Transitions": [
  	{
  	"AllowedRoles": [],
  	"AllowedInstanceRoles": [ "BankAgent" ],
  	"Description": "...",
  	"Function": "UploadDocuments",
  	"NextStates": [ "AvailableToShare" ],
  	"DisplayName": "Upload Documents Placeholder"
  	}
  	]
  	},
  	{
  	"Name": "AvailableToShare",
  	"DisplayName": "Available To Share",
  	"Description": "...",
  	"PercentComplete": 30,
  	"Style": "Success",
  	"Transitions": [
  	{
  	"AllowedRoles": [],
  	"AllowedInstanceRoles": [ "Owner" ],
  	"Description": "...",
  	"Function": "ShareWithThirdParty",
  	"NextStates": ["SharingWithThirdParty" ],
  	"DisplayName": "Share With Third Party"
  	},
  	{
  	"AllowedRoles": [],
  	"AllowedInstanceRoles": [ "Owner" ],
  	"Description": "...",
  	"Function": "Terminate",
  	"NextStates": [ "Terminated" ],
  	"DisplayName": "Terminate"
  	},
  	{
  	"AllowedRoles": [ "ThirdPartyRequestor" ],
  	"AllowedInstanceRoles": [],
  	"Description": "...",
  	"Function": "RequestLockerAccess",
  	"NextStates": [ "SharingRequestPending" ],
  	"DisplayName": "Request Locker Access"
  	}
  	]
  	},
  	{
  	"Name": "SharingRequestPending",
  	"DisplayName": "Sharing Request Pending",
  	"Description": "...",
  	"PercentComplete": 40,
  	"Style": "Success",
  	"Transitions": [
  	{
  	"AllowedRoles": [],
  	"AllowedInstanceRoles": [ "Owner" ],
  	"Description": "...",
  	"Function": "AcceptSharingRequest",
  	"NextStates": [
  	"SharingWithThirdParty"
  	],
  	"DisplayName": "Accept Sharing Request"
  	},
  	{
  	"AllowedRoles": [],
  	"AllowedInstanceRoles": [ "Owner" ],
  	"Description": "...",
  	"Function": "RejectSharingRequest",
  	"NextStates": [ "AvailableToShare" ],
  	"DisplayName": "Reject Sharing Request"
  	},
  	{
  	"AllowedRoles": [],
  	"AllowedInstanceRoles": [ "Owner" ],
  	"Description": "...",
  	"Function": "Terminate",
  	"NextStates": [ "Terminated" ],
  	"DisplayName": "Terminate"
  	}
  	]
  	},
  	{
  	"Name": "SharingWithThirdParty",
  	"DisplayName": "Sharing With Third Party",
  	"Description": "...",
  	"PercentComplete": 45,
  	"Style": "Success",
  	"Transitions": [
  	{
  	"AllowedRoles": [],
  	"AllowedInstanceRoles": [ "Owner" ],
  	"Description": "...",
  	"Function": "RevokeAccessFromThirdParty",
  	"NextStates": [ "AvailableToShare" ],
  	"DisplayName": "Revoke Access From Third Party"
  	},
  	{
  	"AllowedRoles": [],
  	"AllowedInstanceRoles": [ "Owner" ],
  	"Description": "...",
  	"Function": "Terminate",
  	"NextStates": [ "Terminated" ],
  	"DisplayName": "Terminate"
  	},
  	{
  	"AllowedRoles": [],
  	"AllowedInstanceRoles": [ "ThirdPartyRequestor" ],
  	"Description": "...",
  	"Function": "ReleaseLockerAccess",
  	"NextStates": [ "AvailableToShare" ],
  	"DisplayName": "Release Locker Access"
  	}
  	]
  	},
  	{
  	"Name": "Terminated",
  	"DisplayName": "Terminated",
  	"Description": "...",
  	"PercentComplete": 100,
  	"Style": "Failure",
  	"Transitions": []
  	}
  	]
  	}

1. BeginReviewProcess function should begin with Requested state.
   

   blockchain/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol

   Line 29 in 1b712d6

   function BeginReviewProcess() public

2. UploadDocuments function should begin with DocumentReview state.
   

   blockchain/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol

   Line 56 in 1b712d6

   function UploadDocuments(string memory lockerIdentifier, string memory image) public

3. ShareWithThirdParty should begin with AvailableToShare state.
   

   blockchain/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol

   Line 68 in 1b712d6

   function ShareWithThirdParty(address thirdPartyRequestor, string memory expirationDate, string memory intendedPurpose) public

4. AcceptSharingRequest should begin with SharingRequestPending state.
   

   blockchain/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol

   Line 84 in 1b712d6

   function AcceptSharingRequest() public

5. RejectSharingRequest should begin with SharingRequestPending state.
   

   blockchain/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol

   Line 95 in 1b712d6

   function RejectSharingRequest() public

6. RequestLockerAccess should begin with AvailableToShare state.
   

   blockchain/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol

   Line 106 in 1b712d6

   function RequestLockerAccess(string memory intendedPurpose) public

7. ReleaseLockerAccess should begin with SharingWithThirdParty state.
   https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#118

8. RevokeAccessFromThirdParty should begin with SharingWithThirdParty state.
   

   blockchain/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol

   Line 132 in 1b712d6

   function RevokeAccessFromThirdParty() public

9. Terminate should begin with AvailableToShare|SharingRequestPending|SharingWithThirdParty state.
   

   blockchain/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol

   Line 143 in 1b712d6

   function Terminate() public

[SimonGareis]

Hello  Can you send the ethereum coins on this adresss  0xFBb85E92d42e7f00bf03A299874fa4Db816B5F7C Thanks Simon Gareis INB Philosophy LLC  Gesendet von Yahoo Mail auf Android Am Do., Feb. 22, 2024 at 8:30 schrieb ***@***.***>: - Constructor function does not satisfy its specification https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L18-L24 As documented by its following specification, Constructor funtion should finish with Requested state instead of DocumentReview. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.json#L31 - Other implementation bugs according to contract specification. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.json#L272-L421 - BeginReviewProcess function should begin with Requested state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L29 - UploadDocuments function should begin with DocumentReview state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L56 - ShareWithThirdParty should begin with AvailableToShare state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L68 - AcceptSharingRequest should begin with SharingRequestPending state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L84 - RejectSharingRequest should begin with SharingRequestPending state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L95 - RequestLockerAccess should begin with AvailableToShare state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L106 - ReleaseLockerAccess should begin with SharingWithThirdParty state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#118 - RevokeAccessFromThirdParty should begin with SharingWithThirdParty state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L132 - Terminate should begin with AvailableToShare|SharingRequestPending|SharingWithThirdParty state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L143 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>