Skip to content

Commit 17b61fb

Browse files
fix: Update private networking dependency logic and adjust OpenAI parameters
1 parent 31972e1 commit 17b61fb

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

infra/main.bicep

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -830,8 +830,6 @@ var openAiDeployments = concat(
830830
: []
831831
)
832832

833-
// Keep private networking disabled for OpenAI when using integrated vectorization in Azure Cognitive Search, as indexer requires it.
834-
var enablePrivateNetworkingForOpenAI = enablePrivateNetworking && azureSearchUseIntegratedVectorization == false
835833
module openai 'modules/core/ai/cognitiveservices.bicep' = {
836834
name: azureOpenAIResourceName
837835
scope: resourceGroup()
@@ -886,7 +884,7 @@ module openai 'modules/core/ai/cognitiveservices.bicep' = {
886884
: []
887885
)
888886
}
889-
dependsOn: enablePrivateNetworkingForOpenAI ? avmPrivateDnsZones : []
887+
dependsOn: enablePrivateNetworking ? avmPrivateDnsZones : []
890888
}
891889

892890
module computerVision 'modules/core/ai/cognitiveservices.bicep' = if (useAdvancedImageProcessing) {

infra/main.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"_generator": {
77
"name": "bicep",
88
"version": "0.37.4.10188",
9-
"templateHash": "5060547412943026398"
9+
"templateHash": "13005999981929939317"
1010
}
1111
},
1212
"parameters": {
@@ -697,7 +697,6 @@
697697
}
698698
],
699699
"openAiDeployments": "[concat(variables('defaultOpenAiDeployments'), if(parameters('useAdvancedImageProcessing'), createArray(createObject('name', parameters('azureOpenAIVisionModel'), 'model', createObject('format', 'OpenAI', 'name', parameters('azureOpenAIVisionModelName'), 'version', parameters('azureOpenAIVisionModelVersion')), 'sku', createObject('name', 'GlobalStandard', 'capacity', parameters('azureOpenAIVisionModelCapacity')))), createArray()))]",
700-
"enablePrivateNetworkingForOpenAI": "[and(parameters('enablePrivateNetworking'), equals(parameters('azureSearchUseIntegratedVectorization'), false()))]",
701700
"enablePrivateNetworkingSpeech": false,
702701
"webServerFarmResourceName": "[variables('hostingPlanName')]",
703702
"postgresDBFqdn": "[format('{0}.postgres.database.azure.com', variables('postgresResourceName'))]",
@@ -56366,9 +56365,9 @@
5636656365
}
5636756366
},
5636856367
"dependsOn": [
56369-
"[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').storageQueue)]",
56370-
"[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').storageFile)]",
5637156368
"[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').storageBlob)]",
56369+
"[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').storageFile)]",
56370+
"[format('avmPrivateDnsZones[{0}]', variables('dnsZoneIndex').storageQueue)]",
5637256371
"managedIdentityModule",
5637356372
"network"
5637456373
]

infra/main.parameters.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@
123123
"value": "${AZURE_OPENAI_TOP_P=1}"
124124
},
125125
"azureOpenAIStopSequence": {
126-
"value": "${AZURE_OPENAI_STOP_SEQUENCE}"
126+
"value": "${AZURE_OPENAI_STOP_SEQUENCE=\n}"
127127
},
128128
"azureOpenAISystemMessage": {
129129
"value": "${AZURE_OPENAI_SYSTEM_MESSAGE=You are an AI assistant that helps people find information.}"

0 commit comments

Comments
 (0)