Skip to content

Commit 656e045

Browse files
fix: Retain compatibility with existing deployments by using previous environment variables if new ones are unavailable (#1356)
Co-authored-by: Pavan Kumar <v-kupavan.microsoft.com>
1 parent 6f03aab commit 656e045

File tree

1 file changed

+26
-16
lines changed

1 file changed

+26
-16
lines changed

code/backend/batch/utilities/helpers/env_helper.py

Lines changed: 26 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -93,18 +93,22 @@ def __load_config(self, **kwargs) -> None:
9393

9494
self.AZURE_AUTH_TYPE = os.getenv("AZURE_AUTH_TYPE", "keys")
9595
# Azure OpenAI
96-
# Default model info
97-
default_azure_openai_model_info = '{"model":"gpt-35-turbo-16k","modelName":"gpt-35-turbo-16k","modelVersion":"0613"}'
98-
default_azure_openai_embedding_model_info = '{"model":"text-embedding-ada-002","modelName":"text-embedding-ada-002","modelVersion":"2"}'
99-
10096
self.AZURE_OPENAI_RESOURCE = os.getenv("AZURE_OPENAI_RESOURCE", "")
97+
# Fetch AZURE_OPENAI_MODEL_INFO from environment
98+
azure_openai_model_info = self.get_info_from_env("AZURE_OPENAI_MODEL_INFO", "")
10199

102-
# Fetch and assign model info
103-
azure_openai_model_info = self.get_info_from_env(
104-
"AZURE_OPENAI_MODEL_INFO", default_azure_openai_model_info
105-
)
106-
self.AZURE_OPENAI_MODEL = azure_openai_model_info.get("model")
107-
self.AZURE_OPENAI_MODEL_NAME = azure_openai_model_info.get("modelName")
100+
if azure_openai_model_info:
101+
# If AZURE_OPENAI_MODEL_INFO exists
102+
self.AZURE_OPENAI_MODEL = azure_openai_model_info.get("model", "")
103+
self.AZURE_OPENAI_MODEL_NAME = azure_openai_model_info.get("modelName", "")
104+
else:
105+
# Otherwise, fallback to individual environment variables
106+
self.AZURE_OPENAI_MODEL = os.getenv(
107+
"AZURE_OPENAI_MODEL", "gpt-35-turbo-16k"
108+
)
109+
self.AZURE_OPENAI_MODEL_NAME = os.getenv(
110+
"AZURE_OPENAI_MODEL_NAME", "gpt-35-turbo-16k"
111+
)
108112

109113
self.AZURE_OPENAI_VISION_MODEL = os.getenv("AZURE_OPENAI_VISION_MODEL", "gpt-4")
110114
self.AZURE_OPENAI_TEMPERATURE = os.getenv("AZURE_OPENAI_TEMPERATURE", "0")
@@ -120,14 +124,20 @@ def __load_config(self, **kwargs) -> None:
120124
)
121125
self.AZURE_OPENAI_STREAM = os.getenv("AZURE_OPENAI_STREAM", "true")
122126

123-
# Fetch and assign embedding model info
127+
# Fetch AZURE_OPENAI_EMBEDDING_MODEL_INFO from environment
124128
azure_openai_embedding_model_info = self.get_info_from_env(
125-
"AZURE_OPENAI_EMBEDDING_MODEL_INFO",
126-
default_azure_openai_embedding_model_info,
127-
)
128-
self.AZURE_OPENAI_EMBEDDING_MODEL = azure_openai_embedding_model_info.get(
129-
"model"
129+
"AZURE_OPENAI_EMBEDDING_MODEL_INFO", ""
130130
)
131+
if azure_openai_embedding_model_info:
132+
# If AZURE_OPENAI_EMBEDDING_MODEL_INFO exists
133+
self.AZURE_OPENAI_EMBEDDING_MODEL = azure_openai_embedding_model_info.get(
134+
"model", ""
135+
)
136+
else:
137+
# Otherwise, fallback to individual environment variable
138+
self.AZURE_OPENAI_EMBEDDING_MODEL = os.getenv(
139+
"AZURE_OPENAI_EMBEDDING_MODEL", "text-embedding-ada-002"
140+
)
131141

132142
self.SHOULD_STREAM = (
133143
True if self.AZURE_OPENAI_STREAM.lower() == "true" else False

0 commit comments

Comments
 (0)